From patchwork Tue Nov 8 22:45:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georgi Vlaev X-Patchwork-Id: 622727 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A927AC4332F for ; Tue, 8 Nov 2022 22:45:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229920AbiKHWp5 (ORCPT ); Tue, 8 Nov 2022 17:45:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229899AbiKHWpx (ORCPT ); Tue, 8 Nov 2022 17:45:53 -0500 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF89764A2C; Tue, 8 Nov 2022 14:45:50 -0800 (PST) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2A8Mjcgs062621; Tue, 8 Nov 2022 16:45:38 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1667947538; bh=BhXq8IRuZwYufdYayVffJkVeEfIGfFl1eMDVj0/IwzA=; h=From:To:CC:Subject:Date; b=d/93x65lVrIDwEHfYKxNsVrDGPyLsTog2ScNUmP4t48TA5bgdemm1BQpCzcoiN4Is GdmwYq8f06cOf2PtdSaKNcMvhRA82vlMLk/66kd0VpTELSl7p9M8yW3yW5i4JANmiy NUc5nA5V6KVU+CNH9/NVFBmC3OwePrjtuGJAn5ZY= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2A8MjcEN113777 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 8 Nov 2022 16:45:38 -0600 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Tue, 8 Nov 2022 16:45:37 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Tue, 8 Nov 2022 16:45:37 -0600 Received: from jti.ent.ti.com (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2A8MjSou071038; Tue, 8 Nov 2022 16:45:30 -0600 From: Georgi Vlaev To: Nishanth Menon , Tero Kristo , Santosh Shilimkar , Rob Herring , Krzysztof Kozlowski CC: , , , Vibhore Vardhan , Vignesh Raghavendra Subject: [PATCH v2 0/5] firmware: ti_sci: Introduce system suspend support Date: Wed, 9 Nov 2022 00:45:22 +0200 Message-ID: <20221108224527.137179-1-g-vlaev@ti.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This series introduces necessary ti_sci driver functionality in preparation of supporting DeepSleep mode for suspend to mem on TI K3 AM62x. This version is a fixup and rebase of the patch series by Dave Gerlach [1]. It applies on top of v6.1-rc4. Deep Sleep mode is described in section "5.2.4.4 DeepSleep" of the AM62x Technical Reference Manual [2]. The kernel triggers entry to Deep Sleep mode through the mem suspend transition with the following: * Use a TF-A binary that supports PSCI_SYSTEM_SUSPEND call. This causes system to use PSCI system suspend as last step of mem sleep. * The firmware requires that the OS sends a TISCI_MSG_PREPARE_SLEEP message in order to provide details about suspend, so we must add the ability to send this message. We also add TISCI_MSG_LPM_WAKE_REASON and TISCI_MSG_SET_IO_ISOLATION messages as part of a new PM ops. These messages are part of the TISCI PM Low Power Mode API [3]. (Patch 2) * A memory address must be provided to the firmware using the above message, which is allocated and managed by dma_alloc_coherent() and friends. (Patch 3) * System must load firmware to a specific location before Deep Sleep is entered, and this is accomplished using a memory region in device tree to indicate where this firmware should be loaded, and also a "firmware-name" property to indicate the name of the firmware to load. The ti_sci driver checks in its pm handler to see if the firmware has been loaded and if not, loads it. (Patch 4) * Finally, the ti_sci driver must actually send TISCI_MSG_PREPARE_SLEEP message to firmware with the above information included, which it does during the driver suspend handler when PM_MEM_SUSPEND is the determined state being entered. (Patch 5) This is tested on am625-sk using a limited dts with all devices disabled apart from cpu0, main_uart0, i2c, rtc, mmc/sd, dmsc, and secure_proxy_main. Testing this sequence requires K3 sdhci suspend/resume support [4], enable the wkup_rtc in the am625-sk.dts, disable devices that don't support system suspend/resume like OSPI and CPSW3G. In can be tested on the following branch: https://github.com/gvlaev/linux/tree/upstream-v6.2/lpm-ti-sci-v1 Changelog: v2: - Addressed comments received for v1 series [1]. - Updated v1 patch 5 to use pm notifier to avoid firmware loading issues. - Dropped the reserved region requirement and allocate DMA memory instead. The reserved region binding patch is also removed. - Introduce two more TISCI LPM messages that are supported in SysFW. - Fixes in error handling. [1] https://lore.kernel.org/lkml/20220421203659.27853-1-d-gerlach@ti.com [2] https://www.ti.com/lit/pdf/spruiv7 [3] https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/pm/lpm.html [4] https://lore.kernel.org/lkml/20220408124338.27090-1-a-govindraju@ti.com Dave Gerlach (5): dt-bindings: ti, sci: Add lpm region and firmware-name firmware: ti_sci: Introduce Power Management Ops firmware: ti_sci: Allocate memory for the LPM modes firmware: ti_sci: Use dt provided fw name and address to load at suspend time firmware: ti_sci: Introduce prepare system suspend call .../bindings/arm/keystone/ti,sci.yaml | 21 +- drivers/firmware/ti_sci.c | 356 ++++++++++++++++++ drivers/firmware/ti_sci.h | 64 +++- include/linux/soc/ti/ti_sci_protocol.h | 44 +++ 4 files changed, 480 insertions(+), 5 deletions(-) base-commit: f0c4d9fc9cc9462659728d168387191387e903cc Tested-by: Roger Quadros