mbox series

[v3,00/17] pinctrl/arm64: qcom: 4th set of Qualcomm TLMM pinctrl schema warnings

Message ID 20221016172212.49105-1-krzysztof.kozlowski@linaro.org
Headers show
Series pinctrl/arm64: qcom: 4th set of Qualcomm TLMM pinctrl schema warnings | expand

Message

Krzysztof Kozlowski Oct. 16, 2022, 5:21 p.m. UTC
Hi,

Changes since v2
================
1. Drop drive-strength, reword commit msg of "qcom,sm8250: use common TLMM pin
   schema" and "qcom,sc7280: use common TLMM pin schema".
2. Move "dt-bindings: pinctrl: qcom,sc7280: use common TLMM pin schema" to this
   patchset. Previously it was part of:
   https://lore.kernel.org/linux-devicetree/20220930192954.242546-1-krzysztof.kozlowski@linaro.org/
3. Add tags.

Changes since v1
================
1. Check for function on non-GPIO pins was moved to common TLMM schema, thus
   new patch #12: dt-bindings: pinctrl: qcom,sm8250: drop checks used in common
   TLMM

2. Above also makes minor context changes in patch #13 "dt-bindings: pinctrl:
   qcom,sm8250: fix matching pin config"

3. Add tags (I am using `b4 trailers` so they might appear in odd order).

Overview
========
This is the *fourth* patchset around Qualcomm pinctrl in recent days:
1. First round of TLMM fixes: merged
2. LPASS fixes:
   https://lore.kernel.org/linux-devicetree/20220927153429.55365-1-krzysztof.kozlowski@linaro.org/T/#t
3. ARMv7 TLMM fixes:
   https://lore.kernel.org/linux-arm-msm/20221016170035.35014-1-krzysztof.kozlowski@linaro.org/T/#t
4. ARMv8 remaining TLMM fixes: *THIS PATCHSET*
5. Fifth clean - styles and using common TLMM schema:
   https://lore.kernel.org/linux-arm-msm/20221011172358.69043-1-krzysztof.kozlowski@linaro.org/T/#m277d25a5f3e9d10ca8221a7fba62ca468a67a60b

Dependencies
============
1. Almost no dependencies - logically the bindings patch "dt-bindings: pinctrl:
   qcom,sm8250: drop checks used in common TLMM" depends on patchset #3 above.
   This is not a hard-dependency, everything will compile nicely, no warnings.

2. dt-bindings are independent of DTS patches.

Best regards,
Krzysztof

Krzysztof Kozlowski (17):
  arm64: dts: qcom: sm8250: align TLMM pin configuration with DT schema
  arm64: dts: qcom: sm8250-sony-xperia-edo: fix touchscreen bias-disable
  arm64: dts: qcom: sc8280xp: align TLMM pin configuration with DT
    schema
  arm64: dts: qcom: sc7280: align TLMM pin configuration with DT schema
    (really)
  arm64: dts: qcom: sc7280-herobrine: correct number of gpio-line-names
  arm64: dts: qcom: sc7280-idp-ec-h1: add missing QUP GPIO functions
  arm64: dts: qcom: msm8953: align TLMM pin configuration with DT schema
  arm64: dts: qcom: sdm845: align TLMM pin configuration with DT schema
  arm64: dts: qcom: sm6125-sony-xperia: add missing SD CD GPIO functions
  arm64: dts: qcom: sm6125: align TLMM pin configuration with DT schema
  dt-bindings: pinctrl: qcom,sm8250: add gpio-reserved-ranges and
    gpio-line-names
  dt-bindings: pinctrl: qcom,sm8250: use common TLMM pin schema
  dt-bindings: pinctrl: qcom,sm8250: fix matching pin config
  dt-bindings: pinctrl: qcom,sm8250: add input-enable
  dt-bindings: pinctrl: qcom,sc7280: correct number of GPIOs
  dt-bindings: pinctrl: qcom,sc7280: add bias-bus-hold and input-enable
  dt-bindings: pinctrl: qcom,sc7280: use common TLMM pin schema

 .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml |  28 +-
 .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 140 ++---
 arch/arm64/boot/dts/qcom/msm8953.dtsi         |  70 +--
 arch/arm64/boot/dts/qcom/qrb5165-rb5.dts      |  12 +-
 arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts    |   8 +-
 .../boot/dts/qcom/sc7280-herobrine-crd.dts    |   1 +
 .../dts/qcom/sc7280-herobrine-evoker-r0.dts   |   1 -
 .../qcom/sc7280-herobrine-herobrine-r1.dts    |   1 -
 .../dts/qcom/sc7280-herobrine-villager.dtsi   |   1 -
 .../arm64/boot/dts/qcom/sc7280-herobrine.dtsi |  44 +-
 .../arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi |  10 +-
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi      |  26 +-
 arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi    |  20 +-
 arch/arm64/boot/dts/qcom/sc7280.dtsi          | 316 +++++-----
 arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     |  12 +-
 .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    |  12 +-
 .../arm64/boot/dts/qcom/sdm845-lg-common.dtsi |   2 +-
 .../qcom/sm6125-sony-xperia-seine-pdx201.dts  |   2 +
 arch/arm64/boot/dts/qcom/sm6125.dtsi          |   4 +-
 arch/arm64/boot/dts/qcom/sm8250-mtp.dts       |  38 +-
 .../boot/dts/qcom/sm8250-sony-xperia-edo.dtsi |  18 +-
 arch/arm64/boot/dts/qcom/sm8250.dtsi          | 556 +++++++-----------
 22 files changed, 582 insertions(+), 740 deletions(-)

Comments

Krzysztof Kozlowski Oct. 18, 2022, 3:49 p.m. UTC | #1
On Sun, 16 Oct 2022 13:22:08 -0400, Krzysztof Kozlowski wrote:
> The TLMM pin controller follows generic pin-controller bindings, so
> should have subnodes with '-state' and '-pins'.  Otherwise the subnodes
> (level one and two) are not properly matched.  This method also unifies
> the bindings with other Qualcomm TLMM and LPASS pinctrl bindings.
> 
> The change causes indentation decrement, so the diff-hunk looks big, but
> there are no functional changes in the subnode "properties" section.
> The only difference there is removal of blank lines between common GPIO
> pinconf properties.
> 
> [...]

Applied, thanks!

[13/17] dt-bindings: pinctrl: qcom,sm8250: fix matching pin config
        https://git.kernel.org/krzk/linux-dt/c/a327e870af48c7f0bde57263c6a0ec65b0192217

Best regards,
Krzysztof Kozlowski Oct. 18, 2022, 3:49 p.m. UTC | #2
On Sun, 16 Oct 2022 13:22:10 -0400, Krzysztof Kozlowski wrote:
> SC7280 has 175 GPIOs (gpio0-174), so correct size of gpio-line-names and
> narrow the pattern for matching pin names.
> 
> 

Applied, thanks!

[15/17] dt-bindings: pinctrl: qcom,sc7280: correct number of GPIOs
        https://git.kernel.org/krzk/linux-dt/c/06311aa3ad1fd745d6248fc665f4c28880fedff1

Best regards,
Krzysztof Kozlowski Oct. 18, 2022, 3:49 p.m. UTC | #3
On Sun, 16 Oct 2022 13:22:12 -0400, Krzysztof Kozlowski wrote:
> The common Qualcomm TLMM pin controller schema for pin mux and config
> already brings requirement of function for gpio pins and the definition
> of drive-strength.
> 
> 

Applied, thanks!

[17/17] dt-bindings: pinctrl: qcom,sc7280: use common TLMM pin schema
        https://git.kernel.org/krzk/linux-dt/c/b4997c1cb7d4c3900aab6fe5dad521f59369f93d

Best regards,