mbox series

[net-next,0/2] net: phy: mxl-gpy: Add mode for 2 leds

Message ID 20220920151411.12523-1-marcus.carlberg@axis.com
Headers show
Series net: phy: mxl-gpy: Add mode for 2 leds | expand

Message

Marcus Carlberg Sept. 20, 2022, 3:14 p.m. UTC 
GPY211 phy default to using all four led pins.
Hardwares using only two leds where led0 is used as the high
network speed led and led1 the low network speed led will not
get the correct behaviour since 1Gbit and 2.5Gbit will not be
represented at all in the existing leds.


Marcus Carlberg (2):
  dt-bindings: net: Add mxl,gpy
  net: phy: mxl-gpy: Add mode for 2 leds

 .../devicetree/bindings/net/mxl,gpy.yaml      | 39 ++++++++++++++++
 .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
 MAINTAINERS                                   |  1 +
 drivers/net/phy/mxl-gpy.c                     | 45 +++++++++++++++++++
 4 files changed, 87 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/mxl,gpy.yaml

--
2.20.1

Comments

Michael Walle Sept. 22, 2022, 8:05 a.m. UTC | #1 
Hi,

> GPY211 phy default to using all four led pins.
> Hardwares using only two leds where led0 is used as the high
> network speed led and led1 the low network speed led will not
> get the correct behaviour since 1Gbit and 2.5Gbit will not be
> represented at all in the existing leds.

I might be wrong, but PHY LED bindings should be integrated with/using
the LED subsystem. Although I didn't see any development regarding this
for a long time.

That being said, it seems you are adding a new (DT) property which
just matches your particular hardware design, no?

-michael