From patchwork Mon Aug 29 13:15:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Nuno Sa X-Patchwork-Id: 600932 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D5C0ECAAD2 for ; Mon, 29 Aug 2022 15:13:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229983AbiH2PNV convert rfc822-to-8bit (ORCPT ); Mon, 29 Aug 2022 11:13:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229796AbiH2PNR (ORCPT ); Mon, 29 Aug 2022 11:13:17 -0400 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F28083043; Mon, 29 Aug 2022 08:13:15 -0700 (PDT) Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27T9r0ej025958; Mon, 29 Aug 2022 09:14:59 -0400 Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 3j7g673ccy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Aug 2022 09:14:59 -0400 Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 27TDEwRl019048 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 29 Aug 2022 09:14:58 -0400 Received: from ASHBCASHYB4.ad.analog.com (10.64.17.132) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Mon, 29 Aug 2022 09:14:57 -0400 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB4.ad.analog.com (10.64.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Mon, 29 Aug 2022 09:14:57 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.986.14 via Frontend Transport; Mon, 29 Aug 2022 09:14:57 -0400 Received: from nsa.ad.analog.com ([10.44.3.68]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 27TDEeiK026449; Mon, 29 Aug 2022 09:14:46 -0400 From: =?utf-8?q?Nuno_S=C3=A1?= To: , Bartosz Golaszewski , Dmitry Torokhov , , , Linus Walleij , , =?utf-8?q?Nuno_S=C3=A1?= CC: Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Michael Hennerich Subject: [PATCH v4 00/10] adp5588-keys refactor and fw properties support Date: Mon, 29 Aug 2022 15:15:43 +0200 Message-ID: <20220829131553.690063-1-nuno.sa@analog.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-ORIG-GUID: WujjXVidr1md9DrKswsKPmDWH8LJOC-x X-Proofpoint-GUID: WujjXVidr1md9DrKswsKPmDWH8LJOC-x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-29_07,2022-08-25_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 phishscore=0 mlxlogscore=999 malwarescore=0 impostorscore=0 mlxscore=0 adultscore=0 bulkscore=0 suspectscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208290061 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The main goal of this patchset is to remove platform data and replace it by firmware properties. Original discussion in [1]. While in here, some refactor was done to the driver. The most noticeable one is to replace the GPIs events handling by irqchip support so that this gpi keys can be "consumed" by the gpio-keys driver (also as suggested in [1]). With this, the gpio-adp5588 can be removed. This change comes first so that we can already remove some platform data variables making it easier to completly replace it by firmware properties further down in the series. As there's no users of the platform data, I just replace it in a single patch as there's no point in having support for both (even though it might be harder to review the patch as-is). Special note to the gpio-adp5588 driver removal. I'm aware of some changes to the driver in [2]. These changes are in the gpio tree and this patchset is naturally based on the input tree which means that patch 2 will not apply. So, I'm not really sure how to handle this. I guess in this case the conflict is easy to handle :) but just let me know on how to proceed in here if there's anything for me to do. [1]: https://lore.kernel.org/linux-input/20220504084617.36844-1-u.kleine-koenig@pengutronix.de/ [2]: https://lore.kernel.org/linux-gpio/20220628193906.36350-3-andriy.shevchenko@linux.intel.com/ v2 changes: [1/10] * Turn hwirq signed so we can compare < 0; * Replace WARN_ON with dev_warn(); * Do not set of_node on gpiochip; * Moved to use a const irqchip within the gpiochip; * Set default handler to 'handle_bad_irq()' and change it in irq_set_type; [4/10] * Dropped "-keys" from compatible and added vendor prefix; * Fix -Wformat complains; * Don't use abbrev in comments (fw -> Firmware). [5/10] * Be consistent on $refs; * Drop "-keys" from compatible. [7/10] * Include bits.h; * Use GENMASK(); * Use BIT() in KP_SEL(); * Reflect code changes in the commit message. [9/10] * One line for regulator_disable action. v3 changes: [1/10] * Use 'irqd_to_hwirq()' helper; * Use INVALID_HWIRQ to signal hwirq not found; * Just compare irq against 0 in 'irq_find_mapping()'; * Renamed irq_data *desc to *irqd to avoid confusion. [5/10] * Dropped the -keys suffix on the filename; * Compatible enum in alphabetical order; * Improved 'adi,unlock-keys' description; * 4 spaces indentation for dts example; * Renamed device node to a generic name and fixed the compatible property in the example. v4 changes: [1/10] * Use local 'INVALID_HWIRQ' macro; * Explicitly define a local variable to hold 'irqd_to_hwirq()' Nuno Sá (10): input: keyboard: adp5588-keys: support gpi key events as 'gpio keys' gpio: gpio-adp5588: drop the driver input: keyboard: adp5588-keys: bail out on returned error input: keyboard: adp5588-keys: add support for fw properties dt-bindings: input: adp5588: add bindings input: keyboard: adp5588-keys: do not check for irq presence input: keyboard: adp5588-keys: fix coding style warnings input: keyboard: adp5588-keys: add optional reset gpio input: keyboard: adp5588-keys: add regulator support input: keyboard: adp5588-keys: Use new PM macros .../bindings/input/adi,adp5588.yaml | 111 +++ MAINTAINERS | 2 +- drivers/gpio/Kconfig | 14 - drivers/gpio/Makefile | 1 - drivers/gpio/gpio-adp5588.c | 446 ----------- drivers/input/keyboard/Kconfig | 3 + drivers/input/keyboard/adp5588-keys.c | 724 ++++++++++++------ include/linux/platform_data/adp5588.h | 171 ----- 8 files changed, 594 insertions(+), 878 deletions(-) create mode 100644 Documentation/devicetree/bindings/input/adi,adp5588.yaml delete mode 100644 drivers/gpio/gpio-adp5588.c delete mode 100644 include/linux/platform_data/adp5588.h Reviewed-by: Linus Walleij