| Message ID | 20220817202538.21493-1-leoyang.li@nxp.com |
|---|---|
| Headers | show |
| Series | lx216x DTS updates | expand |
Hi, On Wed, Aug 17, 2022 at 1:26 PM Li Yang <leoyang.li@nxp.com> wrote: > > The original dts was created based on the non-production rev1 silicon > which was only used for evaluation. Update the PCIe nodes to align with > the different controller used in production rev2 silicon. How can I confirm what version of silicon I have on a system? My non-evaluation commercially purchased system (HoneyComb LX2K) has: # cat /sys/bus/soc/devices/soc0/revision 1.0 And I will be really grumpy if this system stops working. It's what I use to do all my maintainer work, even if that's been fairly dormant this year. It's overall setting off red flags to update an in-place devicetree to a "new revision" of silicon instead of adding a new DT for said revision. 2160A has been on the market for several years, so it just seems odd to all of the sudden retroactively make things non-backwards-compatible. -Olof -Olof
On Mon, Sep 12, 2022 at 12:05 AM Olof Johansson <olof@lixom.net> wrote: > > Hi, > > On Wed, Aug 17, 2022 at 1:26 PM Li Yang <leoyang.li@nxp.com> wrote: > > > > The original dts was created based on the non-production rev1 silicon > > which was only used for evaluation. Update the PCIe nodes to align with > > the different controller used in production rev2 silicon. > > How can I confirm what version of silicon I have on a system? > > My non-evaluation commercially purchased system (HoneyComb LX2K) has: > > # cat /sys/bus/soc/devices/soc0/revision > 1.0 > > And I will be really grumpy if this system stops working. It's what I > use to do all my maintainer work, even if that's been fairly dormant > this year. > > It's overall setting off red flags to update an in-place devicetree to > a "new revision" of silicon instead of adding a new DT for said > revision. 2160A has been on the market for several years, so it just > seems odd to all of the sudden retroactively make things > non-backwards-compatible. Confirmed that this patch renders my HoneyComb unbootable -- PCIe doesn't probe. Shawn, please revert, and be on the lookout for similar problematic approaches in the future. Thanks! -Olof
> -----Original Message----- > From: Olof Johansson <olof@lixom.net> > Sent: Monday, September 12, 2022 2:05 AM > To: Leo Li <leoyang.li@nxp.com> > Cc: shawnguo@kernel.org; devicetree@vger.kernel.org; > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; Z.Q. Hou <zhiqiang.hou@nxp.com> > Subject: Re: [PATCH v4 1/2] arm64: dts: lx2160a: update PCIe nodes to match > rev2 silicon > > Hi, > > On Wed, Aug 17, 2022 at 1:26 PM Li Yang <leoyang.li@nxp.com> wrote: > > > > The original dts was created based on the non-production rev1 silicon > > which was only used for evaluation. Update the PCIe nodes to align > > with the different controller used in production rev2 silicon. > > How can I confirm what version of silicon I have on a system? > > My non-evaluation commercially purchased system (HoneyComb LX2K) has: > > # cat /sys/bus/soc/devices/soc0/revision > 1.0 This is different from the information I got. If there is still active Rev1.0 system in use, I would agree that we probably need to create a new device tree for the rev2 silicon. Thanks for the information. > > And I will be really grumpy if this system stops working. It's what I use to do > all my maintainer work, even if that's been fairly dormant this year. > > It's overall setting off red flags to update an in-place devicetree to a "new > revision" of silicon instead of adding a new DT for said revision. 2160A has > been on the market for several years, so it just seems odd to all of the > sudden retroactively make things non-backwards-compatible. > > > > -Olof > > > > > -Olof
On Mon, Sep 12, 2022 at 11:54:06AM -0700, Olof Johansson wrote: > On Mon, Sep 12, 2022 at 12:05 AM Olof Johansson <olof@lixom.net> wrote: > > > > Hi, > > > > On Wed, Aug 17, 2022 at 1:26 PM Li Yang <leoyang.li@nxp.com> wrote: > > > > > > The original dts was created based on the non-production rev1 silicon > > > which was only used for evaluation. Update the PCIe nodes to align with > > > the different controller used in production rev2 silicon. > > > > How can I confirm what version of silicon I have on a system? > > > > My non-evaluation commercially purchased system (HoneyComb LX2K) has: > > > > # cat /sys/bus/soc/devices/soc0/revision > > 1.0 > > > > And I will be really grumpy if this system stops working. It's what I > > use to do all my maintainer work, even if that's been fairly dormant > > this year. > > > > It's overall setting off red flags to update an in-place devicetree to > > a "new revision" of silicon instead of adding a new DT for said > > revision. 2160A has been on the market for several years, so it just > > seems odd to all of the sudden retroactively make things > > non-backwards-compatible. > > Confirmed that this patch renders my HoneyComb unbootable -- PCIe doesn't probe. > > Shawn, please revert, and be on the lookout for similar problematic > approaches in the future. Thanks! I think you may also need to beware of the MC firmware revision - I seem to remember reading in the changelog notes for it that NXP dropped support in the MC firmware for the older silicon, though I may be misremembering. It's been a while since I really looked at the LX2160A from the point of view of maintaining or developing anything for it.
> -----Original Message----- > From: Olof Johansson <olof@lixom.net> > Sent: Monday, September 12, 2022 2:05 AM > To: Leo Li <leoyang.li@nxp.com> > Cc: shawnguo@kernel.org; devicetree@vger.kernel.org; > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; Z.Q. Hou <zhiqiang.hou@nxp.com> > Subject: Re: [PATCH v4 1/2] arm64: dts: lx2160a: update PCIe nodes to match > rev2 silicon > > Hi, > > On Wed, Aug 17, 2022 at 1:26 PM Li Yang <leoyang.li@nxp.com> wrote: > > > > The original dts was created based on the non-production rev1 silicon > > which was only used for evaluation. Update the PCIe nodes to align > > with the different controller used in production rev2 silicon. > > How can I confirm what version of silicon I have on a system? > > My non-evaluation commercially purchased system (HoneyComb LX2K) has: > > # cat /sys/bus/soc/devices/soc0/revision > 1.0 > > And I will be really grumpy if this system stops working. It's what I use to do > all my maintainer work, even if that's been fairly dormant this year. > > It's overall setting off red flags to update an in-place devicetree to a "new > revision" of silicon instead of adding a new DT for said revision. 2160A has > been on the market for several years, so it just seems odd to all of the > sudden retroactively make things non-backwards-compatible. Some more background information. The Rev1 silicon was only shipped for a very short period of time(for evaluation purpose only from what I heard) before the rev2 was out to fix some critical hardware issues. And we have recommended all customers to switch to Rev2 to avoid potential issues in Rev1. This non-backwards-compatible change is to avoid the potential confusion between rev1 and rev2 on assumption that there is no remaining users of Rev1 now, which seems to be not the case according to your response. Regards, Leo