From patchwork Wed Aug 10 06:00:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 596527 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 538E5C25B0D for ; Wed, 10 Aug 2022 06:01:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230506AbiHJGB0 (ORCPT ); Wed, 10 Aug 2022 02:01:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230477AbiHJGAx (ORCPT ); Wed, 10 Aug 2022 02:00:53 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72ED5E51 for ; Tue, 9 Aug 2022 23:00:48 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id u44-20020a25ab2f000000b0067c1b3e9fceso3738369ybi.17 for ; Tue, 09 Aug 2022 23:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:from:to:cc; bh=TCO2xyxVuPd3/tBUV+s0EeQJwLyZQsGvsrrIoFAUabA=; b=BvFe715tdJHTFzLiuUTS/Q7VYOCApMDwcI0d8adcuT6VY23Mzv0LjVB/oCe1EYUH6I GrUEBHGuCyX9om+3m+2zl2rmB8DHkIoDhCoJHkxwfbcimGGF2Au9Yt8rAFlE5vLE4zOT FBke0i6x4PfWRbfl2D3iR0cCU4z0WmA3iKlcfcXB0BYjlIhk2JqckwGp1G7FtAQR48/7 pqJ0XtbeVUishXdC4XToLF9FWmAVWf/m/3RJfH4tl7k3Jd+oE21AZHO7Wt0qAh9vtQ8/ piA6XmFBChiJiUmunvUDrKZvlyy2Mu3J3SrWw8IQ6KPqPhlxUX1s7KWZK+OvnRu3v5v3 Y72Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc; bh=TCO2xyxVuPd3/tBUV+s0EeQJwLyZQsGvsrrIoFAUabA=; b=CdXNFcKOkK7vnxNRQr+/K9m9e1FZ0e/vttlkk0VygMJK8DGmzOL2SGF3z3Tm/GQyZJ 5gud5Kqh5QITjKWjVj92+EIGFkFWweHefVAly2cCocBPqYJRLViE5Sh0X+7VvTQLbR4O Kg8+4kKUvsEgHD1kpKmpe3tBS42o849+f2W7gqlCeMxLq/HJQb04Ph+co03nHp87LTWE uucXVxZ3NRM6KQsOEXE+SsHPQKTHe33CjGB905aHcg5WIHwZhDI9O4XFrBEdO4dV/a7p gxhLtj4PhFhaVIwLivaCYREHy3nJimwj3JTLigfhDYpQIm5x9rZM+pJqCEOpQ55/EleN KEQQ== X-Gm-Message-State: ACgBeo3fa11Wq4L+bZ/LtiW7zlCiVw8d3tk9YtUPVYLKN8TnQ5kAc/4x MrC/DyuDEH0SXfZGKy9FzZsIGKahytjxEsE= X-Google-Smtp-Source: AA6agR4Luo9mfYOGUmow5n6t7VfAyPObtMuTRPi8OYX4fTwH65RIMuWKTPOsfnkREdcPNXAbTsM3U3vFPMT0E+A= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:f21:76ca:766f:e0ab]) (user=saravanak job=sendgmr) by 2002:a25:7613:0:b0:67a:700a:f9e1 with SMTP id r19-20020a257613000000b0067a700af9e1mr23778556ybc.53.1660111247299; Tue, 09 Aug 2022 23:00:47 -0700 (PDT) Date: Tue, 9 Aug 2022 23:00:29 -0700 Message-Id: <20220810060040.321697-1-saravanak@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.37.1.559.g78731f0fdb-goog Subject: [PATCH v1 0/9] fw_devlink improvements From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Linus Walleij , Bartosz Golaszewski , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Len Brown Cc: Saravana Kannan , Abel Vesa , Alexander Stein , Tony Lindgren , Sudeep Holla , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This patch series improves fw_devlink in the following ways: 1. It no longer cares about a fwnode having a "compatible" property. It figures this our more dynamically. The only expectation is that fwnode that are converted to devices actually get probed by a driver for the dependencies to be enforced correctly. 2. Finer grained dependency tracking. fw_devlink will now create device links from the consumer to the actual resource's device (if it has one, Eg: gpio_device) instead of the parent supplier device. This improves things like async suspend/resume ordering, potentially remove the need for frameworks to create device links, more parallelized async probing, and better sync_state() tracking. 3. Handle hardware/software quirks where a child firmware node gets populated as a device before its parent firmware node AND actually supplies a non-optional resource to the parent firmware node's device. 4. Way more robust at cycle handling (see patch for the insane cases). 5. Stops depending on OF_POPULATED to figure out some corner cases. 6. Simplifies the work that needs to be done by the firmware specific code. This took way too long to get done due to typo bugs I had in my rewrite or corner cases I had to find and handle. But it's fairly well tested at this point and I expect this to work properly. Abel & Doug, This should fix your cyclic dependency issues with your display. Can you give it a shot please? Alexander, This should fix your issue where the power domain device not having a compatible property. Can you give it a shot please? Tony, This should handle the odd case of the child being the supplier of the parent. Can you please give this a shot? I want to make sure the cycle detection code handles this properly and treats it like it's NOT a cycle. Geert, Can you test the renesas stuff I changed please? They should continue working like before. Any other sanity test on other hardware would be great too. Sudeep, I don't think there are any unfixed issues you had reported in my other patches that this series might fix, but it'll be nice if you could give this a sanity test. Guenter, I don't think this will fix the issue you reported in the amba patch, but it's worth a shot because it improves a bunch of corner case handling. So it might be better at handling whatever corner cases you might have in the qemu platforms. Thanks, Saravana Cc: Abel Vesa Cc: Alexander Stein Cc: Tony Lindgren Cc: Sudeep Holla Cc: Geert Uytterhoeven Cc: John Stultz Cc: Doug Anderson Cc: Guenter Roeck Saravana Kannan (9): driver core: fw_devlink: Don't purge child fwnode's consumer links driver core: fw_devlink: Improve check for fwnode with no device/driver soc: renesas: Move away from using OF_POPULATED for fw_devlink gpiolib: Clear the gpio_device's fwnode initialized flag before adding driver core: fw_devlink: Add DL_FLAG_CYCLE support to device links driver core: fw_devlink: Allow marking a fwnode link as being part of a cycle driver core: fw_devlink: Consolidate device link flag computation driver core: fw_devlink: Make cycle detection more robust of: property: Simplify of_link_to_phandle() drivers/base/core.c | 437 +++++++++++++++++++++----------- drivers/gpio/gpiolib.c | 6 + drivers/of/property.c | 84 +----- drivers/soc/renesas/rcar-sysc.c | 2 +- include/linux/device.h | 1 + include/linux/fwnode.h | 12 +- 6 files changed, 323 insertions(+), 219 deletions(-) Reviewed-by: Tony Lindgren Tested-by: Tony Lindgren Tested-by: Abel Vesa Tested-by: Sudeep Holla