mbox series

[V5,0/3] spi: mediatek: add single/quad mode support

Message ID 20220318025027.31281-1-leilk.liu@mediatek.com
Headers show
Series spi: mediatek: add single/quad mode support | expand

Message

Leilk Liu March 18, 2022, 2:50 a.m. UTC 
This series of patches are based on spi for-next, and provide 3 patches to support MT7986.

V5:
 1. remove 3 patches that already applied.
 2. use devm_clk_get_optional.
 3. remove of_mtk_spi_parse_dt()

v4:
 1. fix Rob comment in v3;
 2. use "mediatek,mt7986-spi-ipm","mediatek,spi-ipm"

v3:
 1. add Rob Acked-by in "dt-bindings: spi: Add compatible for MT7986 with single mode";
 2. add a fix patch "spi: mediatek: support tick_delay without enhance_timing";
 3. fix Angelogioacchino comments;
 4. use mt7986 instead of ipm in dt-binding.

v2:
 1. rebase this series on spi for-next.
 2. fix Rob and Krzysztof comments in v1.

Leilk Liu (3):
  spi: mediatek: add spi memory support for ipm design
  dt-bindings: spi: support hclk
  spi: mediatek: support hclk

 .../bindings/spi/mediatek,spi-mt65xx.yaml     |   4 +
 drivers/spi/spi-mt65xx.c                      | 387 +++++++++++++++++-
 2 files changed, 374 insertions(+), 17 deletions(-)

--
2.25.1

Comments

AngeloGioacchino Del Regno March 18, 2022, 11:29 a.m. UTC | #1 
Il 18/03/22 03:50, Leilk Liu ha scritto:
> this patch support hclk for AHB bus.
> 
> Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
>   .../devicetree/bindings/spi/mediatek,spi-mt65xx.yaml          | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> index 7247a177466b..ecb4a5002cc1 100644
> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> @@ -53,16 +53,20 @@ properties:
>       maxItems: 1
>   
>     clocks:
> +    minItems: 3
>       items:
>         - description: clock used for the parent clock
>         - description: clock used for the muxes clock
>         - description: clock used for the clock gate
> +      - description: clock used for the AHB bus, this clock is optional
>   
>     clock-names:
> +    minItems: 3
>       items:
>         - const: parent-clk
>         - const: sel-clk
>         - const: spi-clk
> +      - const: hclk
>   
>     mediatek,pad-select:
>       $ref: /schemas/types.yaml#/definitions/uint32-array