| Message ID | 20220315155919.23451-1-biju.das.jz@bp.renesas.com |
|---|---|
| Headers | show |
| Series | Enable Ethernet and SDHI on RZ/G2UL SMARC EVK | expand |
Hi Biju, On Tue, Mar 15, 2022 at 4:59 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > Add scif0 and audio clk pins to soc pinctrl dtsi and drop deleting Serial and audio: sounds (pun intended) like a strange combination? ;-) > the pinctrl-0 and pinctrl-names properties for scif0 node so that > we now actually make use of these properties for scif0. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Thanks for your patch! LGTM... > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/rzg2ul-smarc-pinfunction.dtsi > @@ -0,0 +1,24 @@ > +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +/* > + * Device Tree Source for the RZ/G2UL SMARC pincontrol parts > + * > + * Copyright (C) 2022 Renesas Electronics Corp. > + */ > + > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/pinctrl/rzg2l-pinctrl.h> > + > +&pinctrl { > + pinctrl-0 = <&sound_clk_pins>; > + pinctrl-names = "default"; > + > + scif0_pins: scif0 { > + pinmux = <RZG2L_PORT_PINMUX(6, 4, 6)>, /* TxD */ > + <RZG2L_PORT_PINMUX(6, 3, 6)>; /* RxD */ ... but I cannot review the pin muxing yet, due to lack of documentation (SOM schematics). > + }; > + > + sound_clk_pins: sound_clk { > + pins = "AUDIO_CLK1", "AUDIO_CLK2"; > + input-enable; > + }; > +}; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH 5/7] arm64: dts: renesas: rzg2ul-smarc: Enable microSD > on SMARC platform > > Hi Biju, > > On Tue, Mar 15, 2022 at 4:59 PM Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > Enable the microSD card slot connected to SDHI1 on the RZ/G2UL SMARC > > platform by removing the sdhi1 override which disabled it, and by > > adding the necessary pinmux required for SDHI1. > > > > This patch also overrides vqmmc-supply for SDHI1. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Thanks for your patch! > > > --- /dev/null > > +++ b/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi > > @@ -0,0 +1,27 @@ > > +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +/* > > + * Device Tree Source for the RZ/G2UL Type-1 SMARC EVK parts > > + * > > + * Copyright (C) 2022 Renesas Electronics Corp. > > + */ > > + > > +#include "rzg2ul-smarc-som.dtsi" > > +#include "rzg2ul-smarc-pinfunction.dtsi" > > +#include "rz-smarc-common.dtsi" > > + > > +/ { > > + vccq_sdhi1: regulator-vccq-sdhi1 { > > + compatible = "regulator-gpio"; > > + regulator-name = "SDHI1 VccQ"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <3300000>; > > + gpios = <&pinctrl RZG2L_GPIO(6, 1) GPIO_ACTIVE_HIGH>; > > + gpios-states = <1>; > > + states = <3300000 1>, <1800000 0>; > > + }; > > This regulator is already defined in rz-smarc-common.dtsi, which is > included above? That definition does use a different gpios property, > though. Yes, Only for this RZ/G2UL and RZ/Five SMARC EVK it is different compared to RZ/{G2L,V2L,G2LC} SMARC EVK. Shall I move regulator from rz-smarc-common.dtsi to RZ/{G2L,V2L} and RZ/G2LC SMARC dtsi? Regards, Biju > > > +}; > > + > > +&sdhi1 { > > + vqmmc-supply = <&vccq_sdhi1>; > > +}; > > +
Hi Biju, On Thu, Mar 31, 2022 at 3:36 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > Subject: Re: [PATCH 5/7] arm64: dts: renesas: rzg2ul-smarc: Enable microSD > > on SMARC platform > > On Tue, Mar 15, 2022 at 4:59 PM Biju Das <biju.das.jz@bp.renesas.com> > > wrote: > > > Enable the microSD card slot connected to SDHI1 on the RZ/G2UL SMARC > > > platform by removing the sdhi1 override which disabled it, and by > > > adding the necessary pinmux required for SDHI1. > > > > > > This patch also overrides vqmmc-supply for SDHI1. > > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Thanks for your patch! > > > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi > > > @@ -0,0 +1,27 @@ > > > +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +/* > > > + * Device Tree Source for the RZ/G2UL Type-1 SMARC EVK parts > > > + * > > > + * Copyright (C) 2022 Renesas Electronics Corp. > > > + */ > > > + > > > +#include "rzg2ul-smarc-som.dtsi" > > > +#include "rzg2ul-smarc-pinfunction.dtsi" > > > +#include "rz-smarc-common.dtsi" > > > + > > > +/ { > > > + vccq_sdhi1: regulator-vccq-sdhi1 { > > > + compatible = "regulator-gpio"; > > > + regulator-name = "SDHI1 VccQ"; > > > + regulator-min-microvolt = <1800000>; > > > + regulator-max-microvolt = <3300000>; > > > + gpios = <&pinctrl RZG2L_GPIO(6, 1) GPIO_ACTIVE_HIGH>; > > > + gpios-states = <1>; > > > + states = <3300000 1>, <1800000 0>; > > > + }; > > > > This regulator is already defined in rz-smarc-common.dtsi, which is > > included above? That definition does use a different gpios property, > > though. > > Yes, Only for this RZ/G2UL and RZ/Five SMARC EVK it is different compared to > RZ/{G2L,V2L,G2LC} SMARC EVK. > > Shall I move regulator from rz-smarc-common.dtsi to RZ/{G2L,V2L} and RZ/G2LC SMARC dtsi? Either move the regulator to the individual SMARC dtsi files, or keep it in rz-smarc-common.dtsi without gpios property, and add the gpios property in the individual SMARC dtsi files. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
This patch series aims to enable Ethernet and SDHI on RZ/G2UL SMARC EVK. This patches also adds pinctrl support to SoC dtsi and enables scif0 and audio clk pins. This patch series depend upon [1] [1] https://lore.kernel.org/linux-renesas-soc/20220315142644.17660-1-biju.das.jz@bp.renesas.com/T/#t Biju Das (7): arm64: dts: renesas: r9a07g043: Fillup the pinctrl stub node arm64: dts: renesas: rzg2ul-smarc: Add scif0 and audio clk pins arm64: dts: renesas: r9a07g043: Add SDHI nodes arm64: dts: renesas: r9a07g043: Add GbEthernet nodes arm64: dts: renesas: rzg2ul-smarc: Enable microSD on SMARC platform arm64: dts: renesas: rzg2ul-smarc-som: Enable eMMC on SMARC platform arm64: dts: renesas: rzg2ul-smarc-som: Enable Ethernet on SMARC platform arch/arm64/boot/dts/renesas/r9a07g043.dtsi | 74 +++++- .../boot/dts/renesas/r9a07g043u11-smarc.dts | 16 +- .../dts/renesas/rzg2ul-smarc-pinfunction.dtsi | 63 ++++++ .../boot/dts/renesas/rzg2ul-smarc-som.dtsi | 210 +++++++++++++++++- arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi | 37 +++ 5 files changed, 381 insertions(+), 19 deletions(-) create mode 100644 arch/arm64/boot/dts/renesas/rzg2ul-smarc-pinfunction.dtsi create mode 100644 arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi