mbox series

[0/2] Arm based platforms dtc fixes for pl022

Message ID 20220307205357.66322-1-singh.kuldeep87k@gmail.com
Headers show
Series Arm based platforms dtc fixes for pl022 | expand

Message

Kuldeep Singh March 7, 2022, 8:53 p.m. UTC 
This patchset is an attempt to fix device trees and resolve bindings
warning for pl022. This requires updation in clock name to keep alignment
with other platforms and spi node properties for integrator platform.

This patch is based on
git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git,
master
Since, these patches are based on same tree, so i added them in series
for seamless application.

Kuldeep Singh (2):
  arm: dts: realview/versatile/ste: Update spi clock name
  arm: dts: integrator: Update spi node properties

 arch/arm/boot/dts/arm-realview-eb.dtsi    |  2 +-
 arch/arm/boot/dts/arm-realview-pb1176.dts |  2 +-
 arch/arm/boot/dts/arm-realview-pb11mp.dts |  2 +-
 arch/arm/boot/dts/arm-realview-pbx.dtsi   |  2 +-
 arch/arm/boot/dts/integratorap-im-pd1.dts |  4 ++--
 arch/arm/boot/dts/ste-dbx5x0.dtsi         | 12 ++++++------
 arch/arm/boot/dts/versatile-ab.dts        |  2 +-
 7 files changed, 13 insertions(+), 13 deletions(-)

Comments

Kuldeep Singh March 8, 2022, 5:31 a.m. UTC | #1 
On Mon, Mar 07, 2022 at 10:57:40PM +0100, Krzysztof Kozlowski wrote:
> On 07/03/2022 21:53, Kuldeep Singh wrote:
> > SPI clock name for pl022 is "sspclk" and not "spiclk".
> > Fix below dtc warning:
> > clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk']
> > 
> > Also, update node name to spi instead of ssp to enable spi bindings
> > check.
> > 
> > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> > ---
> >  arch/arm/boot/dts/integratorap-im-pd1.dts | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/integratorap-im-pd1.dts b/arch/arm/boot/dts/integratorap-im-pd1.dts
> > index d47bfb66d069..ebe938556645 100644
> > --- a/arch/arm/boot/dts/integratorap-im-pd1.dts
> > +++ b/arch/arm/boot/dts/integratorap-im-pd1.dts
> > @@ -178,12 +178,12 @@ uart@200000 {
> >  		clock-names = "uartclk", "apb_pclk";
> >  	};
> >  
> > -	ssp@300000 {
> > +	ssp0: spi@300000 {
> 
> Is the alias used anywhere? Why adding it?

I added an alias so as not to lose originality. At other places, ssp is
used more specifically for spi controller node and since here I need to
enable bindings check, so I mentioned both.

There are other platforms too which are using the same notation and
personally, I couldn't find any harm in this.

Regards
Kuldeep