From patchwork Wed Jan 19 20:43:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Matthias Kaehlcke X-Patchwork-Id: 533325 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54666C433F5 for ; Wed, 19 Jan 2022 20:43:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245030AbiASUny (ORCPT ); Wed, 19 Jan 2022 15:43:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230288AbiASUnx (ORCPT ); Wed, 19 Jan 2022 15:43:53 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C82F7C06173E for ; Wed, 19 Jan 2022 12:43:53 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id d7so3292972plr.12 for ; Wed, 19 Jan 2022 12:43:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=V5BiuoCL3BS3pY0KUVzisKn5l9i+TTVG+bwUeabMhEk=; b=OEC8GOFWmRCAUxMjicI179DKwx/otRIOUBh46/TZ2A9xSSIgYqB+478N/yd0nhPR3W mYtwF2Sxu0/7XjCAZ/4uJbHdI20gy2o3yysOiVdr2kKi24Brvp8Y/9+zfWgM7VFgpCwz roZ+4JWM1oD1YKA5guUn28hTf+tvJoGcWlA2s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=V5BiuoCL3BS3pY0KUVzisKn5l9i+TTVG+bwUeabMhEk=; b=aGpMQhfXQQgtdNsIlhHh1ogG2wbNqP8OxC0DEtt6GHoshSf4gODBpQ/+YIQyL79swd DzhgJfLfvY0JNqc65XyHvLTdcsroQ1T/sWz5YQHXtbitr9zHFDzI2pbElxNNpP7UouIb EGimsimCDp4Bwj+FNcRPNhWCPg+3KHPBODqvM6FkoqNKKdGjqXXfvp2i5fCnKYOY9+6Z qhs9VJMSqBwpXEWsqB+wxBx6tBUUOMkK5b5pYhcdHXyWCHiIY5OyUfViPNzA6ZyabiMW jrUp/qgXgtqywOBCiRWV3ddQNtt+x+hB/Zbt+5oUG6SbwtcQAn1JrDyayq3/RUKQVd5g W64w== X-Gm-Message-State: AOAM5326rc2t0Be8XmblJBo2FLlbx1WFViiydI5JBJ92TBzsWeZCpmNn uIdHg+LrRXuvwVye6cImcEvj7A== X-Google-Smtp-Source: ABdhPJxjDw9F9EjF82NyBugY9LUS3IT0bEW9DZGFW+WJoX48x2Rllr6J+1usnpzep/toZlKfpHe46w== X-Received: by 2002:a17:90b:4b8c:: with SMTP id lr12mr6405892pjb.32.1642625033208; Wed, 19 Jan 2022 12:43:53 -0800 (PST) Received: from localhost ([2620:15c:202:201:618e:efc:c014:d89c]) by smtp.gmail.com with UTF8SMTPSA id ip2sm7033428pjb.11.2022.01.19.12.43.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jan 2022 12:43:52 -0800 (PST) From: Matthias Kaehlcke To: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , Stephen Boyd , Peter Chen , linux-kernel@vger.kernel.org, Douglas Anderson , Roger Quadros , Michal Simek , linux-usb@vger.kernel.org, Bastien Nocera , Ravi Chandra Sadineni , Matthias Kaehlcke , Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , Li Jun , Peter Chen , "Rafael J. Wysocki" , Sasha Levin , Sergey Shtylyov , Thinh Nguyen , linux-arm-msm@vger.kernel.org Subject: [PATCH v20 0/5] usb: misc: Add onboard_usb_hub driver Date: Wed, 19 Jan 2022 12:43:40 -0800 Message-Id: <20220119204345.3769662-1-mka@chromium.org> X-Mailer: git-send-email 2.34.1.703.g22d0c6ccf7-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This series adds: - the onboard_usb_hub_driver - glue in the generic HCD code to create and destroy the onboard_usb_hub platform devices if needed - device tree changes that add RTS5411 entries for the QCA SC7180 based boards trogdor and lazor - a couple of stubs for platform device functions to avoid unresolved symbols with certain kernel configs The main issue the driver addresses is that a USB hub needs to be powered before it can be discovered. For discrete onboard hubs (an example for such a hub is the Realtek RTS5411) this is often solved by supplying the hub with an 'always-on' regulator, which is kind of a hack. Some onboard hubs may require further initialization steps, like changing the state of a GPIO or enabling a clock, which requires even more hacks. This driver creates a platform device representing the hub which performs the necessary initialization. Currently it only supports switching on a single regulator, support for multiple regulators or other actions can be added as needed. Different initialization sequences can be supported based on the compatible string. Besides performing the initialization the driver can be configured to power the hub off during system suspend. This can help to extend battery life on battery powered devices which have no requirements to keep the hub powered during suspend. The driver can also be configured to leave the hub powered when a wakeup capable USB device is connected when suspending, and power it off otherwise. Changes in v20: - addressed review comments from Stephen - changed DT node names for hubs Changes in v19: - added VID:PID pairs and compatible strings for RTS5414 hub - updated comments with RTS5411 USB versions to reflect those reported/supported by the hub - rebased series on v5.16 Changes in v18: - introduced hidden Kconfig option to align module vs. builtin choice with CONFIG_USB (thanks Doug!) - added patch 'driver core: Export device_is_bound()' - also adjust device tree of pompom rev1 - dropped the following patches, which aren't needed anymore by this series (though they might still be useful on their own): - usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on' - arm64: defconfig: Explicitly enable USB_XHCI_PLATFORM - ARM: configs: Explicitly enable USB_XHCI_PLATFORM where needed Changes in v17: - rebased on top of v5.16-rc1 - moved creation of onboard_hub platform devices from xhci_platform to the generic HCD code - addressed review comments for the onboard_hub driver - moved Kconfig/defconfig changes to the end of the series. The onboard_hub driver doesn't depend on XHCI_PLATFORM anymore, hence these changes aren't really required for the driver, but they still seem to be a worthwhile improvement Changes in v16: - added patch 'ARM: configs: Explicitly enable USB_XHCI_PLATFORM where needed' to keep arm32 defconfigs effectively unchanged Changes in v15: - adjusted dependencies of USB_DWC3_CORE to make sure it can only be enabled when at least one of USB_DWC3_HOST, USB_DWC3_GADGET or USB_DWC3_DUAL_ROLE is selectable Changes in v14: - rebased on top of v5.14-rc1 - dropped DT binding patch which landed in v5.13 Changes in v13: - added patch "usb: Specify dependency on USB_XHCI_PLATFORM with 'depends on'" to the series to avoid Kconfig conflicts - added patch "arm64: defconfig: Explicitly enable USB_XHCI_PLATFORM" to the series to keep effective defconfig unchanged Changes in v12: - onboard_hub driver: use IS_ENABLED(CONFIG_USB_ONBOARD_HUB_MODULE) in onboard_hub.h to also check for the driver built as module - onboard_hub_driver: include onboard_hub.h again to make sure there are prototype declarations for the public functions Changes in v11: - support multiple onboard hubs connected to the same parent - don't include ‘onboard_hub.h’ from the onboard hub driver Changes in v10: - always use of_is_onboard_usb_hub() stub unless ONBOARD_USB_HUB=y/m - keep 'regulator-boot-on' property for pp3300_hub Changes in v9: - added dependency on ONBOARD_USB_HUB (or !ONBOARD_USB_HUB) to USB_PLATFORM_XHCI Changes in v7: - updated DT binding - series rebased on qcom/arm64-for-5.13 Changes in v6: - updated summary Changes in v5: - cover letter added Matthias Kaehlcke (5): of/platform: Add stubs for of_platform_device_create/destroy() driver core: Export device_is_bound() usb: misc: Add onboard_usb_hub driver usb: core: hcd: Create platform devices for onboard hubs in probe() arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub .../sysfs-bus-platform-onboard-usb-hub | 8 + MAINTAINERS | 7 + .../boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 19 +- .../boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 12 +- .../dts/qcom/sc7180-trogdor-pompom-r1.dts | 11 +- .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 19 +- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 20 +- drivers/base/dd.c | 1 + drivers/usb/core/hcd.c | 6 + drivers/usb/misc/Kconfig | 23 + drivers/usb/misc/Makefile | 1 + drivers/usb/misc/onboard_usb_hub.c | 511 ++++++++++++++++++ include/linux/of_platform.h | 22 +- include/linux/usb/hcd.h | 1 + include/linux/usb/onboard_hub.h | 18 + 15 files changed, 638 insertions(+), 41 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-bus-platform-onboard-usb-hub create mode 100644 drivers/usb/misc/onboard_usb_hub.c create mode 100644 include/linux/usb/onboard_hub.h