From patchwork Sat Dec 25 07:23:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 528065 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C41E6C433FE for ; Sat, 25 Dec 2021 07:26:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230335AbhLYH0f (ORCPT ); Sat, 25 Dec 2021 02:26:35 -0500 Received: from szxga01-in.huawei.com ([45.249.212.187]:15973 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230298AbhLYH0f (ORCPT ); Sat, 25 Dec 2021 02:26:35 -0500 Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4JLb4m1C5tzZddv; Sat, 25 Dec 2021 15:23:20 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sat, 25 Dec 2021 15:26:32 +0800 Received: from thunder-town.china.huawei.com (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sat, 25 Dec 2021 15:26:31 +0800 From: Zhen Lei To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , , "H . Peter Anvin" , , Dave Young , Baoquan He , Vivek Goyal , Eric Biederman , , Catalin Marinas , "Will Deacon" , , Rob Herring , Frank Rowand , , Jonathan Corbet , CC: Zhen Lei , Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou , "John Donnelly" Subject: [PATCH 0/4] kdump: add parse_crashkernel_high_low() to replace parse_crashkernel_{high|low}() Date: Sat, 25 Dec 2021 15:23:23 +0800 Message-ID: <20211225072327.1807-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The bootup command line option crashkernel=Y,low is valid only when crashkernel=X,high is specified. Putting their parsing into a separate function makes the code logic clearer and easier to understand the strong dependencies between them. So add parse_crashkernel_high_low() and use it to repalce parse_crashkernel_{high|low}(). Then make the latter static, and reduce two confusing parameters 'system_ram' and 'crash_base' of them. All four patches in this series do the cleanups, no functional change. This patchset is also a preparation for supporting reserve crashkernel above 4G on arm64, and share code with x86. The main proposal was made by Borislav Petkov. > As I've already alluded to in another mail, ontop of this there should > be a patch or multiple patches which clean this up more and perhaps even > split it into separate functions doing stuff in this order: > > 1. Parse all crashkernel= cmdline options > 2. Do all crash_base, crash_size etc checks > 3. Do the memory reservations > > And all that supplied with comments explaining why stuff is being done. Zhen Lei (4): kdump: add helper parse_crashkernel_high_low() x86/setup: Use parse_crashkernel_high_low() to simplify code kdump: make parse_crashkernel_{high|low}() static kdump: reduce unnecessary parameters of parse_crashkernel_{high|low}() arch/x86/kernel/setup.c | 21 +++++++-------- include/linux/crash_core.h | 7 +++-- kernel/crash_core.c | 54 +++++++++++++++++++++++++++++++------- 3 files changed, 56 insertions(+), 26 deletions(-)