mbox series

[v2,0/2] rtc: Implement support for EPSON RX-8035

Message ID 20210709044518.28769-1-matt@traverse.com.au
Headers show
Series rtc: Implement support for EPSON RX-8035 | expand

Message

Mathew McBride July 9, 2021, 4:45 a.m. UTC 
The EPSON RX-8035[SA] is a I2C real time clock module with
built-in oscillator[1]. It is a very close relative of the EPSON
RX-8025 that is supported by the rtc-rx8025 driver.

The main difference is that the RX-8035 has inverted the
'oscillator stop' bit in the control register. The operation
of the devices is otherwise identical for the features currently
supported.

Curiously, the RX-8025 is also supported by the ds1307 driver
as the time register set is compatible. The control registers,
however, are not.

I have decided to implement the RX-8035 in rtc-rx8025 due the simplicity
of that driver.

As best as I can determine, the rtc-rx8025 driver was in the tree
some months[1] before rx8025 support was added to ds1307[2].

[1] - https://www5.epsondevice.com/en/products/rtc/rx8035sa.html
[2] - commit 3c2b9075cbdb541dbe486bde45925c9610de6f35
[3] - commit a216685818a54b4f15235068b53908f954850251

Changes in v2:
Coding style fixes as per suggestions
Use 'model' instead of 'type' in drvdata
Call rx8025_is_osc_stopped in a consistent manner

Mathew McBride (2):
  rtc: rx8025: implement RX-8035 support
  dt-bindings: rtc: add Epson RX-8025 and RX-8035

 .../devicetree/bindings/rtc/trivial-rtc.yaml  |  3 +
 drivers/rtc/rtc-rx8025.c                      | 59 +++++++++++++++++--
 2 files changed, 57 insertions(+), 5 deletions(-)

-- 
2.30.1

Comments

Alexandre Belloni Aug. 17, 2021, 10:08 p.m. UTC | #1 
On Fri, 9 Jul 2021 04:45:16 +0000, Mathew McBride wrote:
> The EPSON RX-8035[SA] is a I2C real time clock module with

> built-in oscillator[1]. It is a very close relative of the EPSON

> RX-8025 that is supported by the rtc-rx8025 driver.

> 

> The main difference is that the RX-8035 has inverted the

> 'oscillator stop' bit in the control register. The operation

> of the devices is otherwise identical for the features currently

> supported.

> 

> [...]


Applied, thanks!

[1/2] rtc: rx8025: implement RX-8035 support
      commit: f120e2e33ac8ba1adac4f59eaf1ae1705305158f

I did remove the switch and dev_info in an attempt to cut down on unecessary
strings.

[2/2] dt-bindings: rtc: add Epson RX-8025 and RX-8035
      commit: 8158da6a33f2656c2a98c30eb9185a44e215a6b6

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@bootlin.com>