From patchwork Wed Jun 23 18:41:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Matthias Kaehlcke X-Patchwork-Id: 466000 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D114C49EA4 for ; Wed, 23 Jun 2021 18:41:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1294E601FC for ; Wed, 23 Jun 2021 18:41:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229759AbhFWSnt (ORCPT ); Wed, 23 Jun 2021 14:43:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbhFWSns (ORCPT ); Wed, 23 Jun 2021 14:43:48 -0400 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0546FC06175F for ; Wed, 23 Jun 2021 11:41:30 -0700 (PDT) Received: by mail-pg1-x52e.google.com with SMTP id h4so2522831pgp.5 for ; Wed, 23 Jun 2021 11:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CmSxjVifvEvCqk0+9pO7z5s7Ge6oi3hKkOZK5hFSWaY=; b=LluFmH6faSDsy5zNPOC5XgyCUGC49cppIjUOhBK4h233TCJkZWz8/u5xK1rXIwOYCo yVLlUiH5GK0vEd/wmbZNVQMgsmh2HhDr8g9afDiLFHfbW9tVgc12KVqsowWpu7GKLodA bWvCkzmbQyGs8TGr/1M28YzaLi4LdwQFGH24A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CmSxjVifvEvCqk0+9pO7z5s7Ge6oi3hKkOZK5hFSWaY=; b=IpQoxRMHlC86g/SATtXsqq3RqaTsgCb5P+VMAlVZrmiwmV6d1IP9xHS3n8ZpYp4+Q6 kP43gH5KjoUwQ0HaJKyWtpk08AdGEWQ3YV3VZqPov26GCj3JCxWt54LVcLgMKO5FPr/A zfgeHiZalheXObSrRMZQJqmIy6IosFnEL7GNxKGrdWnS5mdPiX+RlA7sV16IOTHMUsl9 pbJszugaN7NyqxGhLrrEkoRbJWy2DzFrmyQBkRA4K3vPrawvtHRG4zQmTESWyWlG96zV SPNhohiQ7JCaFDS72wDx2E/kYlL1oy0CDiObUImUDu1lpOp2VK9XyWhGex7TqAgIquY2 PPAg== X-Gm-Message-State: AOAM530/1TrFnx9A3JS+dd15QyXw4dyHqLK/KmS/EGFvDwcGc/qiYL9y sZdbWf8mwvJVoFOD/WN/KTnA5w== X-Google-Smtp-Source: ABdhPJwoZ9MJ9mzv9yFsoY9HMcrNs70l8450M7S+Sm3N1iyk6cCgVPMpRYCShxwgBwdfEoJcwVikWQ== X-Received: by 2002:a63:31cc:: with SMTP id x195mr792039pgx.99.1624473689165; Wed, 23 Jun 2021 11:41:29 -0700 (PDT) Received: from localhost ([2620:15c:202:201:d440:232:5e25:41f4]) by smtp.gmail.com with UTF8SMTPSA id v13sm978597pja.44.2021.06.23.11.41.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jun 2021 11:41:28 -0700 (PDT) From: Matthias Kaehlcke To: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Simek , Krzysztof Kozlowski , Peter Chen , Bastien Nocera , Stephen Boyd , Douglas Anderson , Ravi Chandra Sadineni , Matthias Kaehlcke , Al Cooper , "Alexander A. Klimov" , Andy Gross , Anson Huang , Aswath Govindraju , Bjorn Andersson , Catalin Marinas , Dmitry Baryshkov , Dmitry Osipenko , Enric Balletbo i Serra , Fabio Estevam , =?utf-8?q?Guido_G=C3=BCnther?= , Lad Prabhakar , Michael Walle , Nishanth Menon , Pawel Laszczak , Roger Quadros , Shawn Guo , Vinod Koul , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v13 0/7] usb: misc: Add onboard_usb_hub driver Date: Wed, 23 Jun 2021 11:41:16 -0700 Message-Id: <20210623184124.3504047-1-mka@chromium.org> X-Mailer: git-send-email 2.32.0.288.g62a8d224e6-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This series adds: - the onboard_usb_hub_driver - glue in the xhci-plat driver to create and destroy the onboard_usb_hub platform devices if needed - a device tree binding for the Realtek RTS5411 USB hub controller - device tree changes that add RTS5411 entries for the QCA SC7180 based boards trogdor and lazor - a couple of stubs for platform device functions to avoid unresolved symbols with certain kernel configs The main issue the driver addresses is that a USB hub needs to be powered before it can be discovered. For discrete onboard hubs (an example for such a hub is the Realtek RTS5411) this is often solved by supplying the hub with an 'always-on' regulator, which is kind of a hack. Some onboard hubs may require further initialization steps, like changing the state of a GPIO or enabling a clock, which requires even more hacks. This driver creates a platform device representing the hub which performs the necessary initialization. Currently it only supports switching on a single regulator, support for multiple regulators or other actions can be added as needed. Different initialization sequences can be supported based on the compatible string. Besides performing the initialization the driver can be configured to power the hub off during system suspend. This can help to extend battery life on battery powered devices which have no requirements to keep the hub powered during suspend. The driver can also be configured to leave the hub powered when a wakeup capable USB device is connected when suspending, and power it off otherwise. Changes in v13: - added patch "usb: Specify dependency on USB_XHCI_PLATFORM with 'depends on'" to the series to avoid Kconfig conflicts - added patch "arm64: defconfig: Explicitly enable USB_XHCI_PLATFORM" to the series to keep effective defconfig unchanged Changes in v12: - onboard_hub driver: use IS_ENABLED(CONFIG_USB_ONBOARD_HUB_MODULE) in onboard_hub.h to also check for the driver built as module - onboard_hub_driver: include onboard_hub.h again to make sure there are prototype declarations for the public functions Changes in v11: - support multiple onboard hubs connected to the same parent - don't include ‘onboard_hub.h’ from the onboard hub driver Changes in v10: - always use of_is_onboard_usb_hub() stub unless ONBOARD_USB_HUB=y/m - keep 'regulator-boot-on' property for pp3300_hub Changes in v9: - added dependency on ONBOARD_USB_HUB (or !!ONBOARD_USB_HUB) to USB_PLATFORM_XHCI Changes in v7: - updated DT binding - series rebased on qcom/arm64-for-5.13 Changes in v6: - updated summary Changes in v5: - cover letter added Matthias Kaehlcke (7): dt-bindings: usb: Add binding for Realtek RTS5411 hub controller usb: misc: Add onboard_usb_hub driver of/platform: Add stubs for of_platform_device_create/destroy() arm64: defconfig: Explicitly enable USB_XHCI_PLATFORM usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on' usb: host: xhci-plat: Create platform device for onboard hubs in probe() arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub .../sysfs-bus-platform-onboard-usb-hub | 8 + .../bindings/usb/realtek,rts5411.yaml | 62 +++ MAINTAINERS | 7 + .../boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 19 +- .../boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 12 +- .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 19 +- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 19 +- arch/arm64/configs/defconfig | 1 + drivers/usb/cdns3/Kconfig | 2 +- drivers/usb/dwc3/Kconfig | 3 +- drivers/usb/host/Kconfig | 5 +- drivers/usb/host/xhci-plat.c | 6 + drivers/usb/host/xhci.h | 2 + drivers/usb/misc/Kconfig | 17 + drivers/usb/misc/Makefile | 1 + drivers/usb/misc/onboard_usb_hub.c | 497 ++++++++++++++++++ include/linux/of_platform.h | 22 +- include/linux/usb/onboard_hub.h | 18 + 18 files changed, 682 insertions(+), 38 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-bus-platform-onboard-usb-hub create mode 100644 Documentation/devicetree/bindings/usb/realtek,rts5411.yaml create mode 100644 drivers/usb/misc/onboard_usb_hub.c create mode 100644 include/linux/usb/onboard_hub.h