From patchwork Sat Jun 12 13:31:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan \(OSS\)" X-Patchwork-Id: 459155 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp1794731jae; Sat, 12 Jun 2021 05:58:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFgvkmjK7cGbrSJwa8kDrSd5rU26usbhkIkuZdArVtnGd38sltodKpN4ObjhtQljx3rNkx X-Received: by 2002:a17:906:b88e:: with SMTP id hb14mr7662834ejb.396.1623502717547; Sat, 12 Jun 2021 05:58:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1623502717; cv=pass; d=google.com; s=arc-20160816; b=u3ZMtNHL6P4BE4vkB1W2XYW19uoYEQkRgiwxIUIYenSpwWJpzrKn15uJrKQTW29SiQ BgjfDjtMGse3o8palYe3NnuLzDWDAzE7/C+HNDoyO1KsDWOZ5G+6zNqHMUiVzxff1UzM p1Y5dwK78lRJvhhIuGdaYkw/Lh9uwviXJs0YAZoqSuaWgK/fFAm9bHlgVMsKZlmTSPiE L5URxdI1Udy2a7D/RzkOpK1Rf7vuYQfGX0TB8v/2/SfuTP6KrupQegTgz0FRzKDduoEK 7N19q/bgv+dCfSFmM/tCwQ24Rx/zkmygsOCcQwFOrN9PPOHtixN7bu/FAMC2S7MdwuQV ZLzw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :message-id:date:subject:cc:to:from:dkim-signature; bh=gfsT/VsvG1Jkgn3IelnwYsr0ibtYM3V4g+QCleJ25ts=; b=pWam4U7ypIaS/NHN0DXZwdQZ9zavvTe8zHbpvVpavHpnfaTy2ZeLiFT4PEhqk0aTBj jr8HAkhvEkq0m7GR9+tKMOuA0vw0SCFwJ0B2J1R+ylCJyGQNcfF/mvArVvV/obUxq694 eNEyuPAXha3Y7TsSPzKNEcfWAz0dZ+X+3U840K91JD+einyu/ndkLGdUxknIvII1q9/w Pael31M2iNslbH/DvkKCf2roXPytlhwUTfxhas+JqLkEgcQk6cKb2LaySfKzpRm1WBrQ xcSy+yB8m4q5FfFsWs3sGP2bURcPmLMpX/k9FcSabue6BBBLvcnknlUC9aAmq28gTN8O fFUg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@NXP1.onmicrosoft.com header.s=selector2-NXP1-onmicrosoft-com header.b=YNv39Hz2; arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com); spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t14si7000572edq.26.2021.06.12.05.58.36; Sat, 12 Jun 2021 05:58:37 -0700 (PDT) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@NXP1.onmicrosoft.com header.s=selector2-NXP1-onmicrosoft-com header.b=YNv39Hz2; arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com); spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230470AbhFLNAf (ORCPT + 7 others); Sat, 12 Jun 2021 09:00:35 -0400 Received: from mail-eopbgr70080.outbound.protection.outlook.com ([40.107.7.80]:7974 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230191AbhFLNAe (ORCPT ); Sat, 12 Jun 2021 09:00:34 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IspSFMlKI5vX1lIXVoZ2mEVidyzSoNOa4YsWVJaej3hov2X4j2sGhS426OKPsaKBfpOJxha9aWBpHUhXoKEW5mbd/kpYvIZX86gjUV9+8GczAJIQkqml56grUf1ZM3NwbiOnryNB5P+FBc8Mf5SOupGZiLS4Qxrwq8rez2MU7sxKKH0OCF1lxL2dg/c/GwG9aZ3tuunTrCTiszRFIJXpev2XXBcetfGF4NBPnrO8WRMJ4gn3CIjiVfETROzka0dMqz9wK5xwu1sja89B8GG0INKN7OcwvQSyI4SCEIee9U3LVHJpPU+iL4W5p8G/zMEHX8cgWWUTWinMVHmMkmnD0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gfsT/VsvG1Jkgn3IelnwYsr0ibtYM3V4g+QCleJ25ts=; b=KHNezXzdhhwvUCBW7NSVIyxZuYIwSp3w1Sa1sJD4UXLVeeWhaEVPp1zSBA28Gb+R5JA6d5iIua79fDLPSYP+0Xo6JX56EVRNG/4wnjOC7/3OviDJp6PqJcsVURRXN1lz7NPE4jqsfophxG/+S8qKzTsGBbywX9utVo02HA7wNmnrW0csFS67Pj1YgLknF4H36w5g1TZC3nE6ygGOtj8q0G29TENmdQvtWajzg8M+MTKUjGFHeWgD4+4bG2PC9IFlUFZy/Qp7yqw+W3uAZNNtR/SWfp3+lelBSghEhSd2EuShdxbhVee7iZ84xu+UzS5T7E+gOKOv17Qo00j447kkSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gfsT/VsvG1Jkgn3IelnwYsr0ibtYM3V4g+QCleJ25ts=; b=YNv39Hz2siD3N/q8avQ4Oa/rz6F/rcKqsiNCZC02nuyoOfQ7Uc/qjbXud2EevZLELMsNjJDniR3lnYA8GdfkW4gFU3TqsV4TyQWKGc7/PIhguu7JAu8fxINpYkn5hhljoJC8hdCjomnhrlVvMfW8yOEVacYfqzc7b2mIApJ+eSE= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none; kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DBAPR04MB7285.eurprd04.prod.outlook.com (2603:10a6:10:1ac::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24; Sat, 12 Jun 2021 12:58:31 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4219.022; Sat, 12 Jun 2021 12:58:31 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com, Peng Fan Subject: [PATCH V7 0/4] soc: imx: add i.MX BLK-CTL support Date: Sat, 12 Jun 2021 21:31:30 +0800 Message-Id: <20210612133134.2738-1-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: SG2PR06CA0174.apcprd06.prod.outlook.com (2603:1096:1:1e::28) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by SG2PR06CA0174.apcprd06.prod.outlook.com (2603:1096:1:1e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Sat, 12 Jun 2021 12:58:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6d3d7b6b-a9f8-4bea-a6e4-08d92da1c74b X-MS-TrafficTypeDiagnostic: DBAPR04MB7285: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y0n8Rg5k/3hDu8e64je3ef5QQlKwecuPK5rrcT1gXejWqPts2rjktm3Ym4iWn888uMnJ106zd+qBs8TN5c9QQ/a43PGA0qVN2Siuszfs0erzZzC6SibK5Iq1YqsLb5XGAcM+LF6vVFc5dhGYZsb/k/NTArCyEewCIJR77u7sBuOLRDw4USHFywF4ITrUErvFs0l/zHUoqUy3nrFgzARIDNP+dZI2q5qqC/QZSXkEm8Q9wlXrHipUv2o9ZqyGlcc8Wdrc4WmMybE5NQDyESWUUWNW7vY2FE0iW/PTh5sy033Q99UW7GW37sVacnBBy3rdJfiMOT491I5/mqYDWvvribm/nagJmpo0xAHPfCy1x6VAuvqKjdwKwYbJk8PF8A9B0LB76ULwcXs0vlUW20jvOUBjMfdoN4wJLB4GNnqowctKS0amfrpyp1+eQ2ImdYFOPdgAOVH2+Filf/B+Dxn+nRS+4WAO8WQBYryp/YNVDhag8PEfx7EElC9nudPptNRk/kWkg7VNgROiVsRkXUwpQM9+d1+o12CJ/3Y0LTdIt3BKolsM89TgwCDy+X3F7IJELbbnh16rV6e6a8Tua3FOd4lf5veqKI1pAHQu3aYoUqP5sUgBaNxmhuvxrRzqlUljnlgKjHhgY5g3pnSYrirTnZsHOlTnvAWg9074mKT5z5ZITVCpqYQWfIfhUMiMql454Q0tBCtJY6IIXld36C0fseOPpU2KDUJq5yzPvfRfas2JXpdJH0KdyKInRoJAO/bi6uoW0XjtYwOiNvwelDRnXQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(136003)(366004)(396003)(39840400004)(6486002)(6666004)(8676002)(52116002)(2906002)(186003)(1076003)(16526019)(8936002)(26005)(4326008)(6506007)(66556008)(66476007)(66946007)(6512007)(316002)(38350700002)(38100700002)(478600001)(2616005)(956004)(966005)(83380400001)(7416002)(5660300002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: YZax11Whw4pLnvZtZ8kJxnLamPTcUTwj4VJghez+Mp6UtV6yMa7zuJ0ZXPg3U9/FwkS9gn1qYboq3H5dIreZiI9Dzb9SWAXKrbyyw5w/e7DPBuYqIB46Q/h1chx6ZU4TnvpSOkdICrQ8jV9xhFsj8RSFulv4RpaUy/D0av5yYVnbkscaPxKfnlW4lNrGy/wrw+ykumTmIBBi7GjYUGZiJzSvSiR6MgRLE2mkcIz0uWL5UQT/RCOAOi99r730+MlgFzmfD8tkMw9dwbC6FUeB/xPAiqaC7YK+K2Au0pLEWvG2WW/H51a+8E6sJRg8jyGH83HDV9LRDQHn1+L/hd7VH0OoQlBDkJ9yhqNbC48WBQBu/t/Fuvh3PNz1qpCf8aMc3+xUKQqHBGI3GInk98fPcKrgYggsMeX+aFIlYFAYqmp3TU7WA10iINIVv0QiNGLutMSRZ4lta+xht3tanbe0wj5SW117AqWFXDUP4tf3RJ/62xPxX8y5dcaqBU23inbu/tZ2RnUbUKk4x3QAnN4cxxYgZuJPDee/gY3U4AFEyGxgrmPXvKXxN9k27H4rpQ4alupdFx7dr7VSv/LyhF9OCYU29yNm23AlQt6fSMlaDn3DPmxv+n+ix5QsjZ7DVLPIIsj/xIfLpwWJxW3ABXaUJuOKJyZv4I77MWJGInTjRDPFALR1TLlPwvfgx71wKF4pAA2bHIXlR1rJwDB90JCraNZJzdgOYGhUPqZkCReV6yrSgnw7WlkpXCxp1GTPsAF45IIk9ZmkjTw1wkL0IcQfDKzNmhb68+/2eru4kF5tD9APyoQiZShTk98uoXsfOt4tfBdmX7/LQC/XyyOvl7WYpy7NiQ3WVZGycYWW/hlFsYW+MnHulgHSgQIMRbn8cjPTfvPx8oDjOVN/FupmnaOhIVWygwZjS3tyXxczd7toGxuTpQpYUyeMwH73uakhMQ/yXYCjBefV/HCydQAKKAb0WtYHxw5D6ALYDvjDAc180Ee/uoYjDt0/Ki9smyKRXHAEpIqv8btELEOWeizN4HmtWKtPPulogsnIE+eatJahTSdmdju8SvQ2UJgPlpu28JnNaSVNmSymOrlDd/0D/xFTQaQUlPEh68F3b+0txiRxynO8RUvuljiloMWtQEz6M6Ok7wHdue0F1GkvOL9Us7quBEhi87LGLgeCu7HFD60DVrJhSanUHNLOs86OomTAwTdVjouJ6QGgXv41DW+sVkKfxmf5yn3QBRq9rYOxUeJfWC8ADE1UOYc0Y4oA8fGl+bNRSvs5tk2g/9hY2OLOg3cdfOoCnrWL++d7+IZSuPLd0TaSJg6cPRJhQuBTPRBgXoUl X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d3d7b6b-a9f8-4bea-a6e4-08d92da1c74b X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2021 12:58:30.9202 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1RJbhXU99wdrekka+MPUpIl3TqT4eENQu9OU8xz6a5CGmUrCCDDKkID/2Lg/ZwOTilJm3hqHekn/0LGsNcE5kA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7285 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Peng Fan V7: patch 2: update patch title per Shawn Patch 3: Addressed several comments from Shawn V6: Thanks for Adam's report on V5. Resolve the error message dump, it is the child device reuse the parent device node and matches the parent driver. Filled the remove function for child device. A diff dts file for upstream: https://gist.github.com/MrVan/d73888d8273c43ea4a3b28fa668ca1d0 V5: Rework the blk-ctl driver to let sub-PGC use blk-ctl as parent power domain to fix the potential handshake issue. I still keep R-b/A-b tag for Patch 1,2,4, since very minor changes I only drop R-b tag for Patch 3, since it has big change. An example, the pgc_mipi not take pgc_dispmix as parent: pgc_dispmix: power-domain@10 { #power-domain-cells = <0>; reg = ; clocks = <&clk IMX8MM_CLK_DISP_ROOT>, <&clk IMX8MM_CLK_DISP_AXI_ROOT>, <&clk IMX8MM_CLK_DISP_APB_ROOT>; }; pgc_mipi: power-domain@11 { #power-domain-cells = <0>; reg = ; power-domains = <&dispmix_blk_ctl IMX8MM_BLK_CTL_PD_DISPMIX_BUS>; }; dispmix_blk_ctl: clock-controller@32e28000 { compatible = "fsl,imx8mm-dispmix-blk-ctl", "syscon"; reg = <0x32e28000 0x100>; #power-domain-cells = <1>; power-domains = <&pgc_dispmix>, <&pgc_mipi>; power-domain-names = "dispmix", "mipi"; clocks = <&clk IMX8MM_CLK_DISP_ROOT>, <&clk IMX8MM_CLK_DISP_AXI_ROOT>, <&clk IMX8MM_CLK_DISP_APB_ROOT>; }; V4: Add R-b tag Typo fix Update the power domain macro names Per Abel and Frieder V3: Add explaination for not listing items in patch 2 commit log Per Rob. Addressed comments from Lucas and Frieder on patch [3,4]. A few comments from Jacky was ignored, because following gpcv2 coding style. V2: Fix yaml check failure. Previously there is an effort from Abel that take BLK-CTL as clock provider, but it turns out that there is A/B lock issue and we are not able resolve that. Per discuss with Lucas and Jacky, we made an agreement that take BLK-CTL as a power domain provider and use GPC's domain as parent, the consumer node take BLK-CTL as power domain input. This patchset has been tested on i.MX8MM EVK board, but one hack is not included in the patchset is that the DISPMIX BLK-CTL MIPI_M/S_RESET not implemented. Per Lucas, we will finally have a MIPI DPHY driver, so fine to leave it. Thanks for Lucas's suggestion, Frieder Schrempf for collecting all the patches, Abel's previous BLK-CTL work, Jacky Bai on help debug issues. Peng Fan (4): dt-bindings: power: Add defines for i.MX8MM BLK-CTL power domains dt-bindings: soc: imx: Add bindings for i.MX BLK_CTL soc: imx: Add generic blk-ctl driver soc: imx: Add blk-ctl driver for i.MX8MM .../bindings/soc/imx/fsl,imx-blk-ctl.yaml | 66 ++++ drivers/soc/imx/Makefile | 2 +- drivers/soc/imx/blk-ctl-imx8mm.c | 139 ++++++++ drivers/soc/imx/blk-ctl.c | 325 ++++++++++++++++++ drivers/soc/imx/blk-ctl.h | 85 +++++ include/dt-bindings/power/imx8mm-power.h | 13 + 6 files changed, 629 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx-blk-ctl.yaml create mode 100644 drivers/soc/imx/blk-ctl-imx8mm.c create mode 100644 drivers/soc/imx/blk-ctl.c create mode 100644 drivers/soc/imx/blk-ctl.h -- 2.30.0