mbox series

[0/3] arm64: dts: meson: misc ODROID-N2/N2+ changes

Message ID 20210329161256.31171-1-christianshewitt@gmail.com
Headers show
Series arm64: dts: meson: misc ODROID-N2/N2+ changes | expand

Message

Christian Hewitt March 29, 2021, 4:12 p.m. UTC 
This series cleans-up and submits some minor patches used in HardKernel
Linux 5.10 and 5.11 images for the ODROID N2/N2+, and fixes a stray tab.

Christian Hewitt (1):
  arm64: dts: meson: remove extra tab from ODROID N2/N2+ ext_mdio node

Hyeonki Hong (2):
  arm64: dts: meson: add saradc node to ODROID N2/N2+
  arm64: dts: meson: add GPIO line names to ODROID N2/N2+

 .../dts/amlogic/meson-g12b-odroid-n2.dtsi     | 51 ++++++++++++++++++-
 1 file changed, 50 insertions(+), 1 deletion(-)

Comments

Neil Armstrong March 30, 2021, 3:23 p.m. UTC | #1 
Hi,

On 29/03/2021 18:12, Christian Hewitt wrote:
> From: Hyeonki Hong <hhk7734@gmail.com>

> 

> Add the meson saradc node to the ODROID N2/N2+ common dtsi.


Not sure why this is needed, does it fix something ?

Neil

> 

> Signed-off-by: Hyeonki Hong <hhk7734@gmail.com>

> ---

>  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 4 ++++

>  1 file changed, 4 insertions(+)

> 

> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi

> index 2f8d574c30c0..139c12cf9f66 100644

> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi

> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi

> @@ -508,6 +508,10 @@

>  	status = "okay";

>  };

>  

> +&saradc {

> +	status = "okay";

> +};

> +

>  /* SD card */

>  &sd_emmc_b {

>  	status = "okay";

>
Neil Armstrong March 30, 2021, 3:23 p.m. UTC | #2 
On 29/03/2021 18:12, Christian Hewitt wrote:
> From: Hyeonki Hong <hhk7734@gmail.com>

> 

> Add GPIO line-name identifiers to the ODROID N2/N2+ common dtsi.

> 

> Signed-off-by: Hyeonki Hong <hhk7734@gmail.com>

> ---

>  .../dts/amlogic/meson-g12b-odroid-n2.dtsi     | 45 +++++++++++++++++++

>  1 file changed, 45 insertions(+)

> 

> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi

> index 139c12cf9f66..4489715fc4f3 100644

> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi

> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi

> @@ -446,6 +446,51 @@

>  };

>  

>  &gpio {

> +	gpio-line-names =

> +		/* GPIOZ */

> +		"", "", "", "", "", "", "", "",

> +		"", "", "", "", "", "", "", "",

> +		/* GPIOH */

> +		"", "", "", "", "", "", "", "",

> +		"",

> +		/* BOOT */

> +		"", "", "", "", "", "", "", "",

> +		"", "", "", "", "", "", "", "",

> +		/* GPIOC */

> +		"", "", "", "", "", "", "", "",

> +		/* GPIOA */

> +		"PIN_44", /* GPIOA_0 */

> +		"PIN_46", /* GPIOA_1 */

> +		"PIN_45", /* GPIOA_2 */

> +		"PIN_47", /* GPIOA_3 */

> +		"PIN_26", /* GPIOA_4 */

> +		"", "", "", "", "", "",

> +		"PIN_42", /* GPIOA_11 */

> +		"PIN_32", /* GPIOA_12 */

> +		"PIN_7",  /* GPIOA_13 */

> +		"PIN_27", /* GPIOA_14 */

> +		"PIN_28", /* GPIOA_15 */

> +		/* GPIOX */

> +		"PIN_16", /* GPIOX_0 */

> +		"PIN_18", /* GPIOX_1 */

> +		"PIN_22", /* GPIOX_2 */

> +		"PIN_11", /* GPIOX_3 */

> +		"PIN_13", /* GPIOX_4 */

> +		"PIN_33", /* GPIOX_5 */

> +		"PIN_35", /* GPIOX_6 */

> +		"PIN_15", /* GPIOX_7 */

> +		"PIN_19", /* GPIOX_8 */

> +		"PIN_21", /* GPIOX_9 */

> +		"PIN_24", /* GPIOX_10 */

> +		"PIN_23", /* GPIOX_11 */

> +		"PIN_8",  /* GPIOX_12 */

> +		"PIN_10", /* GPIOX_13 */

> +		"PIN_29", /* GPIOX_14 */

> +		"PIN_31", /* GPIOX_15 */

> +		"PIN_12", /* GPIOX_16 */

> +		"PIN_3",  /* GPIOX_17 */

> +		"PIN_5",  /* GPIOX_18 */

> +		"PIN_36"; /* GPIOX_19 */

>  	/*

>  	 * WARNING: The USB Hub on the Odroid-N2 needs a reset signal

>  	 * to be turned high in order to be detected by the USB Controller

> 


Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Kevin Hilman March 31, 2021, 9:32 p.m. UTC | #3 
Hi Christian,

Christian Hewitt <christianshewitt@gmail.com> writes:

> From: Hyeonki Hong <hhk7734@gmail.com>

>

> Add GPIO line-name identifiers to the ODROID N2/N2+ common dtsi.

>

> Signed-off-by: Hyeonki Hong <hhk7734@gmail.com>


You need to add your SoB here also.

Kevin
Martin Blumenstingl April 5, 2021, 8:56 p.m. UTC | #4 
On Tue, Mar 30, 2021 at 1:18 AM Christian Hewitt
<christianshewitt@gmail.com> wrote:
>

> From: Hyeonki Hong <hhk7734@gmail.com>

>

> Add the meson saradc node to the ODROID N2/N2+ common dtsi.

in general I am fine with this as some SAR ADC channels seem to be on
the pin headers...

[...]
> +&saradc {

> +       status = "okay";

> +};

...but a vref-supply should be provided to get meaningful numbers