mbox series

[v5,0/7] phy: qcom-qmp: provide DP phy support for sm8250

Message ID 20210328205257.3348866-1-dmitry.baryshkov@linaro.org
Headers show
Series phy: qcom-qmp: provide DP phy support for sm8250 | expand

Message

Dmitry Baryshkov March 28, 2021, 8:52 p.m. UTC
Changes since v4:
 - Fix typo in the qcom,sc7180-qmp-usb3-phy name in the first patch

Changes since v3:
 - Move qcom,sc7180-qmp-usb3-phy and qcom,sdm845-qmp-usb3-phy from
   qcom,qmp-usb3-dp.yaml to qcom,qmp-phy.yaml
 - Do not touch qcom,sm8250-qmp-usb3-phy compatible

Changes since v2:
 - Drop unused qmp_v4_usb3_rx_tbl

Changes since v1:
 - Provide dt bindings
 - Split register renaming from sm8250-dp-phy patch
 - Add respective changes to sm8250 device tree

The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15:

  Linux 5.12-rc2 (2021-03-05 17:33:41 -0800)

are available in the Git repository at:

  https://git.linaro.org/people/dmitry.baryshkov/kernel.git sm8250-dp-phy

for you to fetch changes up to aef044832f8f34495c35f8324ee55e2500dc3db5:

  arm64: dts: qcom: use dp_phy to provide clocks to dispcc (2021-03-28 23:43:31 +0300)

----------------------------------------------------------------
Dmitry Baryshkov (7):
      dt-bindings: phy: qcom,qmp-usb3-dp-phy: move usb3 compatibles back to qcom,qmp-phy.yaml
      dt-bindings: phy: qcom,qmp-usb3-dp: Add support for SM8250
      phy: qcom-qmp: move DP functions to callbacks
      phy: qcom-qmp: rename common registers
      phy: qcom-qmp: add support for sm8250-usb3-dp phy
      arm64: dts: qcom: sm8250: switch usb1 qmp phy to USB3+DP mode
      arm64: dts: qcom: use dp_phy to provide clocks to dispcc

 .../devicetree/bindings/phy/qcom,qmp-phy.yaml      |   2 +
 .../bindings/phy/qcom,qmp-usb3-dp-phy.yaml         |   3 +-
 arch/arm64/boot/dts/qcom/sm8250.dtsi               |  31 +-
 drivers/phy/qualcomm/phy-qcom-qmp.c                | 850 +++++++++++++++------
 drivers/phy/qualcomm/phy-qcom-qmp.h                |  77 +-
 5 files changed, 693 insertions(+), 270 deletions(-)

Comments

Bjorn Andersson March 30, 2021, 3:33 a.m. UTC | #1
On Sun 28 Mar 15:52 CDT 2021, Dmitry Baryshkov wrote:

> Plug dp_phy-provided clocks to display clock controller.

> 


Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>


Regards,
Bjorn

> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> ---

>  arch/arm64/boot/dts/qcom/sm8250.dtsi | 8 ++++----

>  1 file changed, 4 insertions(+), 4 deletions(-)

> 

> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi

> index 0f79e6885004..a2478bd3590a 100644

> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi

> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi

> @@ -2600,8 +2600,8 @@ dispcc: clock-controller@af00000 {

>  				 <&dsi0_phy 1>,

>  				 <&dsi1_phy 0>,

>  				 <&dsi1_phy 1>,

> -				 <0>,

> -				 <0>,

> +				 <&dp_phy 0>,

> +				 <&dp_phy 1>,

>  				 <0>,

>  				 <0>,

>  				 <0>,

> @@ -2614,8 +2614,8 @@ dispcc: clock-controller@af00000 {

>  				      "dsi0_phy_pll_out_dsiclk",

>  				      "dsi1_phy_pll_out_byteclk",

>  				      "dsi1_phy_pll_out_dsiclk",

> -				      "dp_link_clk_divsel_ten",

> -				      "dp_vco_divided_clk_src_mux",

> +				      "dp_phy_pll_link_clk",

> +				      "dp_phy_pll_vco_div_clk",

>  				      "dptx1_phy_pll_link_clk",

>  				      "dptx1_phy_pll_vco_div_clk",

>  				      "dptx2_phy_pll_link_clk",

> -- 

> 2.30.2

>
Vinod Koul March 31, 2021, 12:25 p.m. UTC | #2
On 28-03-21, 23:52, Dmitry Baryshkov wrote:
> Changes since v4:
>  - Fix typo in the qcom,sc7180-qmp-usb3-phy name in the first patch
> 
> Changes since v3:
>  - Move qcom,sc7180-qmp-usb3-phy and qcom,sdm845-qmp-usb3-phy from
>    qcom,qmp-usb3-dp.yaml to qcom,qmp-phy.yaml
>  - Do not touch qcom,sm8250-qmp-usb3-phy compatible
> 
> Changes since v2:
>  - Drop unused qmp_v4_usb3_rx_tbl
> 
> Changes since v1:
>  - Provide dt bindings
>  - Split register renaming from sm8250-dp-phy patch
>  - Add respective changes to sm8250 device tree
> 
> The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15:
> 
>   Linux 5.12-rc2 (2021-03-05 17:33:41 -0800)

This should be based on phy-next. This fails to apply for me. Can you
please rebase and acks and resend

Thanks