mbox series

[PATCHv1,0/4] Bx50v3 DT improvements

Message ID 20210223183346.138575-1-sebastian.reichel@collabora.com
Headers show
Series Bx50v3 DT improvements | expand

Message

Sebastian Reichel Feb. 23, 2021, 6:33 p.m. UTC 
Hi,

These are a bunch of small unrelated improvements for the GE Bx50v3
device tree (and BA16 system on module, which is currently only used
by Bx50v3).

Thanks for reviewing/merging them,

-- Sebastian

Ian Ray (1):
  ARM: dts: imx: bx50v3: Define GPIO line names

Sebastian Reichel (3):
  ARM: dts: imx: ba16: add USB OTG VBUS enable GPIO
  ARM: dts: imx: ba16: improve PHY information
  ARM: dts: imx: bx50v3: i2c GPIOs are open drain

 arch/arm/boot/dts/imx6q-b450v3.dts  |  5 +++++
 arch/arm/boot/dts/imx6q-b650v3.dts  |  5 +++++
 arch/arm/boot/dts/imx6q-b850v3.dts  |  5 +++++
 arch/arm/boot/dts/imx6q-ba16.dtsi   | 22 ++++++++++++++++++++++
 arch/arm/boot/dts/imx6q-bx50v3.dtsi | 12 ++++++------
 5 files changed, 43 insertions(+), 6 deletions(-)

Comments

Shawn Guo March 8, 2021, 12:35 a.m. UTC | #1 
On Tue, Feb 23, 2021 at 07:33:43PM +0100, Sebastian Reichel wrote:
> Add VBUS regulator GPIO information, so that USB OTG port can

> also be used in host mode.

> 

> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>


'ARM: dts: imx6q-ba16: ' this style for prefix maybe?

> ---

>  arch/arm/boot/dts/imx6q-ba16.dtsi | 10 ++++++++++

>  1 file changed, 10 insertions(+)

> 

> diff --git a/arch/arm/boot/dts/imx6q-ba16.dtsi b/arch/arm/boot/dts/imx6q-ba16.dtsi

> index e4578ed3371e..4793ef5171aa 100644

> --- a/arch/arm/boot/dts/imx6q-ba16.dtsi

> +++ b/arch/arm/boot/dts/imx6q-ba16.dtsi

> @@ -124,6 +124,10 @@ reg_usb_otg_vbus: regulator-usbotgvbus {

>  		regulator-name = "usb_otg_vbus";

>  		regulator-min-microvolt = <5000000>;

>  		regulator-max-microvolt = <5000000>;

> +


This is newline is not necessary.

Shawn

> +		pinctrl-0 = <&pinctrl_usbotg_vbus>;

> +		gpio = <&gpio4 15 GPIO_ACTIVE_HIGH>;

> +		enable-active-high;

>  	};

>  };

>  

> @@ -575,6 +579,12 @@ MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID 0x17059

>  		>;

>  	};

>  

> +	pinctrl_usbotg_vbus: usbotgvbusgrp {

> +		fsl,pins = <

> +			MX6QDL_PAD_KEY_ROW4__GPIO4_IO15 0x000b0

> +		>;

> +	};

> +

>  	pinctrl_usdhc2: usdhc2grp {

>  		fsl,pins = <

>  			MX6QDL_PAD_SD2_CMD__SD2_CMD	0x17059

> -- 

> 2.30.0

>