mbox series

[v2,net-next,0/4] Add support for Qualcomm QCA807x PHYs

Message ID 20210210125523.2146352-1-robert.marko@sartura.hr
Headers show
Series Add support for Qualcomm QCA807x PHYs | expand

Message

Robert Marko Feb. 10, 2021, 12:55 p.m. UTC 
This patch series adds support for Qualcomm QCA807x PHYs.

These are really common companion PHYs on boards featuring
Qualcomm IPQ40xx, IPQ60xx and IPQ807x SoCs.

They are 2 or 5 port IEEE 802.3 clause 22 compliant
10BASE-Te, 100BASE-TX and 1000BASE-T PHY-s.

They feature 2 SerDes, one for PSGMII or QSGMII connection with MAC,
while second one is SGMII for connection to MAC or fiber.

Both models have a combo port that supports 1000BASE-X and 100BASE-FX
fiber.

Each PHY inside of QCA807x series has 2 digitally controlled output only
pins that natively drive LED-s.
But some vendors used these to driver generic LED-s controlled by
user space, so lets enable registering each PHY as GPIO controller and
add driver for it.

Robert Marko (4):
  dt-bindings: net: Add QCA807x PHY
  dt-bindings: net: Add bindings for Qualcomm QCA807x
  net: phy: Add Qualcomm QCA807x driver
  MAINTAINERS: Add entry for Qualcomm QCA807x PHY driver

 .../devicetree/bindings/net/qcom,qca807x.yaml |  70 ++
 MAINTAINERS                                   |   9 +
 drivers/net/phy/Kconfig                       |  10 +
 drivers/net/phy/Makefile                      |   1 +
 drivers/net/phy/qca807x.c                     | 855 ++++++++++++++++++
 include/dt-bindings/net/qcom-qca807x.h        |  30 +
 6 files changed, 975 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/qcom,qca807x.yaml
 create mode 100644 drivers/net/phy/qca807x.c
 create mode 100644 include/dt-bindings/net/qcom-qca807x.h

Comments

Andrew Lunn Feb. 11, 2021, 12:05 a.m. UTC | #1 
On Wed, Feb 10, 2021 at 01:55:22PM +0100, Robert Marko wrote:

Hi Robert

Could you move the GPIO driver into a patch of its own, and Cc: the
GPIO maintainer and list for that patch please.

     Andrew
Andrew Lunn Feb. 11, 2021, 12:25 a.m. UTC | #2 
On Wed, Feb 10, 2021 at 01:55:20PM +0100, Robert Marko wrote:
> Add DT bindings for Qualcomm QCA807x PHY series.

> 

> Signed-off-by: Robert Marko <robert.marko@sartura.hr>

> Cc: Luka Perkov <luka.perkov@sartura.hr>

> ---

> Changes in v2:

> * Drop PSGMII/QSGMII TX driver defines

> 

>  include/dt-bindings/net/qcom-qca807x.h | 30 ++++++++++++++++++++++++++

>  1 file changed, 30 insertions(+)

>  create mode 100644 include/dt-bindings/net/qcom-qca807x.h

> 

> diff --git a/include/dt-bindings/net/qcom-qca807x.h b/include/dt-bindings/net/qcom-qca807x.h

> new file mode 100644

> index 000000000000..a5ac12777c2b

> --- /dev/null

> +++ b/include/dt-bindings/net/qcom-qca807x.h

> @@ -0,0 +1,30 @@

> +/* SPDX-License-Identifier: GPL-2.0-or-later */

> +/*

> + * Device Tree constants for the Qualcomm QCA807X PHYs

> + */

> +

> +#ifndef _DT_BINDINGS_QCOM_QCA807X_H

> +#define _DT_BINDINGS_QCOM_QCA807X_H

> +

> +/* Full amplitude, full bias current */

> +#define QCA807X_CONTROL_DAC_FULL_VOLT_BIAS		0

> +/* Amplitude follow DSP (amplitude is adjusted based on cable length), half bias current */

> +#define QCA807X_CONTROL_DAC_DSP_VOLT_HALF_BIAS		1

> +/* Full amplitude, bias current follow DSP (bias current is adjusted based on cable length) */

> +#define QCA807X_CONTROL_DAC_FULL_VOLT_DSP_BIAS		2

> +/* Both amplitude and bias current follow DSP */

> +#define QCA807X_CONTROL_DAC_DSP_VOLT_BIAS		3

> +/* Full amplitude, half bias current */

> +#define QCA807X_CONTROL_DAC_FULL_VOLT_HALF_BIAS		4

> +/* Amplitude follow DSP setting; 1/4 bias current when cable<10m,

> + * otherwise half bias current

> + */

> +#define QCA807X_CONTROL_DAC_DSP_VOLT_QUARTER_BIAS	5

> +/* Full amplitude; same bias current setting with “010” and “011”,

> + * but half more bias is reduced when cable <10m

> + */

> +#define QCA807X_CONTROL_DAC_FULL_VOLT_HALF_BIAS_SHORT	6

> +/* Amplitude follow DSP; same bias current setting with “110”, default value */

> +#define QCA807X_CONTROL_DAC_DSP_VOLT_HALF_BIAS_SHORT	7


Are these really properties of the board? That is what device tree is
supposed to be about. These seem like configuration options. Which
suggests they should actually be a PHY tunable.

	 Andrew