mbox series

[v3,0/2] J7200: Add support for higher speed modes in MMCSD subsystems

Message ID 20210127150815.16991-1-a-govindraju@ti.com
Headers show
Series J7200: Add support for higher speed modes in MMCSD subsystems | expand

Message

Aswath Govindraju Jan. 27, 2021, 3:08 p.m. UTC
The following series of patches 
- Add support for the zeroth instance of GPIO subsystem in the main domain
- Add voltage regulator device tree nodes and their corresponding pinmux 
  to support power cycle and voltage switch required for UHS-I modes
- sets respective tags in sdhci0 node to support higher speeds
- remove no-1-8-v tag from sdhci1 node to support UHS-I modes 

Changes since v2:
- Added main_gpio0 DT node
- Added voltage regulator device tree nodes required to support UHS-I modes

Changes since v1:
- squashed the two patches into one
- added performance logs for the above mentioned speed modes

Aswath Govindraju (2):
  dts: ti: k3-j7200-main: Add support for zeroth instance of GPIO subsystem
  arm64: dts: ti: k3-j7200: Add support for higher speed modes in MMCSD
    subsystems

 .../dts/ti/k3-j7200-common-proc-board.dts     | 31 +++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-j7200-main.dtsi     | 20 +++++++++++-
 2 files changed, 50 insertions(+), 1 deletion(-)

Comments

Nishanth Menon Jan. 27, 2021, 3:12 p.m. UTC | #1
On 20:38-20210127, Aswath Govindraju wrote:
> Add support for the zeroth instance of GPIO subsystem in the main domain.
> 
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>


I really dont want to pick up one patch per node instance. It is hard
to scale and just creates a lot of noise.

> ---
>  arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> index 4cc2e9094d0e..75dffbb26d52 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> @@ -294,6 +294,23 @@
>  		pinctrl-single,function-mask = <0xffffffff>;
>  	};
>  
> +	main_gpio0: gpio@600000 {
> +		compatible = "ti,j721e-gpio", "ti,keystone-gpio";
> +		reg = <0x0 0x00600000 0x0 0x100>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +		interrupt-parent = <&main_gpio_intr>;
> +		interrupts = <145>, <146>, <147>, <148>,
> +			     <149>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +		ti,ngpio = <69>;
> +		ti,davinci-gpio-unbanked = <0>;
> +		power-domains = <&k3_pds 105 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 105 0>;
> +		clock-names = "gpio";
> +	};
> +
>  	main_uart0: serial@2800000 {
>  		compatible = "ti,j721e-uart", "ti,am654-uart";
>  		reg = <0x00 0x02800000 0x00 0x100>;
> -- 
> 2.17.1
>
Nishanth Menon Jan. 27, 2021, 3:54 p.m. UTC | #2
On 20:56-20210127, Aswath Govindraju wrote:
> Hi Nishanth,
> 
> On 27/01/21 8:42 pm, Nishanth Menon wrote:
> > On 20:38-20210127, Aswath Govindraju wrote:
> >> Add support for the zeroth instance of GPIO subsystem in the main domain.
> >>
> >> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> > 
> > 
> > I really dont want to pick up one patch per node instance. It is hard
> > to scale and just creates a lot of noise.
> > 
> 
> As the main goal of the patch series was to add support for higher speed
> modes in MMC, I added only the required ones. If required I will send a
> follow up patch to add the remaining GPIO nodes.


I dont plan on picking this patch up in it's current form. please send a
patch with all the gpio nodes added in as it makes no sense to split
these out.
Aswath Govindraju Jan. 28, 2021, 4:21 p.m. UTC | #3
Hi Nishanth,

On 27/01/21 9:24 pm, Nishanth Menon wrote:
> On 20:56-20210127, Aswath Govindraju wrote:

>> Hi Nishanth,

>>

>> On 27/01/21 8:42 pm, Nishanth Menon wrote:

>>> On 20:38-20210127, Aswath Govindraju wrote:

>>>> Add support for the zeroth instance of GPIO subsystem in the main domain.

>>>>

>>>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>

>>>

>>>

>>> I really dont want to pick up one patch per node instance. It is hard

>>> to scale and just creates a lot of noise.

>>>

>>

>> As the main goal of the patch series was to add support for higher speed

>> modes in MMC, I added only the required ones. If required I will send a

>> follow up patch to add the remaining GPIO nodes.

> 

> 

> I dont plan on picking this patch up in it's current form. please send a

> patch with all the gpio nodes added in as it makes no sense to split

> these out.

> 


I have sent a respin for this patch series(v4) which adds all the GPIO
nodes in the device tree files.

Thanks,
Aswath