mbox series

[0/7] STM32 uart cleanup and improvements

Message ID 20210106162203.28854-1-erwan.leray@foss.st.com
Headers show
Series STM32 uart cleanup and improvements | expand

Message

Erwan LE RAY Jan. 6, 2021, 4:21 p.m. UTC 
This series brings various fixes, cleanups and improvements to stm32-usart
driver.

Changes in v2:
- delete DMA cookie variables removal from V1 patch as already done by a
previous patch
- update commit message as DMA cookie variables removal is no more
included in this patch

Erwan Le Ray (8):
  serial: stm32: fix DMA initialization error handling
  serial: stm32: fix code cleaning warnings and checks
  serial: stm32: add "_usart" prefix in functions name
  serial: stm32: add author
  dt-bindings: serial: stm32: update rts-gpios and cts-gpios
  serial: stm32: update conflicting RTS/CTS config comment
  serial: stm32: clean probe and remove port deinit
  serial: stm32: update transmission complete error message in shutdown

 .../bindings/serial/st,stm32-uart.yaml        |  13 +-
 drivers/tty/serial/stm32-usart.c              | 415 +++++++++---------
 2 files changed, 227 insertions(+), 201 deletions(-)

Comments

Erwan LE RAY Jan. 12, 2021, 10:02 a.m. UTC | #1 
Hello Greg,

As the V2 is already in your tty-next branch, how do want me to proceed 
to deliver the fix for Jiri remark ?
Do you expect a V3 or a new fix ?

Best Regards, Erwan.


On 1/11/21 10:58 AM, Jiri Slaby wrote:
> On 06. 01. 21, 17:21, Erwan Le Ray wrote:
>> --- a/drivers/tty/serial/stm32-usart.c
>> +++ b/drivers/tty/serial/stm32-usart.c
> ...
>> @@ -973,18 +971,17 @@ static int stm32_init_port(struct stm32_port 
>> *stm32port,
>>       struct resource *res;
>>       int ret;
>> +    ret = platform_get_irq(pdev, 0);
>> +    if (ret <= 0)
>> +        return ret ? : -ENODEV;
>> +
>>       port->iotype    = UPIO_MEM;
>>       port->flags    = UPF_BOOT_AUTOCONF;
>>       port->ops    = &stm32_uart_ops;
>>       port->dev    = &pdev->dev;
>>       port->fifosize    = stm32port->info->cfg.fifosize;
>>       port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_STM32_CONSOLE);
>> -
>> -    ret = platform_get_irq(pdev, 0);
>> -    if (ret <= 0)
>> -        return ret ? : -ENODEV;
>>       port->irq = ret;
> 
> I would move this set from ret above too. Or introduce a new variable, 
> e.g. "irq".
> 
> thanks,
Greg KH Jan. 12, 2021, 10:24 a.m. UTC | #2 
On Tue, Jan 12, 2021 at 11:02:43AM +0100, Erwan LE RAY wrote:
> Hello Greg,

> 

> As the V2 is already in your tty-next branch, how do want me to proceed to

> deliver the fix for Jiri remark ?

> Do you expect a V3 or a new fix ?


Patches on top of that tree please, I can't drop something in a public
tree.

thanks,

greg k-h