| Message ID | 20210104192602.10131-1-nramas@linux.microsoft.com |
|---|---|
| Headers | show |
| Series | Carry forward IMA measurement log on kexec on ARM64 | expand |
On Mon, Jan 04, 2021 at 11:25:56AM -0800, Lakshmi Ramasubramanian wrote: > On kexec file load Integrity Measurement Architecture (IMA) subsystem > may verify the IMA signature of the kernel and initramfs, and measure > it. The command line parameters passed to the kernel in the kexec call > may also be measured by IMA. A remote attestation service can verify > a TPM quote based on the TPM event log, the IMA measurement list, and > the TPM PCR data. This can be achieved only if the IMA measurement log > is carried over from the current kernel to the next kernel across > the kexec call. > > powerpc already supports carrying forward the IMA measurement log on > kexec. This patch set adds support for carrying forward the IMA > measurement log on kexec on ARM64. > > This patch set moves the platform independent code defined for powerpc > such that it can be reused for other platforms as well. A chosen node > "linux,ima-kexec-buffer" is added to the DTB for ARM64 to hold > the address and the size of the memory reserved to carry > the IMA measurement log. > > This patch set has been tested for ARM64 platform using QEMU. > I would like help from the community for testing this change on powerpc. > Thanks. > > This patch set is based on > commit a29a64445089 ("powerpc: Use common of_kexec_setup_new_fdt()") > in https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git > "dt/kexec" branch. This all looks good to me. I'd suggest you send the above patches out as part of this series because I don't plan to do so. I would like to also resolve the vmalloc vs. kmalloc difference for allocating the FDT. Then we can further consolidate the DT kexec code. It all needs some acks from arm64 and powerpc maintainers. As far as merging, I think via the integrity tree makes the most sense. Rob
On Tue, 2021-01-12 at 08:42 -0600, Rob Herring wrote: > On Mon, Jan 04, 2021 at 11:25:56AM -0800, Lakshmi Ramasubramanian wrote: > > On kexec file load Integrity Measurement Architecture (IMA) subsystem > > may verify the IMA signature of the kernel and initramfs, and measure > > it. The command line parameters passed to the kernel in the kexec call > > may also be measured by IMA. A remote attestation service can verify > > a TPM quote based on the TPM event log, the IMA measurement list, and > > the TPM PCR data. This can be achieved only if the IMA measurement log > > is carried over from the current kernel to the next kernel across > > the kexec call. > > > > powerpc already supports carrying forward the IMA measurement log on > > kexec. This patch set adds support for carrying forward the IMA > > measurement log on kexec on ARM64. > > > > This patch set moves the platform independent code defined for powerpc > > such that it can be reused for other platforms as well. A chosen node > > "linux,ima-kexec-buffer" is added to the DTB for ARM64 to hold > > the address and the size of the memory reserved to carry > > the IMA measurement log. > > > > This patch set has been tested for ARM64 platform using QEMU. > > I would like help from the community for testing this change on powerpc. > > Thanks. > > > > This patch set is based on > > commit a29a64445089 ("powerpc: Use common of_kexec_setup_new_fdt()") > > in https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git > > "dt/kexec" branch. > > This all looks good to me. I'd suggest you send the above patches out as > part of this series because I don't plan to do so. > > I would like to also resolve the vmalloc vs. kmalloc difference for > allocating the FDT. Then we can further consolidate the DT kexec code. > > It all needs some acks from arm64 and powerpc maintainers. As far as > merging, I think via the integrity tree makes the most sense. Thanks, Rob. Lakshmi, please update Rob's patches to include patch descriptions before re-posting. Mimi
On 1/12/21 6:42 AM, Rob Herring wrote: > On Mon, Jan 04, 2021 at 11:25:56AM -0800, Lakshmi Ramasubramanian wrote: >> On kexec file load Integrity Measurement Architecture (IMA) subsystem >> may verify the IMA signature of the kernel and initramfs, and measure >> it. The command line parameters passed to the kernel in the kexec call >> may also be measured by IMA. A remote attestation service can verify >> a TPM quote based on the TPM event log, the IMA measurement list, and >> the TPM PCR data. This can be achieved only if the IMA measurement log >> is carried over from the current kernel to the next kernel across >> the kexec call. >> >> powerpc already supports carrying forward the IMA measurement log on >> kexec. This patch set adds support for carrying forward the IMA >> measurement log on kexec on ARM64. >> >> This patch set moves the platform independent code defined for powerpc >> such that it can be reused for other platforms as well. A chosen node >> "linux,ima-kexec-buffer" is added to the DTB for ARM64 to hold >> the address and the size of the memory reserved to carry >> the IMA measurement log. >> >> This patch set has been tested for ARM64 platform using QEMU. >> I would like help from the community for testing this change on powerpc. >> Thanks. >> >> This patch set is based on >> commit a29a64445089 ("powerpc: Use common of_kexec_setup_new_fdt()") >> in https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git >> "dt/kexec" branch. > > This all looks good to me. I'd suggest you send the above patches out as > part of this series because I don't plan to do so. Thanks for reviewing the patches Rob. Sure - I'll add your patches to this series. > I would like to also resolve the vmalloc vs. kmalloc difference for > allocating the FDT. Then we can further consolidate the DT kexec code. I think FDT allocation using vmalloc for ARM64 can be changed to kmalloc. What are the other changes you'd like me to do in arm64/powerpc DT kexec code in this patch series? @AKASHI Takahiro - could you please let me know if the above sounds right? > > It all needs some acks from arm64 and powerpc maintainers. As far as > merging, I think via the integrity tree makes the most sense. I'll create the patch series in "next-integrity" branch. Thiago/Mimi have acked some of the patches. Please review the remaining patches in this version. Could arm64 maintainers please review the patches and respond? thanks, -lakshmi
On 1/12/21 10:05 AM, Mimi Zohar wrote: > On Tue, 2021-01-12 at 08:42 -0600, Rob Herring wrote: >> On Mon, Jan 04, 2021 at 11:25:56AM -0800, Lakshmi Ramasubramanian wrote: >>> On kexec file load Integrity Measurement Architecture (IMA) subsystem >>> may verify the IMA signature of the kernel and initramfs, and measure >>> it. The command line parameters passed to the kernel in the kexec call >>> may also be measured by IMA. A remote attestation service can verify >>> a TPM quote based on the TPM event log, the IMA measurement list, and >>> the TPM PCR data. This can be achieved only if the IMA measurement log >>> is carried over from the current kernel to the next kernel across >>> the kexec call. >>> >>> powerpc already supports carrying forward the IMA measurement log on >>> kexec. This patch set adds support for carrying forward the IMA >>> measurement log on kexec on ARM64. >>> >>> This patch set moves the platform independent code defined for powerpc >>> such that it can be reused for other platforms as well. A chosen node >>> "linux,ima-kexec-buffer" is added to the DTB for ARM64 to hold >>> the address and the size of the memory reserved to carry >>> the IMA measurement log. >>> >>> This patch set has been tested for ARM64 platform using QEMU. >>> I would like help from the community for testing this change on powerpc. >>> Thanks. >>> >>> This patch set is based on >>> commit a29a64445089 ("powerpc: Use common of_kexec_setup_new_fdt()") >>> in https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git >>> "dt/kexec" branch. >> >> This all looks good to me. I'd suggest you send the above patches out as >> part of this series because I don't plan to do so. >> >> I would like to also resolve the vmalloc vs. kmalloc difference for >> allocating the FDT. Then we can further consolidate the DT kexec code. >> >> It all needs some acks from arm64 and powerpc maintainers. As far as >> merging, I think via the integrity tree makes the most sense. > > Thanks, Rob. Lakshmi, please update Rob's patches to include patch > descriptions before re-posting. > Will do Mimi. thanks, -lakshmi
Mimi Zohar <zohar@linux.ibm.com> writes: > On Tue, 2021-01-12 at 08:42 -0600, Rob Herring wrote: >> On Mon, Jan 04, 2021 at 11:25:56AM -0800, Lakshmi Ramasubramanian wrote: >> > On kexec file load Integrity Measurement Architecture (IMA) subsystem >> > may verify the IMA signature of the kernel and initramfs, and measure >> > it. The command line parameters passed to the kernel in the kexec call >> > may also be measured by IMA. A remote attestation service can verify >> > a TPM quote based on the TPM event log, the IMA measurement list, and >> > the TPM PCR data. This can be achieved only if the IMA measurement log >> > is carried over from the current kernel to the next kernel across >> > the kexec call. >> > >> > powerpc already supports carrying forward the IMA measurement log on >> > kexec. This patch set adds support for carrying forward the IMA >> > measurement log on kexec on ARM64. >> > >> > This patch set moves the platform independent code defined for powerpc >> > such that it can be reused for other platforms as well. A chosen node >> > "linux,ima-kexec-buffer" is added to the DTB for ARM64 to hold >> > the address and the size of the memory reserved to carry >> > the IMA measurement log. >> > >> > This patch set has been tested for ARM64 platform using QEMU. >> > I would like help from the community for testing this change on powerpc. >> > Thanks. >> > >> > This patch set is based on >> > commit a29a64445089 ("powerpc: Use common of_kexec_setup_new_fdt()") >> > in https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git >> > "dt/kexec" branch. >> >> This all looks good to me. I'd suggest you send the above patches out as >> part of this series because I don't plan to do so. >> >> I would like to also resolve the vmalloc vs. kmalloc difference for >> allocating the FDT. Then we can further consolidate the DT kexec code. >> >> It all needs some acks from arm64 and powerpc maintainers. As far as >> merging, I think via the integrity tree makes the most sense. > > Thanks, Rob. Lakshmi, please update Rob's patches to include patch > descriptions before re-posting. Also please update the powerpc mailing list address to linuxppc-dev@lists.ozlabs.org -- Thiago Jung Bauermann IBM Linux Technology Center
Hi Lakshmi, On Mon, 2021-01-04 at 11:26 -0800, Lakshmi Ramasubramanian wrote: > diff --git a/arch/powerpc/kexec/file_load_64.c b/arch/powerpc/kexec/file_load_64.c > index a05c19b3cc60..3cab318aa3b9 100644 > --- a/arch/powerpc/kexec/file_load_64.c > +++ b/arch/powerpc/kexec/file_load_64.c > @@ -17,6 +17,7 @@ > #include <linux/kexec.h> > #include <linux/of_fdt.h> > #include <linux/libfdt.h> > +#include <linux/of.h> > #include <linux/of_device.h> > #include <linux/memblock.h> > #include <linux/slab.h> > @@ -944,7 +945,8 @@ int setup_new_fdt_ppc64(const struct kimage *image, void *fdt, > struct crash_mem *umem = NULL, *rmem = NULL; > int i, nr_ranges, ret; > > - ret = setup_new_fdt(image, fdt, initrd_load_addr, initrd_len, cmdline); > + ret = of_kexec_setup_new_fdt(image, fdt, initrd_load_addr, initrd_len, > + cmdline); > if (ret) > goto out; > The "powerpc: Move arch independent ima kexec functions to drivers/of/kexec.c" moved setup_ima_buffer() to of_kexec_setup_new_fdt(). Defering making the change from setup_new_fdt() to of_kexec_setup_new_fdt() here, is not bisect safe. Mimi
On 1/12/21 3:30 PM, Mimi Zohar wrote: > Hi Lakshmi, > > On Mon, 2021-01-04 at 11:26 -0800, Lakshmi Ramasubramanian wrote: > >> diff --git a/arch/powerpc/kexec/file_load_64.c b/arch/powerpc/kexec/file_load_64.c >> index a05c19b3cc60..3cab318aa3b9 100644 >> --- a/arch/powerpc/kexec/file_load_64.c >> +++ b/arch/powerpc/kexec/file_load_64.c >> @@ -17,6 +17,7 @@ >> #include <linux/kexec.h> >> #include <linux/of_fdt.h> >> #include <linux/libfdt.h> >> +#include <linux/of.h> >> #include <linux/of_device.h> >> #include <linux/memblock.h> >> #include <linux/slab.h> >> @@ -944,7 +945,8 @@ int setup_new_fdt_ppc64(const struct kimage *image, void *fdt, >> struct crash_mem *umem = NULL, *rmem = NULL; >> int i, nr_ranges, ret; >> >> - ret = setup_new_fdt(image, fdt, initrd_load_addr, initrd_len, cmdline); >> + ret = of_kexec_setup_new_fdt(image, fdt, initrd_load_addr, initrd_len, >> + cmdline); >> if (ret) >> goto out; >> > > The "powerpc: Move arch independent ima kexec functions to > drivers/of/kexec.c" moved setup_ima_buffer() to > of_kexec_setup_new_fdt(). Defering making the change from > setup_new_fdt() to of_kexec_setup_new_fdt() here, is not bisect safe. > Agreed - I will move this change to "powerpc: Move arch independent ima kexec functions to drivers/of/kexec.c" patch. thanks, -lakshmi
Lakshmi Ramasubramanian <nramas@linux.microsoft.com> writes: > delete_fdt_mem_rsv() defined in "arch/powerpc/kexec/file_load.c" > has been renamed to fdt_find_and_del_mem_rsv(), and moved to > "drivers/of/kexec.c". > > Remove delete_fdt_mem_rsv() in "arch/powerpc/kexec/file_load.c". > > Call of_kexec_setup_new_fdt() from setup_new_fdt_ppc64() and > remove setup_new_fdt() in "arch/powerpc/kexec/file_load.c". > > Co-developed-by: Prakhar Srivastava <prsriva@linux.microsoft.com> > Signed-off-by: Prakhar Srivastava <prsriva@linux.microsoft.com> > Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com> > --- > arch/powerpc/include/asm/kexec.h | 4 --- > arch/powerpc/kexec/file_load.c | 60 ------------------------------- > arch/powerpc/kexec/file_load_64.c | 4 ++- > 3 files changed, 3 insertions(+), 65 deletions(-) Reviewed-by: Thiago Jung Bauermann <bauerman@linux.ibm.com> -- Thiago Jung Bauermann IBM Linux Technology Center
On kexec file load Integrity Measurement Architecture (IMA) subsystem may verify the IMA signature of the kernel and initramfs, and measure it. The command line parameters passed to the kernel in the kexec call may also be measured by IMA. A remote attestation service can verify a TPM quote based on the TPM event log, the IMA measurement list, and the TPM PCR data. This can be achieved only if the IMA measurement log is carried over from the current kernel to the next kernel across the kexec call. powerpc already supports carrying forward the IMA measurement log on kexec. This patch set adds support for carrying forward the IMA measurement log on kexec on ARM64. This patch set moves the platform independent code defined for powerpc such that it can be reused for other platforms as well. A chosen node "linux,ima-kexec-buffer" is added to the DTB for ARM64 to hold the address and the size of the memory reserved to carry the IMA measurement log. This patch set has been tested for ARM64 platform using QEMU. I would like help from the community for testing this change on powerpc. Thanks. This patch set is based on commit a29a64445089 ("powerpc: Use common of_kexec_setup_new_fdt()") in https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git "dt/kexec" branch. Changelog: v14 - Select CONFIG_HAVE_IMA_KEXEC for CONFIG_KEXEC_FILE, for powerpc and arm64, if CONFIG_IMA is enabled. - Use IS_ENABLED() macro instead of "#ifdef" in remove_ima_buffer(), ima_get_kexec_buffer(), and ima_free_kexec_buffer(). - Call of_kexec_setup_new_fdt() from setup_new_fdt_ppc64() and remove setup_new_fdt() in "arch/powerpc/kexec/file_load.c". v13 - Moved the arch independent functions to drivers/of/kexec.c and then refactored the code. - Moved arch_ima_add_kexec_buffer() to security/integrity/ima/ima_kexec.c v12 - Use fdt_appendprop_addrrange() in setup_ima_buffer() to setup the IMA measurement list property in the device tree. - Moved architecture independent functions from "arch/powerpc/kexec/ima.c" to "drivers/of/kexec." - Deleted "arch/powerpc/kexec/ima.c" and "arch/powerpc/include/asm/ima.h". v11 - Rebased the changes on the kexec code refactoring done by Rob Herring in his "dt/kexec" branch - Removed "extern" keyword in function declarations - Removed unnecessary header files included in C files - Updated patch descriptions per Thiago's comments v10 - Moved delete_fdt_mem_rsv(), remove_ima_buffer(), get_ima_kexec_buffer, and get_root_addr_size_cells() to drivers/of/kexec.c - Moved arch_ima_add_kexec_buffer() to security/integrity/ima/ima_kexec.c - Conditionally define IMA buffer fields in struct kimage_arch v9 - Moved delete_fdt_mem_rsv() to drivers/of/kexec_fdt.c - Defined a new function get_ima_kexec_buffer() in drivers/of/ima_kexec.c to replace do_get_kexec_buffer() - Changed remove_ima_kexec_buffer() to the original function name remove_ima_buffer() - Moved remove_ima_buffer() to drivers/of/ima_kexec.c - Moved ima_get_kexec_buffer() and ima_free_kexec_buffer() to security/integrity/ima/ima_kexec.c v8: - Moved remove_ima_kexec_buffer(), do_get_kexec_buffer(), and delete_fdt_mem_rsv() to drivers/of/fdt.c - Moved ima_dump_measurement_list() and ima_add_kexec_buffer() back to security/integrity/ima/ima_kexec.c v7: - Renamed remove_ima_buffer() to remove_ima_kexec_buffer() and moved this function definition to kernel. - Moved delete_fdt_mem_rsv() definition to kernel - Moved ima_dump_measurement_list() and ima_add_kexec_buffer() to a new file namely ima_kexec_fdt.c in IMA v6: - Remove any existing FDT_PROP_IMA_KEXEC_BUFFER property in the device tree and also its corresponding memory reservation in the currently running kernel. - Moved the function remove_ima_buffer() defined for powerpc to IMA and renamed the function to ima_remove_kexec_buffer(). Also, moved delete_fdt_mem_rsv() from powerpc to IMA. v5: - Merged get_addr_size_cells() and do_get_kexec_buffer() into a single function when moving the arch independent code from powerpc to IMA - Reverted the change to use FDT functions in powerpc code and added back the original code in get_addr_size_cells() and do_get_kexec_buffer() for powerpc. - Added fdt_add_mem_rsv() for ARM64 to reserve the memory for the IMA log buffer during kexec. - Fixed the warning reported by kernel test bot for ARM64 arch_ima_add_kexec_buffer() - moved this function to a new file namely arch/arm64/kernel/ima_kexec.c v4: - Submitting the patch series on behalf of the original author Prakhar Srivastava <prsriva@linux.microsoft.com> - Moved FDT_PROP_IMA_KEXEC_BUFFER ("linux,ima-kexec-buffer") to libfdt.h so that it can be shared by multiple platforms. v3: Breakup patches further into separate patches. - Refactoring non architecture specific code out of powerpc - Update powerpc related code to use fdt functions - Update IMA buffer read related code to use of functions - Add support to store the memory information of the IMA measurement logs to be carried forward. - Update the property strings to align with documented nodes https://github.com/devicetree-org/dt-schema/pull/46 v2: Break patches into separate patches. - Powerpc related Refactoring - Updating the docuemntation for chosen node - Updating arm64 to support IMA buffer pass v1: Refactoring carrying over IMA measuremnet logs over Kexec. This patch moves the non-architecture specific code out of powerpc and adds to security/ima.(Suggested by Thiago) Add Documentation regarding the ima-kexec-buffer node in the chosen node documentation v0: Add a layer of abstraction to use the memory reserved by device tree for ima buffer pass. Add support for ima buffer pass using reserved memory for arm64 kexec. Update the arch sepcific code path in kexec file load to store the ima buffer in the reserved memory. The same reserved memory is read on kexec or cold boot. Lakshmi Ramasubramanian (6): ima: Move arch_ima_add_kexec_buffer() to ima powerpc: Move arch independent ima kexec functions to drivers/of/kexec.c kexec: Use fdt_appendprop_addrrange() to add ima buffer to FDT powerpc: Delete unused functions arm64: Free DTB buffer if fdt_open_into() fails arm64: Add IMA log information in kimage used for kexec arch/arm64/Kconfig | 1 + arch/arm64/include/asm/kexec.h | 5 + arch/arm64/kernel/machine_kexec_file.c | 4 +- arch/powerpc/Kconfig | 2 +- arch/powerpc/include/asm/ima.h | 30 ---- arch/powerpc/include/asm/kexec.h | 4 - arch/powerpc/kexec/Makefile | 7 - arch/powerpc/kexec/file_load.c | 67 -------- arch/powerpc/kexec/file_load_64.c | 4 +- arch/powerpc/kexec/ima.c | 219 ------------------------- drivers/of/kexec.c | 193 ++++++++++++++++++++++ include/linux/of.h | 2 + security/integrity/ima/ima.h | 4 - security/integrity/ima/ima_kexec.c | 22 +++ 14 files changed, 230 insertions(+), 334 deletions(-) delete mode 100644 arch/powerpc/include/asm/ima.h delete mode 100644 arch/powerpc/kexec/ima.c