mbox series

[v2,0/4] clk: qcom : add sm8250 LPASS GFM drivers

Message ID 20200925103115.15191-1-srinivas.kandagatla@linaro.org
Headers show
Series clk: qcom : add sm8250 LPASS GFM drivers | expand

Message

Srinivas Kandagatla Sept. 25, 2020, 10:31 a.m. UTC 
This patchset adds support for GFM Muxes found in LPASS
(Low Power Audio SubSystem) IP in Audio Clock Controller
and Always ON clock controller.

Clocks derived from these muxes are consumed by LPASS Digital Codec.
Currently the driver for Audio and Always ON clock controller only
supports GFM Muxes, however it should be easy to add more clock
support when required

Changes since v1:
 -removed unnecessary Kconfig dependencies
 - cleaned up header includes.
 - moved to using pm_clk
 - Moved to right place in Makefile
 - moved to use module_platform_driver instead of builtin_platform_driver
 - add null check for of_device_get_match_data 

verified dt_binding_check to pass on linux next https://paste.ubuntu.com/p/6nVzjRwvsW/


Srinivas Kandagatla (4):
  dt-bindings: clock: Add support for LPASS Audio Clock Controller
  dt-bindings: clock: Add support for LPASS Always ON Controller
  clk: qcom: Add support to LPASS AUDIO_CC Glitch Free Mux clocks
  clk: qcom: Add support to LPASS AON_CC Glitch Free Mux clocks

 .../bindings/clock/qcom,aoncc-sm8250.yaml     |  58 ++++
 .../bindings/clock/qcom,audiocc-sm8250.yaml   |  58 ++++
 drivers/clk/qcom/Kconfig                      |   6 +
 drivers/clk/qcom/Makefile                     |   1 +
 drivers/clk/qcom/lpass-gfm-sm8250.c           | 323 ++++++++++++++++++
 .../clock/qcom,sm8250-lpass-aoncc.h           |  11 +
 .../clock/qcom,sm8250-lpass-audiocc.h         |  13 +
 7 files changed, 470 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,aoncc-sm8250.yaml
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,audiocc-sm8250.yaml
 create mode 100644 drivers/clk/qcom/lpass-gfm-sm8250.c
 create mode 100644 include/dt-bindings/clock/qcom,sm8250-lpass-aoncc.h
 create mode 100644 include/dt-bindings/clock/qcom,sm8250-lpass-audiocc.h

-- 
2.21.0

Comments

Rob Herring Sept. 28, 2020, 5:26 p.m. UTC | #1 
On Fri, 25 Sep 2020 11:31:13 +0100, Srinivas Kandagatla wrote:
> Always ON Clock controller is a block inside LPASS which controls

> 1 Glitch free muxes to LPASS codec Macros.

> 

> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> ---

>  .../bindings/clock/qcom,aoncc-sm8250.yaml     | 58 +++++++++++++++++++

>  .../clock/qcom,sm8250-lpass-aoncc.h           | 11 ++++

>  2 files changed, 69 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,aoncc-sm8250.yaml

>  create mode 100644 include/dt-bindings/clock/qcom,sm8250-lpass-aoncc.h

> 



My bot found errors running 'make dt_binding_check' on your patch:

Error: Documentation/devicetree/bindings/clock/qcom,aoncc-sm8250.example.dts:25.30-31 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:342: Documentation/devicetree/bindings/clock/qcom,aoncc-sm8250.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1366: dt_binding_check] Error 2


See https://patchwork.ozlabs.org/patch/1371159

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.
Stephen Boyd Oct. 14, 2020, 1:45 a.m. UTC | #2 
Quoting Srinivas Kandagatla (2020-09-25 03:31:11)
> This patchset adds support for GFM Muxes found in LPASS

> (Low Power Audio SubSystem) IP in Audio Clock Controller

> and Always ON clock controller.

> 

> Clocks derived from these muxes are consumed by LPASS Digital Codec.

> Currently the driver for Audio and Always ON clock controller only

> supports GFM Muxes, however it should be easy to add more clock

> support when required

> 

> Changes since v1:

>  -removed unnecessary Kconfig dependencies

>  - cleaned up header includes.

>  - moved to using pm_clk

>  - Moved to right place in Makefile

>  - moved to use module_platform_driver instead of builtin_platform_driver

>  - add null check for of_device_get_match_data 

> 

> verified dt_binding_check to pass on linux next https://paste.ubuntu.com/p/6nVzjRwvsW/


Rob's bot complained again. Can you run with

  make DT_SCHEMA_FILES=<path to schema file.yaml> dt_binding_check

and make sure the schema is up to date?