| Message ID | 20200708131424.18729-1-masahisa.kojima@linaro.org |
|---|---|
| Headers | show |
| Series | synquacer: add TPM support | expand |
On Wed, Jul 08, 2020 at 10:14:22PM +0900, Masahisa Kojima wrote: > This adds support for driving the TPM on Socionext SynQuacer platform > using the driver for a memory mapped TIS frame. > > v3: > - prepare new module to handle TPM MMIO access on SynQuacer platform > > v2: > - don't use read/write_bytes() to implement read/write16/32 since that uses > the wrong address > > Cc: jarkko.sakkinen@linux.intel.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: ardb@kernel.org > Cc: devicetree@vger.kernel.org > Cc: linux-integrity@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: peterhuewe@gmx.de > Cc: jgg@ziepe.ca > > Masahisa Kojima (2): > tpm: tis: add support for MMIO TPM on SynQuacer > dt-bindings: Add SynQucer TPM MMIO as a trivial device > > .../devicetree/bindings/trivial-devices.yaml | 2 + > drivers/char/tpm/Kconfig | 12 ++ > drivers/char/tpm/Makefile | 1 + > drivers/char/tpm/tpm_tis_synquacer.c | 196 ++++++++++++++++++ > 4 files changed, 211 insertions(+) > create mode 100644 drivers/char/tpm/tpm_tis_synquacer.c > > -- > 2.20.1 > Overally the code looks great. You've run it through checkpatch.pl? /Jarkko
Hi Jakko, > Overally the code looks great. You've run it through checkpatch.pl? Yes, I have run checkpatch.pl and removed errors. Regards, Masahisa On Thu, 9 Jul 2020 at 01:20, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote: > > On Wed, Jul 08, 2020 at 10:14:22PM +0900, Masahisa Kojima wrote: > > This adds support for driving the TPM on Socionext SynQuacer platform > > using the driver for a memory mapped TIS frame. > > > > v3: > > - prepare new module to handle TPM MMIO access on SynQuacer platform > > > > v2: > > - don't use read/write_bytes() to implement read/write16/32 since that uses > > the wrong address > > > > Cc: jarkko.sakkinen@linux.intel.com > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: ardb@kernel.org > > Cc: devicetree@vger.kernel.org > > Cc: linux-integrity@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: peterhuewe@gmx.de > > Cc: jgg@ziepe.ca > > > > Masahisa Kojima (2): > > tpm: tis: add support for MMIO TPM on SynQuacer > > dt-bindings: Add SynQucer TPM MMIO as a trivial device > > > > .../devicetree/bindings/trivial-devices.yaml | 2 + > > drivers/char/tpm/Kconfig | 12 ++ > > drivers/char/tpm/Makefile | 1 + > > drivers/char/tpm/tpm_tis_synquacer.c | 196 ++++++++++++++++++ > > 4 files changed, 211 insertions(+) > > create mode 100644 drivers/char/tpm/tpm_tis_synquacer.c > > > > -- > > 2.20.1 > > > > Overally the code looks great. You've run it through checkpatch.pl? > > /Jarkko
Hi Jarkko, > Hi Jakko, I apologize for mis-spelling of your name. Same mistake also appears in my another reply to "[PATCH v3 1/2] tpm: tis: add support for MMIO TPM on SynQuacer" On Thu, 9 Jul 2020 at 08:34, Masahisa Kojima <masahisa.kojima@linaro.org> wrote: > > Hi Jakko, > > > Overally the code looks great. You've run it through checkpatch.pl? > > Yes, I have run checkpatch.pl and removed errors. > > Regards, > Masahisa > > On Thu, 9 Jul 2020 at 01:20, Jarkko Sakkinen > <jarkko.sakkinen@linux.intel.com> wrote: > > > > On Wed, Jul 08, 2020 at 10:14:22PM +0900, Masahisa Kojima wrote: > > > This adds support for driving the TPM on Socionext SynQuacer platform > > > using the driver for a memory mapped TIS frame. > > > > > > v3: > > > - prepare new module to handle TPM MMIO access on SynQuacer platform > > > > > > v2: > > > - don't use read/write_bytes() to implement read/write16/32 since that uses > > > the wrong address > > > > > > Cc: jarkko.sakkinen@linux.intel.com > > > Cc: linux-arm-kernel@lists.infradead.org > > > Cc: ardb@kernel.org > > > Cc: devicetree@vger.kernel.org > > > Cc: linux-integrity@vger.kernel.org > > > Cc: linux-kernel@vger.kernel.org > > > Cc: peterhuewe@gmx.de > > > Cc: jgg@ziepe.ca > > > > > > Masahisa Kojima (2): > > > tpm: tis: add support for MMIO TPM on SynQuacer > > > dt-bindings: Add SynQucer TPM MMIO as a trivial device > > > > > > .../devicetree/bindings/trivial-devices.yaml | 2 + > > > drivers/char/tpm/Kconfig | 12 ++ > > > drivers/char/tpm/Makefile | 1 + > > > drivers/char/tpm/tpm_tis_synquacer.c | 196 ++++++++++++++++++ > > > 4 files changed, 211 insertions(+) > > > create mode 100644 drivers/char/tpm/tpm_tis_synquacer.c > > > > > > -- > > > 2.20.1 > > > > > > > Overally the code looks great. You've run it through checkpatch.pl? > > > > /Jarkko
On Thu, Jul 09, 2020 at 08:34:27AM +0900, Masahisa Kojima wrote: > Hi Jakko, > > > Overally the code looks great. You've run it through checkpatch.pl? > > Yes, I have run checkpatch.pl and removed errors. OK, cool. /Jarkko
On Thu, Jul 09, 2020 at 08:46:35AM +0900, Masahisa Kojima wrote: > Hi Jarkko, > > > Hi Jakko, > I apologize for mis-spelling of your name. > Same mistake also appears in my another reply to "[PATCH v3 1/2] tpm: > tis: add support for MMIO TPM on SynQuacer" No worries :-) /Jarkko