mbox series

[net-next,v3,0/4] net: phy: add Amlogic g12a support

Message ID 20190404131147.31156-1-jbrunet@baylibre.com
Headers show
Series net: phy: add Amlogic g12a support | expand

Message

Jerome Brunet April 4, 2019, 1:11 p.m. UTC 
This patchset adds the necessary bits to support network on the Amlogic
g12a SoC family.

Only the internal PHY and related MDIO mux needed to be addressed.
The GMAC remains compatible with axg SoC family

This series has been tested on the u200 (S905D2) with both the internal
and external (Realtek) PHYs.

Change since v2 [1]:
* Change 'clk part' Reviewed-by as suggested
* Remove default callback from phy drivers
* Use exact match PHY macros
* Default MDIO g12a as module if ARCH_MESON is enabled
* Don't print error on probe defer in the g12a mdio mux

Change since v1 [0]:
* drop '_' from function name unrelated to locking
* fix peripheral clock disable on error
* fix variable declaration reverse Xmas trees
* fix Kconfig dependency on CCF
  (Actually needed for 'struct clk_hw', Thx Andrew !)
* Minor fix in the DT exemple as reported by Rob

[0] https://lkml.kernel.org/r/20190314140135.19184-1-jbrunet@baylibre.com
[1] https://lkml.kernel.org/r/20190329141512.29867-1-jbrunet@baylibre.com

Jerome Brunet (4):
  dt-bindings: net: phy: add g12a mdio mux documentation
  net: phy: add amlogic g12a mdio mux support
  net: phy: meson-gxl: add g12a support
  net: phy: meson-gxl: clean-up gxl variant driver

 .../bindings/net/mdio-mux-meson-g12a.txt      |  48 +++
 drivers/net/phy/Kconfig                       |  11 +
 drivers/net/phy/Makefile                      |   1 +
 drivers/net/phy/mdio-mux-meson-g12a.c         | 380 ++++++++++++++++++
 drivers/net/phy/meson-gxl.c                   |  17 +-
 5 files changed, 453 insertions(+), 4 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/mdio-mux-meson-g12a.txt
 create mode 100644 drivers/net/phy/mdio-mux-meson-g12a.c

-- 
2.20.1

Comments

Florian Fainelli April 4, 2019, 4:33 p.m. UTC | #1 
On 4/4/19 6:11 AM, Jerome Brunet wrote:
> The g12a SoC family uses the type of internal PHY that was used on the

> gxl family. The quirks of gxl family, like the LPA register corruption,

> appear to have been resolved on this new SoC generation.

> 

> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>


Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

-- 
Florian
Florian Fainelli April 4, 2019, 4:33 p.m. UTC | #2 
On 4/4/19 6:11 AM, Jerome Brunet wrote:
> The purpose of this change is to align the gxl and g12a driver

> declaration.

> 

> Like on the g12a variant, remove genphy_aneg_done() from the driver

> declaration as the net phy framework will default to it anyway.

> 

> Also, the gxl phy id should be an exact match as well, so let's change

> this and use the macro provided.

> 

> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>


Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

-- 
Florian
David Miller April 7, 2019, 1:17 a.m. UTC | #3 
From: Jerome Brunet <jbrunet@baylibre.com>

Date: Thu,  4 Apr 2019 15:11:43 +0200

> This patchset adds the necessary bits to support network on the Amlogic

> g12a SoC family.

> 

> Only the internal PHY and related MDIO mux needed to be addressed.

> The GMAC remains compatible with axg SoC family

> 

> This series has been tested on the u200 (S905D2) with both the internal

> and external (Realtek) PHYs.

> 

> Change since v2 [1]:

> * Change 'clk part' Reviewed-by as suggested

> * Remove default callback from phy drivers

> * Use exact match PHY macros

> * Default MDIO g12a as module if ARCH_MESON is enabled

> * Don't print error on probe defer in the g12a mdio mux

> 

> Change since v1 [0]:

> * drop '_' from function name unrelated to locking

> * fix peripheral clock disable on error

> * fix variable declaration reverse Xmas trees

> * fix Kconfig dependency on CCF

>   (Actually needed for 'struct clk_hw', Thx Andrew !)

> * Minor fix in the DT exemple as reported by Rob

> 

> [0] https://lkml.kernel.org/r/20190314140135.19184-1-jbrunet@baylibre.com

> [1] https://lkml.kernel.org/r/20190329141512.29867-1-jbrunet@baylibre.com


Series applied, thanks.