mbox series

[v2,0/4] Add support of STM32 hwspinlock

Message ID 20181108090502.14543-1-benjamin.gaignard@st.com
Headers show
Series Add support of STM32 hwspinlock | expand

Message

Benjamin Gaignard Nov. 8, 2018, 9:04 a.m. UTC 
This serie adds the support of the hardware semaphore block for stm32mp1 SoC.

version 2:
- fix comments done by Bjorn about clock naming, license terms in header,
  alphabetic ordering in Makefile and Kconfig and remove function
- Do not push test module in this version while waiting for feedbacks about it

Benjamin Gaignard (4):
  dt-bindings: hwlock: Document STM32 hwspinlock bindings
  hwspinlock: add STM32 hwspinlock device
  ARM: dts: stm32: Add hwspinlock node for stm32mp157 SoC
  ARM: dts: stm32: enable hwspinlock on stm32mp157c-ed1

 .../bindings/hwlock/st,stm32-hwspinlock.txt        |  23 ++++
 arch/arm/boot/dts/stm32mp157c-ed1.dts              |   4 +
 arch/arm/boot/dts/stm32mp157c.dtsi                 |   9 ++
 drivers/hwspinlock/Kconfig                         |   9 ++
 drivers/hwspinlock/Makefile                        |   1 +
 drivers/hwspinlock/stm32_hwspinlock.c              | 144 +++++++++++++++++++++
 6 files changed, 190 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt
 create mode 100644 drivers/hwspinlock/stm32_hwspinlock.c

-- 
2.15.0

Comments

Alexandre TORGUE Nov. 12, 2018, 8:18 a.m. UTC | #1 
Hi Benjamin

On 11/8/18 10:04 AM, Benjamin Gaignard wrote:
> Add bindings for STM32 hardware spinlock device

> 

> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>

> ---

> version 2 :

> - change clock name from hwspinlock to hsem to be align with hardware

>    documentation

> 

>   .../bindings/hwlock/st,stm32-hwspinlock.txt        | 23 ++++++++++++++++++++++

>   1 file changed, 23 insertions(+)

>   create mode 100644 Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt

> 

> diff --git a/Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt b/Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt

> new file mode 100644

> index 000000000000..6e933b218574

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt

> @@ -0,0 +1,23 @@

> +STM32 Hardware Spinlock Device Binding

> +-------------------------------------

> +

> +Required properties :

> +- compatible : should be "st,stm32-hwspinlock".

> +- reg : the register address of hwspinlock.

> +- #hwlock-cells : hwlock users only use the hwlock id to represent a specific

> +	hwlock, so the number of cells should be <1> here.

> +- clock-names : Must contain "hwspinlock".


"hwspinlock" --> "hsem" ?

> +- clocks : Must contain a phandle entry for the clock in clock-names, see the

> +	common clock bindings.

> +

> +Please look at the generic hwlock binding for usage information for consumers,

> +"Documentation/devicetree/bindings/hwlock/hwlock.txt"

> +

> +Example of hwlock provider:

> +	hwspinlock@4c000000 {

> +		compatible = "st,stm32-hwspinlock";

> +		#hwlock-cells = <1>;

> +		reg = <0x4c000000 0x400>;

> +		clocks = <&rcc HSEM>;

> +		clock-names = "hsem";

> +	};

>