mbox series

[v5,0/9] ata: ahci_platform: support allwinner R40 AHCI

Message ID 20180903100201.23131-1-clabbe.montjoie@gmail.com
Headers show
Series ata: ahci_platform: support allwinner R40 AHCI | expand

Message

Corentin Labbe Sept. 3, 2018, 10:01 a.m. UTC
This patchset add support for allwinner R40 AHCI controller.

The whole patchset is tested on sun8i-r40-bananapi-m2-ultra and
on sun7i-a20-cubieboard2 which doesnt have any of the ressources added
by this serie, so no regression should come with it.

Patchs 1-7 should go via the ata tree
Patchs 8,9 should go via the sunxi tree

Changes since v4:
- dropped PHY dedicated driver
- added the optionnal phy-supply

Changes since v3:
- Moved PHY code to a new sun4i-a10-phy-sata driver
- Removed reset code since ahci_platform support now reset controller.

Changes since V2
- Moved all ressources management to ahci_platform

Corentin Labbe (9):
  dt-bindings: ata: ahci-platform: fix indentation of target-supply
  ata: ahci_platform: add support for AHCI controller regulator
  dt-bindings: ata: ahci-platform: document ahci-supply
  ata: ahci_platform: add support for PHY controller regulator
  dt-bindings: ata: ahci-platform: document phy-supply
  ata: ahci_sunxi: add support for r40
  dt-bindings: ata: update ahci_sunxi bindings
  ARM: dts: sun8i: r40: add sata node
  ARM: dts: sun8i: sun8i-r40-bananapi-m2-ultra: enable AHCI

 .../devicetree/bindings/ata/ahci-platform.txt      |  6 ++-
 arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts  | 18 +++++++++
 arch/arm/boot/dts/sun8i-r40.dtsi                   | 13 ++++++
 drivers/ata/ahci.h                                 |  2 +
 drivers/ata/ahci_sunxi.c                           |  3 +-
 drivers/ata/libahci_platform.c                     | 46 +++++++++++++++++++++-
 6 files changed, 84 insertions(+), 4 deletions(-)

-- 
2.16.4

Comments

Maxime Ripard Sept. 3, 2018, 12:42 p.m. UTC | #1
On Mon, Sep 03, 2018 at 12:01:52PM +0200, Corentin Labbe wrote:
> This patchset add support for allwinner R40 AHCI controller.

> 

> The whole patchset is tested on sun8i-r40-bananapi-m2-ultra and

> on sun7i-a20-cubieboard2 which doesnt have any of the ressources added

> by this serie, so no regression should come with it.

> 

> Patchs 1-7 should go via the ata tree

> Patchs 8,9 should go via the sunxi tree

>


Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>


Thanks!
Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Hans de Goede Sept. 3, 2018, 12:58 p.m. UTC | #2
Hi,

On 03-09-18 14:42, Maxime Ripard wrote:
> On Mon, Sep 03, 2018 at 12:01:52PM +0200, Corentin Labbe wrote:

>> This patchset add support for allwinner R40 AHCI controller.

>>

>> The whole patchset is tested on sun8i-r40-bananapi-m2-ultra and

>> on sun7i-a20-cubieboard2 which doesnt have any of the ressources added

>> by this serie, so no regression should come with it.

>>

>> Patchs 1-7 should go via the ata tree

>> Patchs 8,9 should go via the sunxi tree

>>

> 

> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>


The entire series looks good to me too:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>


Regards,

Hans
Jens Axboe Sept. 3, 2018, 2:26 p.m. UTC | #3
On 9/3/18 4:01 AM, Corentin Labbe wrote:
> This patchset add support for allwinner R40 AHCI controller.

> 

> The whole patchset is tested on sun8i-r40-bananapi-m2-ultra and

> on sun7i-a20-cubieboard2 which doesnt have any of the ressources added

> by this serie, so no regression should come with it.

> 

> Patchs 1-7 should go via the ata tree

> Patchs 8,9 should go via the sunxi tree


Applied 1-7 for 4.20, thanks everyone.

-- 
Jens Axboe
Maxime Ripard Sept. 5, 2018, 7:25 a.m. UTC | #4
On Mon, Sep 03, 2018 at 08:26:22AM -0600, Jens Axboe wrote:
> On 9/3/18 4:01 AM, Corentin Labbe wrote:

> > This patchset add support for allwinner R40 AHCI controller.

> > 

> > The whole patchset is tested on sun8i-r40-bananapi-m2-ultra and

> > on sun7i-a20-cubieboard2 which doesnt have any of the ressources added

> > by this serie, so no regression should come with it.

> > 

> > Patchs 1-7 should go via the ata tree

> > Patchs 8,9 should go via the sunxi tree

> 

> Applied 1-7 for 4.20, thanks everyone.


Applied 8 and 9, thanks!
Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Rob Herring Sept. 10, 2018, 4:25 p.m. UTC | #5
On Mon, Sep 03, 2018 at 12:01:53PM +0200, Corentin Labbe wrote:
> This patch fix the indentation of target-supply's ':'.

> 

> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

> ---

>  Documentation/devicetree/bindings/ata/ahci-platform.txt | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)


Please add acks/reviewed-bys when posting new versions.

Rob
Rob Herring Sept. 10, 2018, 6:18 p.m. UTC | #6
On Mon, Sep 03, 2018 at 12:01:57PM +0200, Corentin Labbe wrote:
> This patch document the new optional phy-supply.

> 

> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

> ---

>  Documentation/devicetree/bindings/ata/ahci-platform.txt | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt

> index f495774c8af9..45b451961612 100644

> --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt

> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt

> @@ -31,6 +31,7 @@ Optional properties:

>  - clocks            : a list of phandle + clock specifier pairs

>  - resets            : a list of phandle + reset specifier pairs

>  - target-supply     : regulator for SATA target power

> +- phy-supply        : regulator for PHY power


This should be mutually exclusive with the phys property. If you have a 
phy node, then its supply belongs there.

>  - phys              : reference to the SATA PHY node

>  - phy-names         : must be "sata-phy"

>  - ahci-supply       : regulator for AHCI controller

> -- 

> 2.16.4

>
Rob Herring Sept. 10, 2018, 6:18 p.m. UTC | #7
On Mon,  3 Sep 2018 12:01:59 +0200, Corentin Labbe wrote:
> This patch update binding with the new R40 compatible.

> 

> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

> ---

>  Documentation/devicetree/bindings/ata/ahci-platform.txt | 2 ++

>  1 file changed, 2 insertions(+)

> 


Reviewed-by: Rob Herring <robh@kernel.org>