| Message ID | 20170922184045.6498-1-clabbe.montjoie@gmail.com |
|---|---|
| Headers | show |
| Series | ARM: dts: sunxi: Fix DT build warnings | expand |
On Sat, Sep 23, 2017 at 2:40 AM, Corentin Labbe <clabbe.montjoie@gmail.com> wrote: > This patch fix the warning "xxx has a unit name, but no reg property" by > removing "@0" from such node. > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi > index 289f2cd06dfe..2e4bae988acd 100644 > --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi > +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi > @@ -322,7 +322,7 @@ > function = "i2c2"; > }; > > - mmc0_pins_a: mmc0@0 { > + mmc0_pins_a: mmc0 { All pinmux nodes should have the suffix "_pins" or "_pin". In the case where there are multiple choices, the node name should convey what or which pingroup the choice is. In this case the name should be "mmc0_pf_pins". > pins = "PF0", "PF1", "PF2", "PF3", > "PF4", "PF5"; > function = "mmc0"; > @@ -330,13 +330,13 @@ > bias-pull-up; > }; > > - mmc0_cd_pin: mmc0_cd_pin@0 { > + mmc0_cd_pin: mmc0_cd_pin { > pins = "PF6"; > function = "gpio_in"; > bias-pull-up; > }; > > - mmc1_pins_a: mmc1@0 { > + mmc1_pins_a: mmc1 { mmc1_pins > pins = "PG0", "PG1", "PG2", "PG3", > "PG4", "PG5"; > function = "mmc1"; > @@ -354,7 +354,7 @@ > bias-pull-up; > }; > > - spdif_tx_pins_a: spdif@0 { > + spdif_tx_pins_a: spdif { spdif_pin > pins = "PA17"; > function = "spdif"; > }; > @@ -369,7 +369,7 @@ > function = "spi1"; > }; > > - uart0_pins_a: uart0@0 { > + uart0_pins_a: uart0 { uart0_pb_pins > pins = "PA4", "PA5"; > function = "uart0"; > }; > @@ -697,7 +697,7 @@ > interrupt-controller; > #interrupt-cells = <3>; > > - ir_pins_a: ir@0 { > + ir_pins_a: ir { ir_pin ChenYu > pins = "PL11"; > function = "s_cir_rx"; > }; > -- > 2.13.5 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Sep 23, 2017 at 2:40 AM, Corentin Labbe <clabbe.montjoie@gmail.com> wrote: > This patch fix the warning "xxx has a unit name, but no reg property" by > removing "@0" from such node > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 662e8b7981b5..b02a8476b0c8 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -347,7 +347,7 @@ > function = "spi1"; > }; > > - uart0_pins_a: uart0@0 { > + uart0_pins_a: uart0 { Same here. This should be uart0_pb_pins. > pins = "PB8", "PB9"; > function = "uart0"; > }; > @@ -571,7 +571,7 @@ > interrupt-controller; > #interrupt-cells = <3>; > > - r_rsb_pins: rsb@0 { > + r_rsb_pins: rsb { And this rsb_pins. ChenYu > pins = "PL0", "PL1"; > function = "s_rsb"; > }; > -- > 2.13.5 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello The goal of this patch series is to have a clean DT build with W=1. Regards Changes since v1: - moved i2c2 unit address change from patch #2 in patch #1 Corentin Labbe (12): ARM: dts: sunxi: h3/h5: Fix simple-bus unit address format error ARM: dts: sunxi: h3/h5: Fix i2c2 register address ARM: dts: sunxi: h3/h5: Fix node with unit name and no reg property ARM: dts: nanopi: Fix node with unit name and no reg property ARM: dts: orangepi2: Fix node with unit name and no reg property ARM: dts: sun8i: orangepi-lite: Fix node with unit name and no reg property ARM: dts: sun8i: orangepi one: Fix node with unit name and no reg property ARM: dts: sun8i: orangepipc: Fix node with unit name and no reg property ARM: dts: sun8i: orangepi-plus: Fix node with unit name and no reg property arm64: allwinner: a64: Fix simple-bus unit address format error arm64: allwinner: a64: Fix node with unit name and no reg property ARM: dts: sun8i: a83t: Fix simple-bus unit address format error arch/arm/boot/dts/sun8i-a83t.dtsi | 6 +- arch/arm/boot/dts/sun8i-h3-nanopi.dtsi | 8 +-- arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 8 +-- arch/arm/boot/dts/sun8i-h3-orangepi-lite.dts | 6 +- arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 6 +- arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 6 +- arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 2 +- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 88 +++++++++++++-------------- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 24 ++++---- 9 files changed, 77 insertions(+), 77 deletions(-) -- 2.13.5 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html