mbox series

[0/7] Add support for IPQ5018 tsens

Message ID 1693250307-8910-1-git-send-email-quic_srichara@quicinc.com
Headers show
Series Add support for IPQ5018 tsens | expand

Message

Sricharan Ramabadhran Aug. 28, 2023, 7:18 p.m. UTC
IPQ5018 has tsens V1.0 IP with 4 sensors and 1 interrupt.
There is no RPM present in the soc to do tsens early enable.
Adding support for the same here.

Sricharan Ramabadhran (7):
  dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible
  thermal/drivers/qcom: Add new feat for soc without rpm
  thermal/drivers/qcom/tsens: Add support for IPQ5018 tsens.
  thermal/drivers/qcom: Add IPQ5018 compatible.
  dt-bindings: nvmem: Add compatible for IPQ5018
  arm64: dts: qcom: ipq5018: Add tsens node
  arm64: dts: qcom: ipq5018: Add thermal zones

 .../bindings/nvmem/qcom,qfprom.yaml           |   1 +
 .../bindings/thermal/qcom-tsens.yaml          |  19 +++
 arch/arm64/boot/dts/qcom/ipq5018.dtsi         |  81 ++++++++++++
 drivers/thermal/qcom/tsens-v1.c               | 115 ++++++++++++++++++
 drivers/thermal/qcom/tsens.c                  |   5 +-
 drivers/thermal/qcom/tsens.h                  |   5 +-
 6 files changed, 224 insertions(+), 2 deletions(-)

Comments

Sricharan Ramabadhran Aug. 29, 2023, 5:59 a.m. UTC | #1
Hi Krzysztof,

On 8/29/2023 12:51 AM, Krzysztof Kozlowski wrote:
> On 28/08/2023 21:18, Sricharan Ramabadhran wrote:
>> IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt.
>>
>> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
>> ---
>>   .../bindings/thermal/qcom-tsens.yaml          | 19 +++++++++++++++++++
>>   1 file changed, 19 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> index 27e9e16e6455..2309bb6dce1b 100644
>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> @@ -42,6 +42,7 @@ properties:
>>                 - qcom,msm8956-tsens
>>                 - qcom,msm8976-tsens
>>                 - qcom,qcs404-tsens
>> +              - qcom,ipq5018-tsens
> 
> This does not look like placed in alphanumeric order.
> 

  ok, will sort.

>>             - const: qcom,tsens-v1
>>   
>>         - description: v2 of TSENS
>> @@ -409,4 +410,22 @@ examples:
>>              #qcom,sensors = <16>;
>>              #thermal-sensor-cells = <1>;
>>       };
>> +
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +    // Example 5 (for any IPQ5018 based SoC-s):
> 
> No need for new example for a difference in compatible. Drop it.

  ok, will drop it.

Regards,
  Sricharan