From patchwork Fri May 14 14:44:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= X-Patchwork-Id: 439072 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13216C433B4 for ; Fri, 14 May 2021 14:45:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC4D36144B for ; Fri, 14 May 2021 14:45:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232831AbhENOqv (ORCPT ); Fri, 14 May 2021 10:46:51 -0400 Received: from uho.ysoft.cz ([81.19.3.130]:33176 "EHLO uho.ysoft.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231473AbhENOqv (ORCPT ); Fri, 14 May 2021 10:46:51 -0400 Received: from vokac-latitude.ysoft.local (unknown [10.0.28.99]) by uho.ysoft.cz (Postfix) with ESMTP id 6B570A097F; Fri, 14 May 2021 16:45:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=20160406-ysoft-com; t=1621003537; bh=7jN/7xr1/TMXqC50FnK2epExUM+7aIneSmkFsdDWCec=; h=From:To:Cc:Subject:Date:From; b=H4QW954ZFk5ecibfXruPNSiuBsXFNCaAC3MS55oRdWnQ5Vn964D4MRUBsKMmKg7j1 00wf5iZE3IiDwBtnJZxE7MvOfpQ/6M0k+KhqU7i3aH8IU+ztFRJgcOuOm1eeeLNUXL iaJrpvdrqGkDkLcuWWVUPmGSB2XBGGmVKsBLr+O0= From: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= To: Pavel Machek , Jacek Anaszewski , Rob Herring , Shawn Guo Cc: Fabio Estevam , devicetree@vger.kernel.org, Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, =?utf-8?b?TWljaGFsIFZva8OhxI0=?= Subject: [RFC 0/2] Regression in lp55xx driver since multicolor framework was added? Date: Fri, 14 May 2021 16:44:35 +0200 Message-Id: <1621003477-11250-1-git-send-email-michal.vokac@ysoft.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, Linux v5.9 and newer fails on our platform that uses the lp5562 LED controller with the following error: lp5562: probe of 1-0030 failed with error -22 The problem exists since introduction of the multicolor framework to the lp55xx driver. It is caused by the lp55xx_parse_logical_led function here [1]. Even if the LED multicolor framework is not enabled the color property is required. But it did not used to be. There are at least two other in-tree platforms that use the same controller and could suffer from this problem. I wonder what is a proper fix here. Either fix the driver to not require the color property (do not know ho to do so) or update the binding and DTs to reflect the real state of the driver (in this series). Thank you in advance for any comments, Michal [1] https://elixir.bootlin.com/linux/v5.13-rc1/source/drivers/leds/leds-lp55xx-common.c#L639 Michal Vokáč (2): dt-bindings: leds: Add color as a required property for lp55xx controller ARM: dts: imx6dl-yapp4: Fix lp5562 driver probe Documentation/devicetree/bindings/leds/leds-lp55xx.yaml | 10 ++++++++++ arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 11 ++++------- 2 files changed, 14 insertions(+), 7 deletions(-)