From patchwork Wed Feb 10 06:43:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sameer Pujar X-Patchwork-Id: 380411 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 912E1C433E0 for ; Wed, 10 Feb 2021 06:44:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6664664E57 for ; Wed, 10 Feb 2021 06:44:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231553AbhBJGoj (ORCPT ); Wed, 10 Feb 2021 01:44:39 -0500 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:13674 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232026AbhBJGog (ORCPT ); Wed, 10 Feb 2021 01:44:36 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 09 Feb 2021 22:43:54 -0800 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 10 Feb 2021 06:43:54 +0000 Received: from audio.nvidia.com (172.20.145.6) by mail.nvidia.com (172.20.187.18) with Microsoft SMTP Server id 15.0.1473.3 via Frontend Transport; Wed, 10 Feb 2021 06:43:50 +0000 From: Sameer Pujar To: , , CC: , , , , , , , Sameer Pujar Subject: [PATCH 0/3] Use clocks property in a device node Date: Wed, 10 Feb 2021 12:13:38 +0530 Message-ID: <1612939421-19900-1-git-send-email-spujar@nvidia.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1612939434; bh=c19W9Oh8pMdfVc6xnFBZ4UqL8XI7169ntNra7yJITRQ=; h=From:To:CC:Subject:Date:Message-ID:X-Mailer:MIME-Version: Content-Type; b=KQA0fRsQR5FGeoZRbP0CMD9srE2MTT59P5vHyOH12W9OWxY46SqyhYO+703E49cFH PQZ+7Avc4joDpvTBGwsaln5yBuQXWXD3OxmUDSo3+k62AjU16b+lRN+WYnsW8tJ9Xq ThCMcCg3ppLDIhACt5bOs9/KaFH2baOljFM+YVoEe7iEHVPa/9wmz3ajddt5sDCPDw Wxk0zlmJUe+AB/TfEMxmVrptATN5c8VB69UNdFLKADFYjsW/qowLBWN0Hy7mFHt+St 9usn+irw4KuJGrLARBTtd9gI2YI929YOLjUIBt0o3FYTB+8A9uyVa7NCVi7EZ4nBKM /UJLLLHpxQI3w== Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org It is recommended to not specifiy clocks property in an endpoint subnode. This series moves clocks to device node. However after moving the clocks to device node, the audio playback or capture fails. The specified clock is not actually getting enabled and hence the failure is seen. There seems to be a bug in simple-card-utils.c where clock handle is not assigned when parsing clocks from device node. Fix the same and revert original change which actually added clocks property in endpoint subnode. Also update Jetson AGX Xavier DT where the usage is found. Sameer Pujar (3): ASoC: simple-card-utils: Fix device module clock Revert "ASoC: audio-graph-card: Add clocks property to endpoint node" arm64: tegra: Move clocks from RT5658 endpoint to device node .../devicetree/bindings/sound/audio-graph-port.yaml | 3 --- arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 2 +- sound/soc/generic/simple-card-utils.c | 13 ++++++------- 3 files changed, 7 insertions(+), 11 deletions(-)