From patchwork Wed May 14 05:00:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bharat Bhushan X-Patchwork-Id: 889977 Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D97DF2940B; Wed, 14 May 2025 05:00:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.156.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747198849; cv=none; b=FpgLaTxVEw/AoLLpHZwttLrF6Dx4eo1c0vaLvatnsVZLLuM5F76W17020sU19fvyt4wlpyTuWOGNoNjqPZYhEJ/l9GDAUy5Viu7yiu3zKsSh4tfoIfxrQlE5pKbv66N3dElzyvB7NWkBrOytjCFTtNTE22UAEaGee3M0O3TsfHI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747198849; c=relaxed/simple; bh=czjazmFYUiok/yL9SSrhyqGeSrUqieqiCLgQIhFaOuk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MDVPlE7gJYfIQYjhNVVz2QZLutEAN+9MN4nXvMWR+oAXL2p5TsZFWjxZ5FboEadLfCpuwpizk31rNJbjPW83ipbpi75d8WTZir0Ph1ZtNAG3t+QtrYZAiIfbCa1uc9DuHIoM1xYCJzT+eOi6tm/0zk15xM1TFPidduEThtNtMbs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com; spf=pass smtp.mailfrom=marvell.com; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b=cD3MzJw6; arc=none smtp.client-ip=67.231.156.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marvell.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="cD3MzJw6" Received: from pps.filterd (m0431383.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54DNTZK1018273; Tue, 13 May 2025 22:00:32 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=1 iRQpEgL7o9TFw08szdan6sVYDSiqeDOutFpf9FuMdU=; b=cD3MzJw6h1rhHE2Gp m1CWbi1fROK4tLMXtTdpH0E4AXr71UG9NHW9zhyKu4GqtTkJd5dvoZgSyGV2IVgu 3+YfkFCTXcKKfagGzcCHrNIxbTxptbRUGCDnVQ/jHJlzij81dXHmxbI0kxoA0GQP gznKdmDOiImPtZN6e+cJCubkmcMn8ORbnv6rVpRAzizkOBMKO4f5IyclAZ1imgUD m4GYP+yJHadWq5Iyz+hzWgrDSy1zkK8wovCDY+Pr4axIuuwCd7BLT+VJfwOADA24 cHtE9qHVge8UdALe3wp3pidav1ZFONOXShVcIruTF9+6iXEU2vvxxenCqdYE7F5x YcAVw== Received: from dc6wp-exch02.marvell.com ([4.21.29.225]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 46mft50gbc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 May 2025 22:00:32 -0700 (PDT) Received: from DC6WP-EXCH02.marvell.com (10.76.176.209) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 13 May 2025 22:00:31 -0700 Received: from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Tue, 13 May 2025 22:00:31 -0700 Received: from bharat-OptiPlex-Tower-Plus-7020.. (unknown [10.28.34.254]) by maili.marvell.com (Postfix) with ESMTP id 9FAF05B693B; Tue, 13 May 2025 22:00:27 -0700 (PDT) From: Bharat Bhushan To: , , , , , , , , , CC: Bharat Bhushan Subject: [PATCH 1/4] crypto: octeontx2: add timeout for load_fvc completion poll Date: Wed, 14 May 2025 10:30:17 +0530 Message-ID: <20250514050020.3165262-2-bbhushan2@marvell.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250514050020.3165262-1-bbhushan2@marvell.com> References: <20250514050020.3165262-1-bbhushan2@marvell.com> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: F2bswjTqJs5g3P17DAvFYSa4iA3Uet9E X-Authority-Analysis: v=2.4 cv=VITdn8PX c=1 sm=1 tr=0 ts=68242370 cx=c_pps a=gIfcoYsirJbf48DBMSPrZA==:117 a=gIfcoYsirJbf48DBMSPrZA==:17 a=dt9VzEwgFbYA:10 a=M5GUcnROAAAA:8 a=dP9LQboaRqI6G61vZ2MA:9 a=OBjm3rFKGHvpk9ecZwUJ:22 X-Proofpoint-GUID: F2bswjTqJs5g3P17DAvFYSa4iA3Uet9E X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTE0MDA0MiBTYWx0ZWRfX3mrEQtz9q9Fh 8ATj4o0KNMxIe6vIi7Cxlm3w6bUn0IT4eF2cb1uwz9USm6toEletOvHTlMHXqMeDconupzbWwZi mQSBEgUjnfbmSI5QIw+5y0/URprjjJ2kH6ODqtltydSyB2Hey0DUfp7xBClfx2L6qSfgvbG8P0w SLPz14Xp8mBFTFsAJVNe8FeOMX41TLPthuXYTaCRHoPU98jUg15Jt5eL8JYiiNvHaglKUB2vHAR w7ppEKdv9qhfAgEo1uv3NpMDJkT++5I6Df9ZFBMJvTWmQ/EcdrBo4c+iNdXtf2aKWTq1Xzb2se8 r/rYhYIs4VAkQUB1D5ynqdGAGW4kq/HKbtzdknlD6UyuPBVrFOb2mbmUqqrPAhsnZQDswp6qOt2 ltl7SInA2xNepMErd0U1xZQPmx5D/inkA7AB3VizDMGzwGL1Qq/+QfrKJdYafMxd1t/PUV28 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-14_01,2025-05-09_01,2025-02-21_01 Adds timeout to exit from possible infinite loop, which polls on CPT instruction(load_fvc) completion. Signed-off-by: Srujana Challa Signed-off-by: Bharat Bhushan --- .../crypto/marvell/octeontx2/otx2_cptpf_ucode.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c b/drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c index 42c5484ce66a..3a818ac89295 100644 --- a/drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c +++ b/drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c @@ -1494,6 +1494,7 @@ int otx2_cpt_discover_eng_capabilities(struct otx2_cptpf_dev *cptpf) dma_addr_t rptr_baddr; struct pci_dev *pdev; u32 len, compl_rlen; + int timeout = 10000; int ret, etype; void *rptr; @@ -1556,16 +1557,27 @@ int otx2_cpt_discover_eng_capabilities(struct otx2_cptpf_dev *cptpf) etype); otx2_cpt_fill_inst(&inst, &iq_cmd, rptr_baddr); lfs->ops->send_cmd(&inst, 1, &cptpf->lfs.lf[0]); + timeout = 10000; while (lfs->ops->cpt_get_compcode(result) == - OTX2_CPT_COMPLETION_CODE_INIT) + OTX2_CPT_COMPLETION_CODE_INIT) { cpu_relax(); + udelay(1); + timeout--; + if (!timeout) { + ret = -ENODEV; + cptpf->is_eng_caps_discovered = false; + dev_warn(&pdev->dev, "Timeout on CPT load_fvc completion poll\n"); + goto error_no_response; + } + } cptpf->eng_caps[etype].u = be64_to_cpup(rptr); } - dma_unmap_single(&pdev->dev, rptr_baddr, len, DMA_BIDIRECTIONAL); cptpf->is_eng_caps_discovered = true; +error_no_response: + dma_unmap_single(&pdev->dev, rptr_baddr, len, DMA_BIDIRECTIONAL); free_result: kfree(result); lf_cleanup: