| Message ID | 20211227183251.132525-2-krzysztof.kozlowski@canonical.com |
|---|---|
| State | Accepted |
| Commit | c92664a9e86265a096e9b66e5154aaed0885a0f2 |
| Headers | show |
| Series | None | expand |
On 28/12/2021 13:54, Rob Herring wrote: > On Mon, 27 Dec 2021 19:32:45 +0100, Krzysztof Kozlowski wrote: >> Convert the Atmel TRNG bindings to DT schema. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >> --- >> .../bindings/rng/atmel,at91-trng.yaml | 46 +++++++++++++++++++ >> .../devicetree/bindings/rng/atmel-trng.txt | 16 ------- >> 2 files changed, 46 insertions(+), 16 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/rng/atmel,at91-trng.yaml >> delete mode 100644 Documentation/devicetree/bindings/rng/atmel-trng.txt >> > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1573492 > > > rng@e2010000: compatible:0: 'microchip,sama7g5-trng' is not one of ['atmel,at91sam9g45-trng', 'microchip,sam9x60-trng'] > arch/arm/boot/dts/at91-sama7g5ek.dt.yaml > > rng@e2010000: compatible: Additional items are not allowed ('atmel,at91sam9g45-trng' was unexpected) > arch/arm/boot/dts/at91-sama7g5ek.dt.yaml > > rng@e2010000: compatible: ['microchip,sama7g5-trng', 'atmel,at91sam9g45-trng'] is too long > arch/arm/boot/dts/at91-sama7g5ek.dt.yaml > This patch is only converting the existing bindings, so new compatible is not added. The issue reported here is being fixed in the next patch (3/8). Best regards, Krzysztof
On 28/12/2021 at 14:07, Krzysztof Kozlowski wrote: > On 28/12/2021 13:54, Rob Herring wrote: >> On Mon, 27 Dec 2021 19:32:45 +0100, Krzysztof Kozlowski wrote: >>> Convert the Atmel TRNG bindings to DT schema. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >>> --- >>> .../bindings/rng/atmel,at91-trng.yaml | 46 +++++++++++++++++++ >>> .../devicetree/bindings/rng/atmel-trng.txt | 16 ------- >>> 2 files changed, 46 insertions(+), 16 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/rng/atmel,at91-trng.yaml >>> delete mode 100644 Documentation/devicetree/bindings/rng/atmel-trng.txt >>> >> >> Running 'make dtbs_check' with the schema in this patch gives the >> following warnings. Consider if they are expected or the schema is >> incorrect. These may not be new warnings. >> >> Note that it is not yet a requirement to have 0 warnings for dtbs_check. >> This will change in the future. >> >> Full log is available here: https://patchwork.ozlabs.org/patch/1573492 >> >> >> rng@e2010000: compatible:0: 'microchip,sama7g5-trng' is not one of ['atmel,at91sam9g45-trng', 'microchip,sam9x60-trng'] >> arch/arm/boot/dts/at91-sama7g5ek.dt.yaml >> >> rng@e2010000: compatible: Additional items are not allowed ('atmel,at91sam9g45-trng' was unexpected) >> arch/arm/boot/dts/at91-sama7g5ek.dt.yaml >> >> rng@e2010000: compatible: ['microchip,sama7g5-trng', 'atmel,at91sam9g45-trng'] is too long >> arch/arm/boot/dts/at91-sama7g5ek.dt.yaml >> > > This patch is only converting the existing bindings, so new compatible > is not added. The issue reported here is being fixed in the next patch > (3/8). Thanks Krzysztof! Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Best regards, Nicolas
diff --git a/Documentation/devicetree/bindings/rng/atmel,at91-trng.yaml b/Documentation/devicetree/bindings/rng/atmel,at91-trng.yaml new file mode 100644 index 000000000000..0324e863dab8 --- /dev/null +++ b/Documentation/devicetree/bindings/rng/atmel,at91-trng.yaml @@ -0,0 +1,46 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rng/atmel,at91-trng.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Atmel AT91 True Random Number Generator + +maintainers: + - Nicolas Ferre <nicolas.ferre@microchip.com> + - Alexandre Belloni <alexandre.belloni@bootlin.com> + - Ludovic Desroches <ludovic.desroches@microchip.com> + +properties: + compatible: + enum: + - atmel,at91sam9g45-trng + - microchip,sam9x60-trng + + clocks: + maxItems: 1 + + interrupts: + maxItems: 1 + + reg: + maxItems: 1 + +required: + - compatible + - clocks + - interrupts + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + + rng@fffcc000 { + compatible = "atmel,at91sam9g45-trng"; + reg = <0xfffcc000 0x4000>; + interrupts = <6 IRQ_TYPE_LEVEL_HIGH 0>; + clocks = <&trng_clk>; + }; diff --git a/Documentation/devicetree/bindings/rng/atmel-trng.txt b/Documentation/devicetree/bindings/rng/atmel-trng.txt deleted file mode 100644 index 3900ee4f3532..000000000000 --- a/Documentation/devicetree/bindings/rng/atmel-trng.txt +++ /dev/null @@ -1,16 +0,0 @@ -Atmel TRNG (True Random Number Generator) block - -Required properties: -- compatible : Should be "atmel,at91sam9g45-trng" or "microchip,sam9x60-trng" -- reg : Offset and length of the register set of this block -- interrupts : the interrupt number for the TRNG block -- clocks: should contain the TRNG clk source - -Example: - -trng@fffcc000 { - compatible = "atmel,at91sam9g45-trng"; - reg = <0xfffcc000 0x4000>; - interrupts = <6 IRQ_TYPE_LEVEL_HIGH 0>; - clocks = <&trng_clk>; -};
Convert the Atmel TRNG bindings to DT schema. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- .../bindings/rng/atmel,at91-trng.yaml | 46 +++++++++++++++++++ .../devicetree/bindings/rng/atmel-trng.txt | 16 ------- 2 files changed, 46 insertions(+), 16 deletions(-) create mode 100644 Documentation/devicetree/bindings/rng/atmel,at91-trng.yaml delete mode 100644 Documentation/devicetree/bindings/rng/atmel-trng.txt