| Message ID | 20210304073308.25906-2-noltari@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v5,1/2] dt-bindings: rng: bcm2835: document reset support | expand |
Sorry Alvaro I missed you sent a v5 already. See my comments in v3. Regards, Nicolas On Thu, 2021-03-04 at 08:33 +0100, Álvaro Fernández Rojas wrote: > Some devices may need to perform a reset before using the RNG, such as the > BCM6368. > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> > --- > v5: no changes. > v4: pass dt_binding_check. > v3: make resets required if brcm,bcm6368-rng. > v2: document reset support. > > .../devicetree/bindings/rng/brcm,bcm2835.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml b/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml > index c147900f9041..11c23e1f6988 100644 > --- a/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml > +++ b/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml > @@ -37,6 +37,21 @@ required: > > > additionalProperties: false > > > +if: > + properties: > + compatible: > + enum: > + - brcm,bcm6368-rng > +then: > + properties: > + resets: > + maxItems: 1 > + required: > + - resets > +else: > + properties: > + resets: false > + > examples: > - | > rng@7e104000 { > @@ -58,4 +73,6 @@ examples: > > > clocks = <&periph_clk 18>; > clock-names = "ipsec"; > + > + resets = <&periph_rst 4>; > };
On Thu, 04 Mar 2021 08:33:07 +0100, Álvaro Fernández Rojas wrote: > Some devices may need to perform a reset before using the RNG, such as the > BCM6368. > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> > --- > v5: no changes. > v4: pass dt_binding_check. > v3: make resets required if brcm,bcm6368-rng. > v2: document reset support. > > .../devicetree/bindings/rng/brcm,bcm2835.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rng/brcm,bcm2835.example.dt.yaml: rng@10004180: 'resets' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml See https://patchwork.ozlabs.org/patch/1447144 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml b/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml index c147900f9041..11c23e1f6988 100644 --- a/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml +++ b/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml @@ -37,6 +37,21 @@ required: additionalProperties: false +if: + properties: + compatible: + enum: + - brcm,bcm6368-rng +then: + properties: + resets: + maxItems: 1 + required: + - resets +else: + properties: + resets: false + examples: - | rng@7e104000 { @@ -58,4 +73,6 @@ examples: clocks = <&periph_clk 18>; clock-names = "ipsec"; + + resets = <&periph_rst 4>; };
Some devices may need to perform a reset before using the RNG, such as the BCM6368. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> --- v5: no changes. v4: pass dt_binding_check. v3: make resets required if brcm,bcm6368-rng. v2: document reset support. .../devicetree/bindings/rng/brcm,bcm2835.yaml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)