From patchwork Wed Feb 3 14:33:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thara Gopinath X-Patchwork-Id: 375424 Delivered-To: patch@linaro.org Received: by 2002:a02:b18a:0:0:0:0:0 with SMTP id t10csp391262jah; Wed, 3 Feb 2021 06:38:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJz8evsGYnRj7h8ioIByVfjuz44dttZKmCSy6b+tHYNm+061S9inD4i+MdaXGasqRuQk88Me X-Received: by 2002:a05:6402:5206:: with SMTP id s6mr3197412edd.92.1612363119533; Wed, 03 Feb 2021 06:38:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612363119; cv=none; d=google.com; s=arc-20160816; b=Tuz0ZXki1eaxph2frA0z3+AXQnxRIsITcXP6HnmPvVEMd5h2AH6kXBtnV1P4C4UY87 uhaZDtJBG5pXEU1ZJCjpx7A5lyRfkexzcj5xymjBcpM3eMW9cqNsLQIAIHLo4zFoQlpT 54EvPALsOgVghLB0A5o4mWPCSGi/2YBzkLNyD72ZX7aoVTRZf5neQgG0fN1f9G6NhE5Y uBjDKeiLO5S9XIycpzLezbqTDdP+K2+2tlDREx9h8vMaumKTPEAYwKenwGyebljeioEK NwG8RIMK74gWbbijvQsKUIvxyEvspagcKgUp/2+Ztj0An5UWUWUmmD04ssIMhvJZO4QG BYrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fbaPzVOJqVBKum7B5yoNy4q+qHm6B45n0RkRe3mNDrc=; b=YFWM2zrywwE+It6ftOWliiBTZ+3RjB0Yjvmov2OELtg3gkGu7z/zAftRUckJDeXmRM ujX3uHvWtpXM2lvAemNH5fwa2qYiZeixPk3UuPpMprZTVB77tcL7ggkMu6Mt1pl7SyUe /QEbZ4IrZdO7ZZjqaa3X1tojvC/VNR1RF2X4AsSIHkoAE/jhWHl1YYz8mO0T18+2YNFr NgslxePrV3cQH8aFc7dc6Fr36gqKAphar1pD2vsXV6QgzZ2hFjYguECEfIS5GvRyInGV EWNYt79AUhvLCA/y8Q0IFfkSxLpN16SUwHlra1d+0OgDYeliIy+MQVZ9snLqFszlMdtE tetg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QyusuCpE; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f12si1438560ejx.333.2021.02.03.06.38.39; Wed, 03 Feb 2021 06:38:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QyusuCpE; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233026AbhBCOiP (ORCPT + 2 others); Wed, 3 Feb 2021 09:38:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232888AbhBCOec (ORCPT ); Wed, 3 Feb 2021 09:34:32 -0500 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 135CBC0617A7 for ; Wed, 3 Feb 2021 06:33:15 -0800 (PST) Received: by mail-qt1-x82c.google.com with SMTP id r20so14075819qtm.3 for ; Wed, 03 Feb 2021 06:33:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fbaPzVOJqVBKum7B5yoNy4q+qHm6B45n0RkRe3mNDrc=; b=QyusuCpErLb3kiwVr9cb7mMeO3uuL0Db7UqGjOizoeNDgOIiJ/M0RgYT9/2QInQ5sk mZz0zX/IAcLhwG1US9lLL6FTf4lcACEfU3cfMOTm6JGXT4yZhb+PGp0P4sq27nDVbXyF cUH2bcqdUbycPUSlX5ulcTlp3nHffPGdMMGiwqh+xPy8nObkayALUlIf74etHGX9oXsC eMzBlzkE8NPJeJ3dFNDZzridD/+2DB11X0HMuUlhsY8fFMH+mfJI5XDbBirpoOmmn7XF UF6sSQZJV60jlFHdYilEq9e94moDgIl2nebwBGdOjiG985jACp8OJt/+66cSwB8lrA80 BV1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fbaPzVOJqVBKum7B5yoNy4q+qHm6B45n0RkRe3mNDrc=; b=djRpl0l28wL97u6MmOjUey+o5Y4ZY0hClNhWVHISE365dtvo5hPAq1lQ0X/9I/VJW/ J8Tb7f65GxQSWRh0PF0Nu+bQBvojO5uemsfe/xrJ8fdsPZnkRqfg2z7S8zAaBauFpZpV SfqPR0yniFV9F06HwBh/PA5uJfTVel7npvSjAHuhh05mQxVWkqpYbHs1H7FrqOZXdzbP WDr+Jaozj4yr6W17+4lMKByzJjMYdKcrosP/Ecd125GDbz4ZAWBDqBHMQUNclBzhWygy PrqJxfzwEj3wjm6Hh1xNfTGdV6qOQ0qHqntZkXvga8ADEHVhaQqXi3nvIXU5vSGV3Yrk RsOw== X-Gm-Message-State: AOAM531qz+d8i/ABjTHdfnHicCRutfp7kdiAnGV0rP7DwttuN0vJneJj zI6WX+WcVZ3ZTTqXyQpIf3BMAQ== X-Received: by 2002:ac8:71d0:: with SMTP id i16mr2581739qtp.349.1612362794339; Wed, 03 Feb 2021 06:33:14 -0800 (PST) Received: from pop-os.fios-router.home (pool-71-163-245-5.washdc.fios.verizon.net. [71.163.245.5]) by smtp.googlemail.com with ESMTPSA id v15sm1775433qkv.36.2021.02.03.06.33.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 06:33:13 -0800 (PST) From: Thara Gopinath To: herbert@gondor.apana.org.au, davem@davemloft.net, bjorn.andersson@linaro.org Cc: ebiggers@google.com, ardb@kernel.org, sivaprak@codeaurora.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 05/11] crypto: qce: skcipher: Return error for zero length messages Date: Wed, 3 Feb 2021 09:33:01 -0500 Message-Id: <20210203143307.1351563-6-thara.gopinath@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210203143307.1351563-1-thara.gopinath@linaro.org> References: <20210203143307.1351563-1-thara.gopinath@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Crypto engine BAM dma does not support 0 length data. Return unsupported if zero length messages are passed for transformation. Signed-off-by: Thara Gopinath --- drivers/crypto/qce/skcipher.c | 5 +++++ 1 file changed, 5 insertions(+) -- 2.25.1 diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/qce/skcipher.c index de1f37ed4ee6..331b3c3a5b59 100644 --- a/drivers/crypto/qce/skcipher.c +++ b/drivers/crypto/qce/skcipher.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include @@ -260,6 +261,10 @@ static int qce_skcipher_crypt(struct skcipher_request *req, int encrypt) rctx->flags |= encrypt ? QCE_ENCRYPT : QCE_DECRYPT; keylen = IS_XTS(rctx->flags) ? ctx->enc_keylen >> 1 : ctx->enc_keylen; + /* CE does not handle 0 length messages */ + if (!req->cryptlen) + return -EOPNOTSUPP; + /* qce is hanging when AES-XTS request len > QCE_SECTOR_SIZE and * is not a multiple of it; pass such requests to the fallback */