From patchwork Fri Jan 15 17:17:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jason A. Donenfeld" X-Patchwork-Id: 363656 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp52675jap; Fri, 15 Jan 2021 09:25:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJy9jNMuxEvGSLO0eEwxu7Nlw6JGc+xsQYOOR8G2fK+vGEmpJpP3jW7xSL5+luQk5KGEpVs7 X-Received: by 2002:aa7:d60f:: with SMTP id c15mr532810edr.232.1610731527009; Fri, 15 Jan 2021 09:25:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610731527; cv=none; d=google.com; s=arc-20160816; b=qBNkCpJ2vDe4AH7zPL1WOXujEt1Y7URQFlLa1TT2YCDgyoP3yTMr8aAl5Oceg+AH58 VnN7lK8glohi+xRau+TZ4b3w8cS0zrJl7w9BNYk+SRULwpLEM+/SKHEdUp7d094ecyE+ 4HNmJUinWfPop8svd58oEGniw4zb+xTl7McRT4Vcca+8+hN2Cb1Wam8g7PLhDdbUuoKl ZVnajBfr0S7X+EQWbTJY4LyCMGm+89k902zQfvlv4MCDzZ1MpwpV0pOnuTg/YX535PHr zs57Ywu3GkpFmm1Rphs6fWLNG/kwjaXelx0xhxsZQ1HxGELZBNEweioTgWaycWdpTthk HwYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=4eZmTKsDtQ4th5znNxHnxWkPHqjopS9x6ZgwcAgqd8k=; b=rsWH/67fKMzuGScmD9WBDAdwG/KbxVQa14hYwTXQ0LvjJGycP0XNSH+Jvsx2sM37XY pFF2jWeQSq7lmHhWglzbUjr5iVcU4eh6+Lk8PatesdAkoa+6sAla5lEFTJtCWqOSZZ/c fLQShfB6wXi2C5VXXxJm5i5USEW8kONqFMnGa/0+oGwz/p6APxlETRrFsGFlh3k1oQg9 RW0RPx5H8CYf9B0fUjxlk2g9c9oKcMd/w2ME05IBtFXVnNn2Wq5SKkQfasux2RXLuy0B HaK5glopPPjFkNIDzyTAjmHdoeCFf2OfKbEYbLbu3NiH8cgdDUWYsehNijDTgFxaK9GK FCpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=e+Tsc0li; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bs21si4105769ejb.468.2021.01.15.09.25.26; Fri, 15 Jan 2021 09:25:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=e+Tsc0li; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731677AbhAORZK (ORCPT + 2 others); Fri, 15 Jan 2021 12:25:10 -0500 Received: from mail.zx2c4.com ([167.71.246.149]:60872 "EHLO mail.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729990AbhAORZK (ORCPT ); Fri, 15 Jan 2021 12:25:10 -0500 X-Greylist: delayed 399 seconds by postgrey-1.27 at vger.kernel.org; Fri, 15 Jan 2021 12:25:10 EST DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1610731067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=4eZmTKsDtQ4th5znNxHnxWkPHqjopS9x6ZgwcAgqd8k=; b=e+Tsc0liCxbfPUEKMon9jpvw1fPC+QVHtc4/dJ+/SvN98leZmHLYOOWsLqrNjBwzPG7fq5 2rs88RZuXx8mEDiQf8dUh5cb/RDhSt6OIfszMxwjauNtOoyRSy2Eow/TE2CH6jxw7G+YiF 5NdEzwMtluiPOl800hsOBfhJ9CieG9o= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 19521f95 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 15 Jan 2021 17:17:47 +0000 (UTC) From: "Jason A. Donenfeld" To: linux-crypto@vger.kernel.org, ardb@kernel.org, herbert@gondor.apana.org.au Cc: "Jason A. Donenfeld" , John Donnelly Subject: [PATCH] crypto: lib/chacha20poly1305 - define empty module exit function Date: Fri, 15 Jan 2021 18:17:43 +0100 Message-Id: <20210115171743.1559595-1-Jason@zx2c4.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org With no mod_exit function, users are unable to load the module after use. I'm not aware of any reason why module unloading should be prohibited for this one, so this commit simply adds an empty exit function. Reported-by: John Donnelly Signed-off-by: Jason A. Donenfeld --- lib/crypto/chacha20poly1305.c | 5 +++++ 1 file changed, 5 insertions(+) -- 2.30.0 Acked-by: Ard Biesheuvel diff --git a/lib/crypto/chacha20poly1305.c b/lib/crypto/chacha20poly1305.c index 5850f3b87359..c2fcdb98cc02 100644 --- a/lib/crypto/chacha20poly1305.c +++ b/lib/crypto/chacha20poly1305.c @@ -362,7 +362,12 @@ static int __init mod_init(void) return 0; } +static void __exit mod_exit(void) +{ +} + module_init(mod_init); +module_exit(mod_exit); MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("ChaCha20Poly1305 AEAD construction"); MODULE_AUTHOR("Jason A. Donenfeld ");