From patchwork Thu Aug 22 15:47:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 172032 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1069635ily; Thu, 22 Aug 2019 08:47:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqwh7i5FA0kkegR9VRgX3IfGjfk1rFAqioXQLxpGDoc8itdhz9Xj3h7I5i/4BipXHhTi0jqy X-Received: by 2002:a17:902:8649:: with SMTP id y9mr37328891plt.252.1566488860278; Thu, 22 Aug 2019 08:47:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566488860; cv=none; d=google.com; s=arc-20160816; b=q7lsWS8gkFkx3mLnCS7VOa2FRTNhiCj3Jh33abF2kuhjhpgNwyxRMwFKwFyqBzLU+O bOpMe7eaI6eOXy/hwBRyrE/Vo/FZl6Bs/cD6NDfEt4kyiWq0gFMdCPN1QbswSU7FyBxO QOeyZgLn5QRlAtcQH/WCCeGraNaTB1UXdgP7yERhuRPsd4kPGYDfuZzHwLGCiSLo0NZ9 lP+KFgV6ggEc1s8gNfeDJtjyteD7fFqeV9v9/VVWm3Abc0yx6XNfrkVTosmXxX4DGXUe Fneh8RCEHHXd2RwISIRJzWImzkOe5bvfFVxLRmgUqg8HDuVen71FlarLM5eIGYaZq2CH NcyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=ePEhvI4Ou85as0xCHV2LBgE4jtxI043xEpOM+J7yQmU=; b=JS11CGzW/kCJsAEBI/8y6fM9N4eKb7whMxSceruvtK6anNnmja4HY5owLRMm7xNK6p 8eFXPWv80XlUdBpyFjeFT7/gJlcNLipHNMux4UMUDMu01ZJ8CCpHP/aFUlzA/Vo1W+Jn pJbJ9dFXgUKs0LpUDFl+AUt5Gl1chK4EBXUvZgyLrQNeptiisamsiBgTGpZa/iHkPw3J SyY+yTEFNOTa6kjXXqcQVqWL6o1+HN3PJHCSJHUatmPdRatnSiud8i+/PNh6WiztE1uD z9B6yysEnliXbZgjhZDK3h+O8jSM5p5W+hbvXQfIql1uiZWT+jU0FRKOpsqZtXrA9DmU UgxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NAKrHCFJ; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u9si16904941pgm.167.2019.08.22.08.47.40; Thu, 22 Aug 2019 08:47:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NAKrHCFJ; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387888AbfHVPri (ORCPT + 3 others); Thu, 22 Aug 2019 11:47:38 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:54244 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387880AbfHVPri (ORCPT ); Thu, 22 Aug 2019 11:47:38 -0400 Received: by mail-wm1-f68.google.com with SMTP id 10so6121472wmp.3 for ; Thu, 22 Aug 2019 08:47:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=ePEhvI4Ou85as0xCHV2LBgE4jtxI043xEpOM+J7yQmU=; b=NAKrHCFJmq8WKxoxGP/IRY1YFhYN7z4m+YH8w/gA21gZ44+QyW5djQ+Fkb8KEguhQ5 UZUmxVoot1+faBVGjFdbM2rTTz6NLrBgminmlzDxGXgl+grvpIyx8kkcTLN21cybjAaw k2hXF9320G1s2xOTSFqMjprtVCL7UwE8PwvvalPtFBuztq41tC6urXcFDMqudAyiNip6 jvPMxh6AY16oVhUwSqX0tZT/GP3WIdae07NMKzicBpajyhlA8cIH0Gs3xYilVkVTbRB4 qYwL1j30y70gCMEr9XUU3ysBM7lRSguW41bFtOT2F9pS9U3o1H7wHtsstkQlaRRzwgC4 HgDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ePEhvI4Ou85as0xCHV2LBgE4jtxI043xEpOM+J7yQmU=; b=tKTLPFMK2MDNI/L85JbV0xJt4McdTCcyFsL/wQ0SK6k/Lgfa0ORq1GI8PuMan0cD4O RGOw7apoEYX1pd/kgwgPeGcPWopQZoB+Bzuu7v3aMYs6SB6nZGmbantpWSV1mVsqv2tH GlnwXbiC0eJH2yAH400O+HXS1NhHLeiohSP2Wmt9iC0FauQUFmVSWDD4uqPqzHCEPYsT 9/V9SozrV+aR4jT+nL1j9lLQHMAk4Fk+W0/rmg3LQb5Y5W6H/ypuDpIjlIKLmOxIxAKK ocsrMZIKtNfv4ux/9PSH5J5cmGaZlXPhTegsGpa9NixiobzlbaNvx3HV6xLMHhRPo2Sr qzTQ== X-Gm-Message-State: APjAAAUrglpD1oi3xbGKd2MKpQPi0TyZp1FrbjQ0dVyGTC/OCXMajKu6 BBsLeGRueWeSvTA/sDYBxosEdJktS2VdMw== X-Received: by 2002:a05:600c:24cf:: with SMTP id 15mr7265597wmu.76.1566488856953; Thu, 22 Aug 2019 08:47:36 -0700 (PDT) Received: from localhost.localdomain (adsl-91.109.242.50.tellas.gr. [109.242.50.91]) by smtp.gmail.com with ESMTPSA id e10sm637wrn.33.2019.08.22.08.47.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2019 08:47:36 -0700 (PDT) From: Ard Biesheuvel To: linux-crypto@vger.kernel.org Cc: herbert@gondor.apana.org.au, Ard Biesheuvel , Tom Lendacky , Gary Hook Subject: [PATCH] crypto: ccp - invoke fallback for XTS ciphertext stealing Date: Thu, 22 Aug 2019 18:47:31 +0300 Message-Id: <20190822154731.13301-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org For correctness and compliance with the XTS-AES specification, we are adding support for ciphertext stealing to XTS implementations, even though no use cases are known that will be enabled by this. Since the ccp driver already has a fallback skcipher standby for dealing with input sizes other than [16, 512, 1024, 2048, 4096], just drop the check against the block size. Cc: Tom Lendacky Cc: Gary Hook Signed-off-by: Ard Biesheuvel --- drivers/crypto/ccp/ccp-crypto-aes-xts.c | 3 --- 1 file changed, 3 deletions(-) -- 2.17.1 diff --git a/drivers/crypto/ccp/ccp-crypto-aes-xts.c b/drivers/crypto/ccp/ccp-crypto-aes-xts.c index 783ba75e0618..8e4a531f4f70 100644 --- a/drivers/crypto/ccp/ccp-crypto-aes-xts.c +++ b/drivers/crypto/ccp/ccp-crypto-aes-xts.c @@ -116,9 +116,6 @@ static int ccp_aes_xts_crypt(struct ablkcipher_request *req, if (!ctx->u.aes.key_len) return -EINVAL; - if (req->nbytes & (AES_BLOCK_SIZE - 1)) - return -EINVAL; - if (!req->info) return -EINVAL;