From patchwork Wed Aug 21 14:32:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 171961 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1055350ily; Wed, 21 Aug 2019 07:33:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqydwUi7vsa7o/P/+srgqg1sJiWEU3cVOtGWUmtwaKhzQuyDOd/xvGtRmsVYqyCPNKsGm1+5 X-Received: by 2002:a65:64c5:: with SMTP id t5mr30321473pgv.168.1566397993147; Wed, 21 Aug 2019 07:33:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566397993; cv=none; d=google.com; s=arc-20160816; b=xW08sspWdFD8h3wK06aeqWa/sMQzvXjSH4cqSCpJG4EdJzoU3r+G0dwspnxMRY5uZC nUShZapD+JOOPBGB8BGYHUdnDuk7gylPOmUAaSeASWbdzFzUYPQawzSoY3DOK8QLpl+k JY5YUUQ96Wb1XWj5IfK8O2aYjXgatJB5BUaWKxKYHBMyMwLe7pIYw0Z/VwLsE7851bKW bE2pZ+VXy0ghc3vpmAtdeEpM2Aw8CJQh0aPckMhepqLj0SPkrXw9xQSJDmIokKbQGds6 +pKs/JjUXOl7s6QC83W4HH+C9NYq0CtEuyejP6zCD4w3ckkLLHAdeF/sR4iHQRYllJBN 8cKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=u8SkUbJP7rMNf0OKuHQI1V2U/tlAU0T6PVWrsyU6ges=; b=Z4x3VxKWfDxyuzavMmUSb7pRoVoNEZou+ZX2yiNz3tT45kJU902+FBQkjYo/+EjRrK YsRZEqfXBimftGs6MY3Fs2NtD/dPgD+MkZ7oI5by9QZCWhrVnkP9oJrrtYjFYWVW/+3K Pqs7wDj5T/l7SVh5bff9ckMtNDGWbYN3rKVVUUFtS9KKmpHjH+pLPjh/mZGXPOnPDDU5 ckBJZHnDydU5pqN3WW7el459R1SVXXv5vAg5F+R/t04R8LF+LhVezocESUGla6DuJnB7 XqMJR4vV+eg+5RAzE9Y8h+QwGF74faMyvPNT2MdozwaxwJwmglec2G8qkLfO7TG+rGVP zojA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=agOKtmBy; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j16si15915283pfh.0.2019.08.21.07.33.12; Wed, 21 Aug 2019 07:33:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=agOKtmBy; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728980AbfHUOdM (ORCPT + 3 others); Wed, 21 Aug 2019 10:33:12 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:36526 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728822AbfHUOdM (ORCPT ); Wed, 21 Aug 2019 10:33:12 -0400 Received: by mail-wr1-f67.google.com with SMTP id r3so2277266wrt.3 for ; Wed, 21 Aug 2019 07:33:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=u8SkUbJP7rMNf0OKuHQI1V2U/tlAU0T6PVWrsyU6ges=; b=agOKtmByQmfCXzPEkiehriCi58nAeqL7qeZj/0YiY7LK3xoamzSEPbd2SSrZxSRulu kAVHl25gcca2E3u0rJV0B7ghzDbobQEHdnpPaGnpGry9EdnXOQIyg0pem8VMSOPbTD02 f2vgDT9T3PwWXUsGeRS5rrnZiZX61txuVBm4Oe7w307HfZ8W5fVxCioisG7qIVrIc3i3 vYjat4r5r6ARM7af82GCZFdNpE1Sdyt9XRTY3ISQ3NtKOmYVf5inRglLFloGUr6KjZL4 MH82DfHcvQfMUD074HqlPLOmawL9+vR4EZqsAD7yjz2FgPMKSSMvsxvvI9SCVq9XUBm+ mrDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=u8SkUbJP7rMNf0OKuHQI1V2U/tlAU0T6PVWrsyU6ges=; b=Qy4a6LM49EILb5P1AeA9nj7H2BctgpA0yRt9fP3IiyN8UnzmtakuDWb8g2BV/g8Vuy ilG6maF9VYp2nZdYrP/WEzB0MqOrpe6VZ9zXfodcxJGKPo0y1UnVtYJqVA83pPBjBCRw E8DkkSu6b36W9D7Y8jszOF8YB5wYpBbbGy4w0hwIstFNwRLB5KyI3Ka98yFjR06UP+B3 rtVOcxoG5Wm3NeIhW/JVZUZPTGqSVqMoqJ/HmZUNuA1KBiEYKFUJbvg+Bd0j8wgT4lBA c/vaug1rpufyMFJswoQcoZgDk1zURPBruMIpWcB4u7NhLeeGdthH/ZC8JA6P7B4XfuBZ 8y6g== X-Gm-Message-State: APjAAAVdkbuaQ+qaQtlPoCL4pOfZtyGCi3N4urv4H12FbDXxCIykJgAk c1oRps+81Zul06cgSul7hsTLZSRYmvL7XQ== X-Received: by 2002:adf:ef48:: with SMTP id c8mr255514wrp.103.1566397989579; Wed, 21 Aug 2019 07:33:09 -0700 (PDT) Received: from mba13.lan (adsl-103.109.242.1.tellas.gr. [109.242.1.103]) by smtp.gmail.com with ESMTPSA id 16sm181427wmx.45.2019.08.21.07.33.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Aug 2019 07:33:08 -0700 (PDT) From: Ard Biesheuvel To: linux-crypto@vger.kernel.org Cc: herbert@gondor.apana.org.au, ebiggers@kernel.org, Ard Biesheuvel Subject: [PATCH 06/17] crypto: arm64/aes-neonbs - replace tweak mask literal with composition Date: Wed, 21 Aug 2019 17:32:42 +0300 Message-Id: <20190821143253.30209-7-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190821143253.30209-1-ard.biesheuvel@linaro.org> References: <20190821143253.30209-1-ard.biesheuvel@linaro.org> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Replace the vector load from memory sequence with a simple instruction sequence to compose the tweak vector directly. Signed-off-by: Ard Biesheuvel --- arch/arm64/crypto/aes-neonbs-core.S | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) -- 2.17.1 diff --git a/arch/arm64/crypto/aes-neonbs-core.S b/arch/arm64/crypto/aes-neonbs-core.S index cf10ff8878a3..65982039fa36 100644 --- a/arch/arm64/crypto/aes-neonbs-core.S +++ b/arch/arm64/crypto/aes-neonbs-core.S @@ -730,11 +730,6 @@ ENDPROC(aesbs_cbc_decrypt) eor \out\().16b, \out\().16b, \tmp\().16b .endm - .align 4 -.Lxts_mul_x: -CPU_LE( .quad 1, 0x87 ) -CPU_BE( .quad 0x87, 1 ) - /* * aesbs_xts_encrypt(u8 out[], u8 const in[], u8 const rk[], int rounds, * int blocks, u8 iv[]) @@ -806,7 +801,9 @@ ENDPROC(__xts_crypt8) mov x23, x4 mov x24, x5 -0: ldr q30, .Lxts_mul_x +0: movi v30.2s, #0x1 + movi v25.2s, #0x87 + uzp1 v30.4s, v30.4s, v25.4s ld1 {v25.16b}, [x24] 99: adr x7, \do8