From patchwork Wed Aug 21 14:32:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 171958 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1055247ily; Wed, 21 Aug 2019 07:33:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqzhbvTCfraHgGzOmeVpIoOBZkr4JahhvbpGkFk9EkTKVitaqzFEjy77RT9HH808ogATTDja X-Received: by 2002:a63:f926:: with SMTP id h38mr29259536pgi.80.1566397989017; Wed, 21 Aug 2019 07:33:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566397989; cv=none; d=google.com; s=arc-20160816; b=l+orTMyJsmht0h1QwraKN/4Z3oby9ndcA2r/xPCGij/nlaPDPuRJsKPApljPwHB/s6 f0PJV39Fn1lC5o0WR0EsSQ8DeAb2OBakeZ/Jh40TB2tiDd3atN/45ZRNz7ndFviZOjoC vSdJsnyptJ40uazqvTU8+11lu/+nCjHYYnxDs3euX1julW/Z+9DgeEoNiG1zOgygR6/O 5pdBVUjBQJwvobRCjk19w+VWQa8BYmwEDQRWo5CZXpiR74Ea16Qm1X7CQ32cwbtoL4z2 XJv9Lqcs1OrKU02xqeUUPPDGjkuBM2/Xgy+0wtIHxzxFBhGLxnFAFE22TkYakl17/LUu EuZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=aI11eOfvUHWceFRi+8iF4u67GyVnjyFicxzOIJeHmqs=; b=cn3RzrgD2BxtiemTgiP4x78Q9iElHzMJlMY5WLMN1xijw+VDcGNPeiNRU9fQJ1v62f 60fepTSjBDOJBF8AE17ZopIcidXgMsJ3dyneAHkf2sVhlu3K/D94kkHw+eTYTWV5nV23 gkTV8mSotZsXNn74e1wgBuFUIJlE8t6S6XETClKr3Q7xAvYKA4exGu7HPzo/0P7dz519 hdIAmmm0pk7l6Y06tpS0gpn6Od1SekNWMLuEV7gTpEf/r+pBnRQ5EVMrXmqj9nNA9Jg6 KS3+IuZXa6sIfsqZioa1OwI/B1nCYpoTrdITQ5N+Oau0aSSshvLg49ewZ6i1kPFEzjE3 oqSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ddEZtJwc; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j16si15915283pfh.0.2019.08.21.07.33.08; Wed, 21 Aug 2019 07:33:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ddEZtJwc; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729271AbfHUOdI (ORCPT + 3 others); Wed, 21 Aug 2019 10:33:08 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:43936 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728980AbfHUOdI (ORCPT ); Wed, 21 Aug 2019 10:33:08 -0400 Received: by mail-wr1-f68.google.com with SMTP id y8so2251248wrn.10 for ; Wed, 21 Aug 2019 07:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=aI11eOfvUHWceFRi+8iF4u67GyVnjyFicxzOIJeHmqs=; b=ddEZtJwcsiZncsOlztMjOo2Rph0rOlKCbabKpMj8fxxRifPIZGzpXtAq9jKbNvCmQv lQ+T6aHvHHpbOU4Q/qfnKuQeu9uHBaUm2nVZUdfB9qcd8HqdPpGNQxayvjQtnoZdi4gw AWVHiGxGwGH37pDaL44Rldv5YGrpb+9y4Ecu6fpYcOTKvUDcuOQTxLU1UghkDh0G/B4Z 1v5orHWU2Oy1NBuTXu6XUDFsabccXaKux4OJdB67pSrXEDWzUUV8qFE5nSOeuemlfVzq f79bk06E6gL458kS6RXktd+rV6C+1iqqpK0NxMQS25jqT38WWhYb8pdfllSXUtQhdTzb zeOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=aI11eOfvUHWceFRi+8iF4u67GyVnjyFicxzOIJeHmqs=; b=rmhIcXWMwqT5715U9qtJdPr50sl1O8m6joBJcqpqrRGEFsSsFuMjtu99SheS0AzzRY Yz4hQTG6fka+D7zkMoaw6KhYxZ6yt6x685e3B9SthPnbkDg6xYx48O20/rVCt7s/5Yki g8f9t+2/RDHSsmyDROdzns1vfQZwiwMLLX6IeCQj83ZYR30P9m0IQr17eKawDUQI4JoU 32v0kI6T0MGmWLkRczGvGJpJEre/wOJkBh9EruaGODawMEUEkuOsKWIODx+GsNbDckU5 wy3tU5Q02orYjhu7jPRs8niUf7dXDKJ0klj5nWB6mqECpAHVNF7omHClUOtj/+SVTZ1x NvGA== X-Gm-Message-State: APjAAAVabuRtx+04IJRGMHgdBB37RX/9ezJTeq/pzJ5yKYXOIV0mOFYk dpyhncKkRUwok/ZtsOg9frFwxy+02W6fyg== X-Received: by 2002:adf:d4c6:: with SMTP id w6mr42017542wrk.98.1566397986351; Wed, 21 Aug 2019 07:33:06 -0700 (PDT) Received: from mba13.lan (adsl-103.109.242.1.tellas.gr. [109.242.1.103]) by smtp.gmail.com with ESMTPSA id 16sm181427wmx.45.2019.08.21.07.33.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Aug 2019 07:33:05 -0700 (PDT) From: Ard Biesheuvel To: linux-crypto@vger.kernel.org Cc: herbert@gondor.apana.org.au, ebiggers@kernel.org, Ard Biesheuvel Subject: [PATCH 04/17] crypto: arm/aes-ce - replace tweak mask literal with composition Date: Wed, 21 Aug 2019 17:32:40 +0300 Message-Id: <20190821143253.30209-5-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190821143253.30209-1-ard.biesheuvel@linaro.org> References: <20190821143253.30209-1-ard.biesheuvel@linaro.org> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Replace the vector load from memory sequence with a simple instruction sequence to compose the tweak vector directly. Signed-off-by: Ard Biesheuvel --- arch/arm/crypto/aes-ce-core.S | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) -- 2.17.1 diff --git a/arch/arm/crypto/aes-ce-core.S b/arch/arm/crypto/aes-ce-core.S index a3ca4ac2d7bb..bb6ec1844370 100644 --- a/arch/arm/crypto/aes-ce-core.S +++ b/arch/arm/crypto/aes-ce-core.S @@ -382,13 +382,10 @@ ENDPROC(ce_aes_ctr_encrypt) veor \out, \out, \tmp .endm - .align 3 -.Lxts_mul_x: - .quad 1, 0x87 - ce_aes_xts_init: - vldr d30, .Lxts_mul_x - vldr d31, .Lxts_mul_x + 8 + vmov.i32 d30, #0x87 @ compose tweak mask vector + vmovl.u32 q15, d30 + vshr.u64 d30, d31, #7 ldrd r4, r5, [sp, #16] @ load args ldr r6, [sp, #28]