From patchwork Sun Jan 27 09:16:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 156688 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp2218841jaa; Sun, 27 Jan 2019 01:17:20 -0800 (PST) X-Google-Smtp-Source: ALg8bN4LdCyDZWaP4SKmTuJTw+qa5OxiOqjM/jM572sYxHmufPv/xF2SSYhXEWaL1o//7Cns/kIU X-Received: by 2002:a63:1c61:: with SMTP id c33mr15476977pgm.354.1548580640527; Sun, 27 Jan 2019 01:17:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548580640; cv=none; d=google.com; s=arc-20160816; b=B9FrdCTPrXsiwaQ67Bp1UfQ0SAKSZrmWOTZwcFVXy/V1RMc+DCUGdrSDq4pstrnCcD rgUVruQYQbpOQ44WDNijTvCNx1PnZEQsKqFDXHNXClDt5GvrQOWyPz+JeTLrOS5ldKrZ YO2fpyx3UtsKQ+hTkuWWp172ZsZWpguoasOjOaU4jjWfSnMVxX3LQZGP9cBIFf8nUUY0 wDWtslvybbXY4e2hbCMwYKMnyp8bodatbUtxOts4yLJkr6LcRKb0t53dm8YOK1nK9ZuD sl+ThfW6bBpthDGMBMWcxrfeD7/Ie876fTjRqDfGHzNF+6Fx9L6v+afMFlIvOtwEBjZ3 Aqsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UT69eWfMu3CrrEpHcC7N6bP4fh+2YTgZE2AB6r62TDY=; b=KqmPTSWf4taDH2+mXzBCZOFp2caSgojuCu3nQUMbbuCqnRf4rzLPD70uxMTRxnz3qH dhwQLe5dlMLq68r7jrjhHtECrJulh4HTUXnTnlhmX13myjMJQTfJDBPD4Cs0IHR2ka6R KnI+mu0RNVZ4fkrtDgrkn58a/RcfpCqCrD4gPEiWH06Y7pEiNkqRGavrfXkgdOarUp7a xumHzpxEyYx/fgd91GjOM2+9Xknofws8W7ERM8jII2VvXypTwi8z6Qe7s8VAahWPDXvZ YsYWEKER4+sP6nY/JV8QA0kGrd91ItRC0i2v8BIUjdm8l4sIpZSPD8anEYYpE1yl5F7B q7Gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IeNdexJ3; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q19si1274538pfh.138.2019.01.27.01.17.20; Sun, 27 Jan 2019 01:17:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IeNdexJ3; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726511AbfA0JRT (ORCPT + 3 others); Sun, 27 Jan 2019 04:17:19 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:36510 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726487AbfA0JRT (ORCPT ); Sun, 27 Jan 2019 04:17:19 -0500 Received: by mail-wr1-f68.google.com with SMTP id u4so14621017wrp.3 for ; Sun, 27 Jan 2019 01:17:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UT69eWfMu3CrrEpHcC7N6bP4fh+2YTgZE2AB6r62TDY=; b=IeNdexJ3bUTrMk4sXS7K0+u+EMGHsicTnWcivNUNYMsBQyC5yPbx7ngfpvEX2DOMZS 2bDszTF0BfN1i1/BqJsbs3UGJQSZj6BaOSE4ijRtoAg7gAg63BfZv914388GDT0JiBGW KMe8WOutx6M+EPjiD6sQusFPgxEA1D8LHLxxU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UT69eWfMu3CrrEpHcC7N6bP4fh+2YTgZE2AB6r62TDY=; b=NE0kvc6DpqXAsstYIIX7cgb9EYaaPzIjw0gmoUPMvQUXlFvS2R+OqbFnVYSuGhi65h a8d4ccx1doL8GdmUjV3h5lkaBKEIVvW/xZJczis36onl6Afc4bLCLSo1Hvl9Oml12P06 /WzoNhbIiTlHWVqbsjbR1G2D9BskZ28gS8FO3/Z7OgaFf9hpYF7/VAEppWqKbnE06ih4 idwsY8yFB7oteHHOjvAT9OAUGSQRmdoZbraEPhqJ8kohS+sUWu9w7w5cn12ye+4YHoAJ fRxnk7CUgMAfq+TxANMS6s4txUMhViiynRmW9y+RA3WeLl4tnsI0veioM4QLixMxRk9b CXUQ== X-Gm-Message-State: AJcUukenrYq0dUq9wvlu7O3PUesg0LCi+di/JdR5XRqad6nm3RMiLS0A dxq4dkg8RXtFRkGsKrRD4YX0eUkEsqFDYA== X-Received: by 2002:a5d:664a:: with SMTP id f10mr17358060wrw.311.1548580637102; Sun, 27 Jan 2019 01:17:17 -0800 (PST) Received: from sudo.home ([2a01:cb1d:112:6f00:887d:32e9:9391:d3bf]) by smtp.gmail.com with ESMTPSA id o5sm45397013wrw.46.2019.01.27.01.17.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 27 Jan 2019 01:17:16 -0800 (PST) From: Ard Biesheuvel To: linux-crypto@vger.kernel.org Cc: herbert@gondor.apana.org.au, ebiggers@kernel.org, Ard Biesheuvel Subject: [PATCH v3 3/4] crypto: arm/crct10dif - remove dead code Date: Sun, 27 Jan 2019 10:16:54 +0100 Message-Id: <20190127091655.6262-4-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190127091655.6262-1-ard.biesheuvel@linaro.org> References: <20190127091655.6262-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Remove some code that is no longer called now that we make sure never to invoke the SIMD routine with less that 16 bytes of input. Reviewed-by: Eric Biggers Signed-off-by: Ard Biesheuvel --- arch/arm/crypto/crct10dif-ce-core.S | 13 ------------- 1 file changed, 13 deletions(-) -- 2.20.1 diff --git a/arch/arm/crypto/crct10dif-ce-core.S b/arch/arm/crypto/crct10dif-ce-core.S index 16019b5961e7..d058fad423c2 100644 --- a/arch/arm/crypto/crct10dif-ce-core.S +++ b/arch/arm/crypto/crct10dif-ce-core.S @@ -342,7 +342,6 @@ CPU_LE( vrev64.8 q7, q7 ) cmp arg3, #16 beq _128_done // exactly 16 left - blt _less_than_16_left // now if there is, load the constants vldr d20, rk1 @@ -353,18 +352,6 @@ CPU_LE( vrev64.8 q7, q7 ) addlt arg3, arg3, #16 blt _get_last_two_regs b _16B_reduction_loop - -_less_than_16_left: - // shl r9, 4 - adr ip, tbl_shf_table + 16 - sub ip, ip, arg3 - vld1.8 {q0}, [ip] - vmov.i8 q9, #0x80 - veor.8 q0, q0, q9 - vtbl.8 d18, {d14-d15}, d0 - vtbl.8 d15, {d14-d15}, d1 - vmov d14, d18 - b _128_done ENDPROC(crc_t10dif_pmull) // precomputed constants