From patchwork Tue Sep 12 09:35:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 112257 Delivered-To: patch@linaro.org Received: by 10.140.106.117 with SMTP id d108csp4927147qgf; Tue, 12 Sep 2017 02:36:50 -0700 (PDT) X-Google-Smtp-Source: ADKCNb64s5bN31IhiCmEoWeNlvScuRsJma0X6IYB91tIyIxrGKfKhXJWXAhq5OeBogdlaxUOrRf+ X-Received: by 10.98.147.219 with SMTP id r88mr14335541pfk.0.1505209010596; Tue, 12 Sep 2017 02:36:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505209010; cv=none; d=google.com; s=arc-20160816; b=wf0z2huRfX6eo4E99KHp9eteQoklMF3d0xHM9Aqm46m18+GB4185l4RBUan2k8Ttq0 JMO3fPZIMFNDEOZ8TLbff/wIwvp2zZMdcF77Y3ooPBep0gs5hKxf+yirlnhAynX3Cmw2 hpiAoWtNzokbSBqdlIwtSN3lM8KSizyBa3+6NRn8NaXekN1h46PDVF0rzB+DNummRNyw AiX65Sq1pSCbltiLs5sLzPypMqy6Vvi+y82zGTDtyK7adZUewPEai4JirBhjK15ADkP8 TYE7pavelU8JDsAiWmkBApZoWbx4Eb7IoDZWaBaKlQ/ppiDJGJJYiG9bNpZA/MlpfVRS Egdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=TI9uJh/1elKmSqlY5VYQzCJapTf7PHXZYOfExf2Ns3U=; b=hjCKTsWgGylKwFS/zOmq95koqL5HeZ1Tmov4MayEoyl9mI2YThPa3r3SXI6yFuYF9w nSqIz4jPKc4WTQHfoM5mDdenBJ/vwG3jurGkt3R0KNW6UHoMoWhaO3HrE/MFrlZ2SwvX EY7b0H4QtQYMcsesY2NEN+fjcg6FeLjJy1cne6U+rBORxsaj24pXlE68S9ZG2vpsMSVe /+wzAN8kT1xQFww0k+5VKys6tQjaUFycGIIfa65H8Iaf7rQXgg/7PuXgNWqTfxIduHgJ Q7vDZBd7QHvuVPp5hg3INMq6nu4OBdAMcMrD8HRXMrmQ37xoD9wBX2YtoXONoPhy+qu0 D57g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m21si7349947pgn.782.2017.09.12.02.36.50; Tue, 12 Sep 2017 02:36:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751292AbdILJgt (ORCPT + 1 other); Tue, 12 Sep 2017 05:36:49 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:63893 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751214AbdILJgs (ORCPT ); Tue, 12 Sep 2017 05:36:48 -0400 Received: from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id 0LnjcV-1dEFnX3UkR-00hsps; Tue, 12 Sep 2017 11:36:05 +0200 From: Arnd Bergmann To: Lionel Debieve Cc: Arnd Bergmann , Herbert Xu , "David S. Miller" , Maxime Coquelin , Alexandre Torgue , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] crypto: stm32 - Fix uninitialized data usage Date: Tue, 12 Sep 2017 11:35:38 +0200 Message-Id: <20170912093553.2580986-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:pq236YfxbVNwqj355JlDKkTRo6fzQdnPRprypRxSAhAXZDs/HSc PzTueg773DKir5HcHp29L0K5buZ9E7KIheuWixMVb5TalKHzrHzBigWpkd+Pe2XLRFufmPK E3UO/lsUO3Add5d5O1gOBck0nfBKtMJGZda3g73DtCTs37c0phD+Stq4GG+RixKXf/Ibadd fsyqmFLix8XMOzxqoI3Gw== X-UI-Out-Filterresults: notjunk:1; V01:K0:RppDc2c8SGg=:j+4EbY9dofdT2lEgGa8Tj4 lGmgntTfTEmCLv8q1LMnBX83Lcd6pIWgyoB18uv6MQ7A45ej+ywB8tEr2J2gyZUYXBMEbmlYI 1aa9WvOTLoGqDIZZSXfqMYL0z2cG0Yr5FLjyzuEzwgKg91ZbhaCQxup6OwdOGlw4gZHfbV+lP WdLJ1uOFlwR1ePDanNC/IUk9AsFSdIwsYaG+4a1uZ+c7oMcKKld7GFW8cmRzHNDUQV6yIQNYg ZuZ/81KWxbsV3f/f10BDZY8AiPvpknjJxuigmgNa+qrDVNrrrQfKo8cQZA4DajNwTPEhrL5xC EiB78bTx5Bd+myGlflqcS/QiZ/sVDLMeROu733eJeJoE/GpEfSRNnYj/7ByLvWrb/htPu/p4h IHeZr83mNjtnSsS3x9YArAyv3JCgLaErKiWyK4X7DGwMQBMu6ApaGVnArVpfqlIpGvB3IBkyv DybaZokscVq4YJGCPtWtBBm4HretrVNEGsSewbITCkTzuuRzxSOah3sKPqP+BcKvNtl4pcZ6C 1j6GMy9U9EoyrR/UwB0aI6XGujgRxvRsF08yWdzJoVpENcDbndPRY2YBHpja9sJyXwAGwRxaM VtST/JFIDBkGh7z9PM/BZES3reIhpaUqHk1tX+t0o0GolDTOsoOxhLuy4Ny6AClG7LXVXNT8y Ip3sCYJmeai/zFkbMphigwi3qO9QrBMeSoQ6i2/ulyBMXv32YAGY9rH0jn+LhFDO11oske4Rt bLmxr7ulccDr6Kh8wvkj0GuCGvaBxWaC2NCcJA== Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The error handling in stm32_hash_irq_thread passes uninitialized data into stm32_hash_finish_req, as gcc points out: drivers/crypto/stm32/stm32-hash.c: In function 'stm32_hash_irq_thread': drivers/crypto/stm32/stm32-hash.c:1088:2: error: 'err' may be used uninitialized in this function [-Werror=maybe-uninitialized] I could not tell what data should be passed there instead, so this changes the code to always pass zero, making it well-defined, though possibly still wrong. Please check. Signed-off-by: Arnd Bergmann --- drivers/crypto/stm32/stm32-hash.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.9.0 diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c index b585ce54a802..3c23a23e9ee5 100644 --- a/drivers/crypto/stm32/stm32-hash.c +++ b/drivers/crypto/stm32/stm32-hash.c @@ -1067,7 +1067,6 @@ static int stm32_hash_cra_sha256_init(struct crypto_tfm *tfm) static irqreturn_t stm32_hash_irq_thread(int irq, void *dev_id) { struct stm32_hash_dev *hdev = dev_id; - int err; if (HASH_FLAGS_CPU & hdev->flags) { if (HASH_FLAGS_OUTPUT_READY & hdev->flags) { @@ -1085,7 +1084,7 @@ static irqreturn_t stm32_hash_irq_thread(int irq, void *dev_id) finish: /*Finish current request */ - stm32_hash_finish_req(hdev->req, err); + stm32_hash_finish_req(hdev->req, 0); return IRQ_HANDLED; }