From patchwork Fri May 19 08:04:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 100159 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp197454qge; Fri, 19 May 2017 01:04:20 -0700 (PDT) X-Received: by 10.99.167.75 with SMTP id w11mr8937283pgo.148.1495181060191; Fri, 19 May 2017 01:04:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1495181060; cv=none; d=google.com; s=arc-20160816; b=vfJY3AeajF/S2G+XtgqcRJZSsm35a2wxVOgfnWj2ewf5emZvZNEj+YHL45ZqY1jgDi z/gBxskodnjrSLIjIgUSfQxT0rZ+wSvbG5R1+xkM2ULnpR3DklGLiqUlItF36nMtIpOB JeunBa/d0bEw4QlP8cyGlWA723/4eXeRLwJA2Mbp1pxMu7MH3D3GqBXgak9HRBrUnk2o PeYc2AgV6etagqRgcmqIK3BtbdJca8qfWTK4Uf4uzvK2VBfO7FFu/NfiABxvQ3xBcWEr VpmmeUMmhfvHRE0GXvn0/L2mBE8AnXx0505t3rLh8Cv5Q7FecbMCsyZPJ9EBvtpL4NEP dP2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=y/KTawzyk9zJoZdVbU5sDS3N/QJf1FnZjWT01BeUVC8=; b=dnAcngnAyyTVdqHfZ2oWKtTpp7rSVlWmhrncNzBkLGVNA6TthtM+fLjQd4aabKCY5H L7gS/TB/YZBKtUFYXXNHmlXxdeTo3hpKzel+aCkUXY8I4QTyEa+8qpKtO/cSr3yjSR8j Xvm3ESqIHxGiMU0P9fTgNjuHd725GyUCCu18Eg9QYOGmowyF+au0JYAl8wdi4k6XFX9j /kGPNig6m9ZvWENC5G/fqVGzPnZFMnzQpdAA4+rZVRHkv/i7vfv3q4eMUWVWsJZ+fc4e 9yteWpeAescQZlWupFdCcfTDoAO7+VAqxWfMHz5KONxNoXoNpLZwLazc+p+YBLm6UyjK UFOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u22si7883478plk.91.2017.05.19.01.04.19; Fri, 19 May 2017 01:04:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750892AbdESIES (ORCPT + 1 other); Fri, 19 May 2017 04:04:18 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:55844 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbdESIES (ORCPT ); Fri, 19 May 2017 04:04:18 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0Lv638-1eAZAM1Ole-010Ktt; Fri, 19 May 2017 10:04:12 +0200 From: Arnd Bergmann To: Gilad Ben-Yossef , Greg Kroah-Hartman Cc: Arnd Bergmann , linux-crypto@vger.kernel.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: ccree: add CRYPTO dependency Date: Fri, 19 May 2017 10:04:01 +0200 Message-Id: <20170519080409.1042426-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:g4BpgYd4Kadpn+9zGH6a6dGv/Nz192QPe+xDMLkxIElQVdr8D4a YZi3r7OMMuYu2Z7xXQ0/2CcJmYJAnsciLICafnWS+UsQMO23k/qiBOenPizV33DuO1unTtq R+5HUFzmya3KIANWKC1wqDADBfmonSbkGQyCId7ExDtjPv9vg9mzPbbg+paYUbv7xRbMuOJ rqgKfbx1qSfyEtlr1MnrQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:An2FU2ycrEw=:t7TaQeKqDtXQNDLcFliJZa PIl/NZ9Jppefqlv3ZgvrVh73vPLQJHGqcq5X8PS6T3TZS0W+QHbHLELAhRjZzPHUWprmfM0yx UCoED1iYWqQebs4J/p+ZMouhgol4ovfHG7eCNNsrPOTp+H+i4LdSl6Kuci3uzGU6ChCyTEkdC KvVqkdKmwpK0qRJ8Z8CM0ip4Ou1dbUut8c5zxEKQN0HAJLSXDcM90XwAw9r2B3FlZM7gVzFnj fX4hFt46LXNWeyBRhoSuDwy0Dq4EX/00ybuhWkYoxpO0gWt76aY8UBfxRBbI8yrbR5Imzx5bM 4l7GJGFWMBmoRTz1LiLU0LocxF6yTIzKsYj6z1gOw2db1IyurKcweXD3EL8lLS2e5KJ4pvOPX MZO2ORrJ2Zde7YPOjr+4uHmCghCrSw1i3hIGIs/vQLp6xD0hXL5OJ61w2c4q8W+CEyG8NruMy e/WYv4xQ9bPKlOGU1lMrCG2U97WzjuaoqNrQ6RaVDciGviHbc910ycHIAMx6JK/gdsgOr8ekx qO27YL6l9JZffv7E+ZfzLDzVKBSMUZ4JH7YOdyDQvjgkJ+qlaNgdSupc1MaKJjsxy1pqAB3Ra t4tC9Tkyl7Yrf+UE5lnrPompEFS1QuwiRjTd67U8/rWywJrlzJWo8HXrG1gMXMCyCqGt1pIMq Sb9we1yCvUvuHasb2MEGTqfPQxjx9JwKRnfwr6rqRro8q7bxLYVkylpSfrgLOe98xJYs= Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org A rare randconfig build error shows up when we have CONFIG_CRYPTO=m in combination with a built-in CCREE driver: crypto/hmac.o: In function `hmac_update': hmac.c:(.text.hmac_update+0x28): undefined reference to `crypto_shash_update' crypto/hmac.o: In function `hmac_setkey': hmac.c:(.text.hmac_setkey+0x90): undefined reference to `crypto_shash_digest' hmac.c:(.text.hmac_setkey+0x154): undefined reference to `crypto_shash_update' drivers/staging/ccree/ssi_cipher.o: In function `ssi_blkcipher_setkey': ssi_cipher.c:(.text.ssi_blkcipher_setkey+0x350): undefined reference to `crypto_shash_digest' drivers/staging/ccree/ssi_cipher.o: In function `ssi_blkcipher_exit': ssi_cipher.c:(.text.ssi_blkcipher_exit+0xd4): undefined reference to `crypto_destroy_tfm' drivers/staging/ccree/ssi_cipher.o: In function `ssi_blkcipher_init': ssi_cipher.c:(.text.ssi_blkcipher_init+0x1b0): undefined reference to `crypto_alloc_shash' drivers/staging/ccree/ssi_cipher.o: In function `ssi_ablkcipher_free': ssi_cipher.c:(.text.ssi_ablkcipher_free+0x48): undefined reference to `crypto_unregister_alg' drivers/staging/ccree/ssi_cipher.o: In function `ssi_ablkcipher_alloc': ssi_cipher.c:(.text.ssi_ablkcipher_alloc+0x138): undefined reference to `crypto_register_alg' ssi_cipher.c:(.text.ssi_ablkcipher_alloc+0x274): undefined reference to `crypto_blkcipher_type' We actually need to depend on both CRYPTO and CRYPTO_HW here to avoid the problem, since CRYPTO_HW is a bool symbol and by itself that does not force CCREE to be a loadable module when the core cryto support is modular. Fixes: 50cfbbb7e627 ("staging: ccree: add ahash support") Signed-off-by: Arnd Bergmann --- drivers/staging/ccree/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 Acked-By: Gilad Ben-Yossef diff --git a/drivers/staging/ccree/Kconfig b/drivers/staging/ccree/Kconfig index ae627049c499..4be87f503e3b 100644 --- a/drivers/staging/ccree/Kconfig +++ b/drivers/staging/ccree/Kconfig @@ -1,6 +1,6 @@ config CRYPTO_DEV_CCREE tristate "Support for ARM TrustZone CryptoCell C7XX family of Crypto accelerators" - depends on CRYPTO_HW && OF && HAS_DMA + depends on CRYPTO && CRYPTO_HW && OF && HAS_DMA default n select CRYPTO_HASH select CRYPTO_BLKCIPHER