From patchwork Mon Jun 27 09:17:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102085 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp971150qgy; Mon, 27 Jun 2016 02:16:11 -0700 (PDT) X-Received: by 10.98.109.134 with SMTP id i128mr31151188pfc.72.1467018971624; Mon, 27 Jun 2016 02:16:11 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g71si25626856pfj.152.2016.06.27.02.16.11 for ; Mon, 27 Jun 2016 02:16:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751709AbcF0JQJ (ORCPT ); Mon, 27 Jun 2016 05:16:09 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:58657 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbcF0JQI (ORCPT ); Mon, 27 Jun 2016 05:16:08 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue002) with ESMTPA (Nemesis) id 0MB724-1b9isw3glo-00A08J; Mon, 27 Jun 2016 11:15:46 +0200 From: Arnd Bergmann To: Herbert Xu Cc: Arnd Bergmann , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: ux500: do not build with -O0 Date: Mon, 27 Jun 2016 11:17:40 +0200 Message-Id: <20160627091809.1349621-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:7sh9dhqSAuGlEBK/8jeSOcFwvcu6rcFLCVUAjImXMAzJgswXJbu B7Ey9VFloOQqF7Vv9Dt5vW4VdfDGgczdWsWO7UUeGuDezdXJZd9YSmlFdnjyNE0rN3G7KsU tX9wVcM5qM4+IpOqaLfl4QquIbt/9DdBGK1tXyGpz1axM9JcbvmKMtHlK6mI0yXBVYQAt8A ZYqXqY9G5sz5q35cSGhdQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:NjHALCzjI7Y=:iR+gLUhaawoWbEhp9TwFWG tcvX7WOcIQGo9SeUxs2OtpKYYpgGGzr4dMb8p+Cq4SRtS7BZfcTlPdR+0JBLQ0nxIbJRDZHOo Mo/u9h5QkvfFyHJjx384vKnhdQNj7iHr1L/W4gqd0ZAA+LAQT2OMgoMZ5AVcRe5/SSV2XT4e4 2X20AwYXVTZ4dQdXFmqTnd3fQqjAbEadCq1SjmlB07xsLHlh1XUejffVfAwgyKZwPdi3cJEr8 5nHHb78p0A/LiuiwdARtU1JHr8Y+9jIoBKv+A7YN2X/qQt8g6YRfEEGhQa3JIzKjK1aY2dkF9 b2hK8t0vWAdeAh63Qhf6SdJtjhoOCvszQZO2WlB1scJgzsfQYg5hxTe2MY1ZwxSEwuGOfdPjI BzMuARwJLO3/OoLJ7ko3Suh8oGzENL5be6GORiUNhLE83UbvmkgALJZZsj6oV4hb5jtr8Mh7W dpAba2WFmUnnnkFFROh0DJR9bMWpVvB+WTt/yUL0TaVOO82cUrMKyatP8FqSt3tC5FLE8y8Xh ugyPgqgM0nVUnzKXHJYu8GyPyz9E5j17w+m0BIHD2MLri6rQXQ2AiGK7nnIyolSkFlksiZ0IN BWibNcqaF1W661gX1g6bD1B6eMeVhQ1bpHxwZhe2NRcWunkhSEhlaxX9rX6OIbIMQfHwPOU69 8HP03tTJ82TynprdD4jVLxAig1tJgwsvWAyLKYQDTRjgDEUBPso6z1n/GnmYq4qz/1oE= Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The ARM allmodconfig build currently warngs because of the ux500 crypto driver not working well with the jump label implementation that we started using for dynamic debug, which breaks building with 'gcc -O0': In file included from /git/arm-soc/include/linux/jump_label.h:105:0, from /git/arm-soc/include/linux/dynamic_debug.h:5, from /git/arm-soc/include/linux/printk.h:289, from /git/arm-soc/include/linux/kernel.h:13, from /git/arm-soc/include/linux/clk.h:16, from /git/arm-soc/drivers/crypto/ux500/hash/hash_core.c:16: /git/arm-soc/arch/arm/include/asm/jump_label.h: In function 'hash_set_dma_transfer': /git/arm-soc/arch/arm/include/asm/jump_label.h:13:7: error: asm operand 0 probably doesn't match constraints [-Werror] asm_volatile_goto("1:\n\t" Turning off compiler optimizations has never really been supported here, and it's only used when debugging the driver. I have not found a good reason for doing this here, other than a misguided attempt to produce more readable assembly output. Also, the driver is only used in obsolete hardware that almost certainly nobody will spend time debugging any more. This just removes the -O0 flag from the compiler options. Signed-off-by: Arnd Bergmann --- drivers/crypto/ux500/cryp/Makefile | 6 +++--- drivers/crypto/ux500/hash/Makefile | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/crypto/ux500/cryp/Makefile b/drivers/crypto/ux500/cryp/Makefile index e5d362a6f680..b497ae3dde07 100644 --- a/drivers/crypto/ux500/cryp/Makefile +++ b/drivers/crypto/ux500/cryp/Makefile @@ -4,9 +4,9 @@ # * License terms: GNU General Public License (GPL) version 2 */ ifdef CONFIG_CRYPTO_DEV_UX500_DEBUG -CFLAGS_cryp_core.o := -DDEBUG -O0 -CFLAGS_cryp.o := -DDEBUG -O0 -CFLAGS_cryp_irq.o := -DDEBUG -O0 +CFLAGS_cryp_core.o := -DDEBUG +CFLAGS_cryp.o := -DDEBUG +CFLAGS_cryp_irq.o := -DDEBUG endif obj-$(CONFIG_CRYPTO_DEV_UX500_CRYP) += ux500_cryp.o diff --git a/drivers/crypto/ux500/hash/Makefile b/drivers/crypto/ux500/hash/Makefile index b2f90d9bac72..784d9c0a8853 100644 --- a/drivers/crypto/ux500/hash/Makefile +++ b/drivers/crypto/ux500/hash/Makefile @@ -4,7 +4,7 @@ # License terms: GNU General Public License (GPL) version 2 # ifdef CONFIG_CRYPTO_DEV_UX500_DEBUG -CFLAGS_hash_core.o := -DDEBUG -O0 +CFLAGS_hash_core.o := -DDEBUG endif obj-$(CONFIG_CRYPTO_DEV_UX500_HASH) += ux500_hash.o