From patchwork Fri Nov 13 08:58:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Shi X-Patchwork-Id: 324280 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp1032778ils; Fri, 13 Nov 2020 00:58:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJzO6LjOdu49WaHjweKMXwWDnJYatGe+Ty5NQ/1rLe1PxNGjnDLp6UIJXuxe/7YOgLI/9n5W X-Received: by 2002:a17:906:77c5:: with SMTP id m5mr974770ejn.424.1605257930623; Fri, 13 Nov 2020 00:58:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605257930; cv=none; d=google.com; s=arc-20160816; b=wNuEKFmvX0whle95l9l1rwIYPFI4zxHZ8Oj9aRIiVCT7C/stjE4zNdRrbIW3v32cvE aB5q8CFbZxYXQmt5/DOloT8TA6r/W6+QI08XwmDF+PBAV9Gyrv4VpXYqK8L3QaHFdjpJ M3eOCPEejBQIN+gFCpKKXd9KhMY57sEtEgRJPgKBKQrlRtHpYg8qMs9PeGRONUNzSzRn mdUQdwCUTMIGRE/fDgxGHIL9ObP5bNCLtbP2R89i7N7SAx52mAKKaOUEBQDGRe8M0BCg 2kWy7A2HXXDDzvh7uziybhUkuttahVCSKksacK3DekFBXxDBDuuKpIWjJRpTEEAfqU4O KfnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:in-reply-to:message-id:date :subject:cc:from; bh=vYj/bwKSdc05lBiUNLXlIu99Qp9DUXJe68gyxk3HWVY=; b=VESmUkVZVngWoIRv4r0BEEDTOSuZTu5Zm1Bg0KDqIEJ4RiT5Z5eRwEJ/nPglNbj6Qe isPlE1MiL1QBFntjoXh/O5TvhTMrCS38ubMdzpImzgC12sPPEEHfim1FgxJdVS+dq2XR f/uZXAcz8WiUEiIYpiZFFRQbl2x3lJ1KpN9/TIgrGVa/XzNS3sSHh2nKFKCoiX3fFwfT jcCuujPNhA7hZixNcjWL+fXAuwdcIl1JSIgF0qMAErI+StjivuP+Sp0dtnU4chkeqN5e Pg7ihmSIU5+S9gi1ksQ5lEAQ8zrS8Q8mBgrmiT2Gs6knBnjmdKjvoUfCoxpESe8Ih6qq eKAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o60si6258948eda.61.2020.11.13.00.58.50; Fri, 13 Nov 2020 00:58:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726181AbgKMI6p (ORCPT + 2 others); Fri, 13 Nov 2020 03:58:45 -0500 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]:40886 "EHLO out30-57.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726348AbgKMI6n (ORCPT ); Fri, 13 Nov 2020 03:58:43 -0500 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R811e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e01424; MF=alex.shi@linux.alibaba.com; NM=1; PH=DS; RN=6; SR=0; TI=SMTPD_---0UFAepvk_1605257910; Received: from aliy80.localdomain(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UFAepvk_1605257910) by smtp.aliyun-inc.com(127.0.0.1); Fri, 13 Nov 2020 16:58:39 +0800 From: Alex Shi Cc: David Howells , Herbert Xu , "David S. Miller" , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] PKCS#7: drop function from kernel-doc pkcs7_validate_trust_one Date: Fri, 13 Nov 2020 16:58:15 +0800 Message-Id: <1605257895-5536-6-git-send-email-alex.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1605257895-5536-1-git-send-email-alex.shi@linux.alibaba.com> References: <1605257895-5536-1-git-send-email-alex.shi@linux.alibaba.com> To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The function is a static function, so no needs add into kernel-doc. and we could avoid warning: crypto/asymmetric_keys/pkcs7_trust.c:25: warning: Function parameter or member 'pkcs7' not described in 'pkcs7_validate_trust_one' crypto/asymmetric_keys/pkcs7_trust.c:25: warning: Function parameter or member 'sinfo' not described in 'pkcs7_validate_trust_one' crypto/asymmetric_keys/pkcs7_trust.c:25: warning: Function parameter or member 'trust_keyring' not described in 'pkcs7_validate_trust_one' Signed-off-by: Alex Shi Cc: David Howells Cc: Herbert Xu Cc: "David S. Miller" Cc: keyrings@vger.kernel.org Cc: linux-crypto@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- crypto/asymmetric_keys/pkcs7_trust.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.29.GIT diff --git a/crypto/asymmetric_keys/pkcs7_trust.c b/crypto/asymmetric_keys/pkcs7_trust.c index 61af3c4d82cc..b531df2013c4 100644 --- a/crypto/asymmetric_keys/pkcs7_trust.c +++ b/crypto/asymmetric_keys/pkcs7_trust.c @@ -16,7 +16,7 @@ #include #include "pkcs7_parser.h" -/** +/* * Check the trust on one PKCS#7 SignedInfo block. */ static int pkcs7_validate_trust_one(struct pkcs7_message *pkcs7,