From patchwork Tue Sep 5 12:38:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gilad Ben-Yossef X-Patchwork-Id: 111685 Delivered-To: patch@linaro.org Received: by 10.140.94.166 with SMTP id g35csp2786534qge; Tue, 5 Sep 2017 05:43:50 -0700 (PDT) X-Google-Smtp-Source: ADKCNb5ro6ec/rogVi/Gi3hUJZH7kI5yopnTveggv8oBMizIZzrn5/x7uI973JZBfDQAaiKuKJCr X-Received: by 10.98.103.89 with SMTP id b86mr3480962pfc.319.1504615430787; Tue, 05 Sep 2017 05:43:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504615430; cv=none; d=google.com; s=arc-20160816; b=vXqN00kCWhxWbvcYyU6EuQtXCU8J5wkrYucFDzCDXS7sh+By0ny361W15dQYOga5g3 EiK0m1y6EUhHFinReIMHW5dReBLCC87sY5v5H1fT7jkxhayF0MfiYG0zUlf+jYE/sL9y vIkAKaY3L4LEGqQsfe5t7kwxuG0yq8XH7+D4DFFJrYvC2mo0DuvyUMWYtzVPyKpSZpUC 2MfcmlaLBevAVZtMoZfd6RySqVd56waxO9Y7zdov5GZgAiT6F/pCOnt+oFNB3N7YLNBz 0lXPziiEI8iaT/xX7ZaxKSjY5OZ1AS73/rEifoHmqfduaUHvdV3w9r1WhJ62hypr6/zd /sjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=ZEEwY7S0lvfkzX5eSnqpbx2gek6uifwcDnkIXVl4mV0=; b=ZfaxJzDu4ECIJe1wfb7wkrxOIah9SAYClP2FGBh5EKOrGK8euqH86nYtDcqDXeM2Zw UZLhFGz3Pw8Om5T4yc7g+0GIaTH+tTv1rjXAxXn2mQtqHNC1DHc/W+bwGwgFOSm3FDwb XFrN9YHt7vtgt9jyKXNgpAyvwDRXedcCILAVcwxKk/FpCCxa7uRagVBSu8LpC2QnRqA5 MiXm9Ldo3NcaBcl1be9skTdgSTySwIlfi5Mfk4UQd0/UFZgR+EB06BdpJhct8+zRb5kR +oS3l4pGaAR+6e5/6phv/Dyibey0i7ATC9cQtlIISoZzFtkRGzZIa1F3E2R883W2tSi6 OXzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c30si196431pgn.746.2017.09.05.05.43.50; Tue, 05 Sep 2017 05:43:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752284AbdIEMns (ORCPT + 1 other); Tue, 5 Sep 2017 08:43:48 -0400 Received: from foss.arm.com ([217.140.101.70]:39922 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752282AbdIEMno (ORCPT ); Tue, 5 Sep 2017 08:43:44 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E836168F; Tue, 5 Sep 2017 05:43:43 -0700 (PDT) Received: from gby.kfn.arm.com (unknown [10.45.48.140]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 35A013F3E1; Tue, 5 Sep 2017 05:43:33 -0700 (PDT) From: Gilad Ben-Yossef To: Herbert Xu , "David S. Miller" , Jonathan Corbet , David Howells , Tom Lendacky , Gary Hook , Boris Brezillon , Arnaud Ebalard , Matthias Brugger , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Shaohua Li , Steve French , "Theodore Y. Ts'o" , Jaegeuk Kim , Steffen Klassert , Alexey Kuznetsov , Hideaki YOSHIFUJI , Mimi Zohar , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-raid@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fscrypt@vger.kernel.org, netdev@vger.kernel.org, linux-ima-devel@lists.sourceforge.net, linux-ima-user@lists.sourceforge.net, linux-security-module@vger.kernel.org Cc: Ofir Drang Subject: [PATCH v8 18/20] crypto: qce: move to generic async completion Date: Tue, 5 Sep 2017 15:38:57 +0300 Message-Id: <1504615144-29770-19-git-send-email-gilad@benyossef.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1504615144-29770-1-git-send-email-gilad@benyossef.com> References: <1504615144-29770-1-git-send-email-gilad@benyossef.com> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The qce driver starts several async crypto ops and waits for their completions. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- drivers/crypto/qce/sha.c | 30 ++++-------------------------- 1 file changed, 4 insertions(+), 26 deletions(-) -- 2.1.4 diff --git a/drivers/crypto/qce/sha.c b/drivers/crypto/qce/sha.c index 47e114a..53227d7 100644 --- a/drivers/crypto/qce/sha.c +++ b/drivers/crypto/qce/sha.c @@ -349,28 +349,12 @@ static int qce_ahash_digest(struct ahash_request *req) return qce->async_req_enqueue(tmpl->qce, &req->base); } -struct qce_ahash_result { - struct completion completion; - int error; -}; - -static void qce_digest_complete(struct crypto_async_request *req, int error) -{ - struct qce_ahash_result *result = req->data; - - if (error == -EINPROGRESS) - return; - - result->error = error; - complete(&result->completion); -} - static int qce_ahash_hmac_setkey(struct crypto_ahash *tfm, const u8 *key, unsigned int keylen) { unsigned int digestsize = crypto_ahash_digestsize(tfm); struct qce_sha_ctx *ctx = crypto_tfm_ctx(&tfm->base); - struct qce_ahash_result result; + struct crypto_wait wait; struct ahash_request *req; struct scatterlist sg; unsigned int blocksize; @@ -405,9 +389,9 @@ static int qce_ahash_hmac_setkey(struct crypto_ahash *tfm, const u8 *key, goto err_free_ahash; } - init_completion(&result.completion); + crypto_init_wait(&wait); ahash_request_set_callback(req, CRYPTO_TFM_REQ_MAY_BACKLOG, - qce_digest_complete, &result); + crypto_req_done, &wait); crypto_ahash_clear_flags(ahash_tfm, ~0); buf = kzalloc(keylen + QCE_MAX_ALIGN_SIZE, GFP_KERNEL); @@ -420,13 +404,7 @@ static int qce_ahash_hmac_setkey(struct crypto_ahash *tfm, const u8 *key, sg_init_one(&sg, buf, keylen); ahash_request_set_crypt(req, &sg, ctx->authkey, keylen); - ret = crypto_ahash_digest(req); - if (ret == -EINPROGRESS || ret == -EBUSY) { - ret = wait_for_completion_interruptible(&result.completion); - if (!ret) - ret = result.error; - } - + ret = crypto_wait_req(crypto_ahash_digest(req), &wait); if (ret) crypto_ahash_set_flags(tfm, CRYPTO_TFM_RES_BAD_KEY_LEN);