From patchwork Tue Sep 5 12:38:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gilad Ben-Yossef X-Patchwork-Id: 111677 Delivered-To: patch@linaro.org Received: by 10.140.94.166 with SMTP id g35csp2784469qge; Tue, 5 Sep 2017 05:41:54 -0700 (PDT) X-Google-Smtp-Source: ADKCNb67cKcZFrWLoCSdf7oLfsPw6u+XCwDRPsWSPXDP0dxpoIQ5iAOP7cfoYB2u8lDK0i+sICgt X-Received: by 10.84.241.201 with SMTP id t9mr4110133plm.61.1504615314474; Tue, 05 Sep 2017 05:41:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504615314; cv=none; d=google.com; s=arc-20160816; b=eqXtQt7iTq0MKiNnFhQXomLd2yv19rKIqsoF8QTaSiBak0cOfkArrx2M+umAdYIi00 vXyEpTOM5wS7P67Ecx2IfrBbJEAABlXMRjgWA0SuMomLdMTDfI0ElJ0zcWlCHM+KZNw1 6zMJ591/k/obguVL+EPeo5Kyn6jcrF+irOrNMD2VUsaGfsUdDZKIAo+tm5CDifoVWow1 gfusDvWfX0ANIFwO38i9I+tcAcup+Qb8W7TfdtNxOQXRTmwKFZXOH4XZG439Gvo8LaDg 6+xc/ksaj3TeU69pszJoyIkdMxdwMItemrpkKelltxkcdquYisrrZuKqFShBHcDfX9My 4z5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=yGaAHjHUMBmQzH3ic2oX8wNfseqXS3eodE5CNvqrLCs=; b=QwnKl3vDIjSMKTGnbZ7Yad2S4JsiickAQd7J0reosjOppVY8pqWyT0rRi9I5GctUU9 RlPCOpy0qyLI554wNOhRUBETK58WgkhIp3q7hIIi1fPEphxmHYGONlE2IIf1rq4ai42F E5cH8SwqhtxR3WwPYczv+4p1+GQ1o+jg78xNvHTdJMNqcKh9wznLpmy5cNnmm6p4DMZI /ZAYJrQVwURdyCl3x0kmhfoRPKM9lzxYfhJ9WkKE0DDVNq+NJo1HopU49vK8Tuys1QE5 22gapYuop3xL0AnLi1YqMSH/dhlfO6jIqUaJd/SWH3t/U7x1fmi32JlPetaX63fHV2km epjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q7si291407plk.638.2017.09.05.05.41.54; Tue, 05 Sep 2017 05:41:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751388AbdIEMlw (ORCPT + 1 other); Tue, 5 Sep 2017 08:41:52 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:39464 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751036AbdIEMls (ORCPT ); Tue, 5 Sep 2017 08:41:48 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5AD961688; Tue, 5 Sep 2017 05:41:47 -0700 (PDT) Received: from gby.kfn.arm.com (unknown [10.45.48.140]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 14A3D3F3E1; Tue, 5 Sep 2017 05:41:36 -0700 (PDT) From: Gilad Ben-Yossef To: Herbert Xu , "David S. Miller" , Jonathan Corbet , David Howells , Tom Lendacky , Gary Hook , Boris Brezillon , Arnaud Ebalard , Matthias Brugger , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Shaohua Li , Steve French , "Theodore Y. Ts'o" , Jaegeuk Kim , Steffen Klassert , Alexey Kuznetsov , Hideaki YOSHIFUJI , Mimi Zohar , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-raid@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fscrypt@vger.kernel.org, netdev@vger.kernel.org, linux-ima-devel@lists.sourceforge.net, linux-ima-user@lists.sourceforge.net, linux-security-module@vger.kernel.org Cc: Ofir Drang Subject: [PATCH v8 10/20] crypto: move gcm to generic async completion Date: Tue, 5 Sep 2017 15:38:49 +0300 Message-Id: <1504615144-29770-11-git-send-email-gilad@benyossef.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1504615144-29770-1-git-send-email-gilad@benyossef.com> References: <1504615144-29770-1-git-send-email-gilad@benyossef.com> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org gcm is starting an async. crypto op and waiting for it complete. Move it over to generic code doing the same. Signed-off-by: Gilad Ben-Yossef --- crypto/gcm.c | 32 ++++++-------------------------- 1 file changed, 6 insertions(+), 26 deletions(-) -- 2.1.4 diff --git a/crypto/gcm.c b/crypto/gcm.c index 3841b5e..fb923a5 100644 --- a/crypto/gcm.c +++ b/crypto/gcm.c @@ -16,7 +16,6 @@ #include #include #include "internal.h" -#include #include #include #include @@ -78,11 +77,6 @@ struct crypto_gcm_req_priv_ctx { } u; }; -struct crypto_gcm_setkey_result { - int err; - struct completion completion; -}; - static struct { u8 buf[16]; struct scatterlist sg; @@ -98,17 +92,6 @@ static inline struct crypto_gcm_req_priv_ctx *crypto_gcm_reqctx( return (void *)PTR_ALIGN((u8 *)aead_request_ctx(req), align + 1); } -static void crypto_gcm_setkey_done(struct crypto_async_request *req, int err) -{ - struct crypto_gcm_setkey_result *result = req->data; - - if (err == -EINPROGRESS) - return; - - result->err = err; - complete(&result->completion); -} - static int crypto_gcm_setkey(struct crypto_aead *aead, const u8 *key, unsigned int keylen) { @@ -119,7 +102,7 @@ static int crypto_gcm_setkey(struct crypto_aead *aead, const u8 *key, be128 hash; u8 iv[16]; - struct crypto_gcm_setkey_result result; + struct crypto_wait wait; struct scatterlist sg[1]; struct skcipher_request req; @@ -140,21 +123,18 @@ static int crypto_gcm_setkey(struct crypto_aead *aead, const u8 *key, if (!data) return -ENOMEM; - init_completion(&data->result.completion); + crypto_init_wait(&data->wait); sg_init_one(data->sg, &data->hash, sizeof(data->hash)); skcipher_request_set_tfm(&data->req, ctr); skcipher_request_set_callback(&data->req, CRYPTO_TFM_REQ_MAY_SLEEP | CRYPTO_TFM_REQ_MAY_BACKLOG, - crypto_gcm_setkey_done, - &data->result); + crypto_req_done, + &data->wait); skcipher_request_set_crypt(&data->req, data->sg, data->sg, sizeof(data->hash), data->iv); - err = crypto_skcipher_encrypt(&data->req); - if (err == -EINPROGRESS || err == -EBUSY) { - wait_for_completion(&data->result.completion); - err = data->result.err; - } + err = crypto_wait_req(crypto_skcipher_encrypt(&data->req), + &data->wait); if (err) goto out;