From patchwork Mon Jan 23 14:05:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 92216 Delivered-To: patch@linaro.org Received: by 10.182.3.34 with SMTP id 2csp1233356obz; Mon, 23 Jan 2017 06:05:40 -0800 (PST) X-Received: by 10.84.233.193 with SMTP id m1mr43683808pln.126.1485180340215; Mon, 23 Jan 2017 06:05:40 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l36si15767527plg.145.2017.01.23.06.05.40; Mon, 23 Jan 2017 06:05:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751211AbdAWOFj (ORCPT + 1 other); Mon, 23 Jan 2017 09:05:39 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:34894 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbdAWOFj (ORCPT ); Mon, 23 Jan 2017 09:05:39 -0500 Received: by mail-wm0-f50.google.com with SMTP id r126so134566502wmr.0 for ; Mon, 23 Jan 2017 06:05:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Twhl3TaN4Yleujf68Qk0fFCweF7qBJDAw0TmYcZHr54=; b=LcEw6/q864dt5+4omHGy9/9HWRqXGXfBCSiHexSequfCutwlCXKYagmwhg2MMmCz3J TsW4W4fGLBnZu0h6sa6hStHq12M5wfQFBfwddxkQSZVVcLBAH41BtD404FXkrp+C2r3O zatWw/XYbmeKufoj84tV3xo0dcR4c0NS1rUM4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Twhl3TaN4Yleujf68Qk0fFCweF7qBJDAw0TmYcZHr54=; b=RnMAN2jtZ8XRBD91ImSJtRZ4mF9caxGbPSfg4QIe2MMFUBlWGIojvdNpP3ZYoOQwl7 mQCReOcb2ZWpda6ETca1Nx1CXjRx/mCaqOnDBQhU8PtL7nHcJaPn82LaegmIb3Y3vlSX i4rCcV4yBEel0MAur4zt6i01IjZWKOKIFxmOxE7fKRGjx8Kyw2ZZJkE0JHNTwLGxS65D 8ZZq4sCsaEoCUvg2otB3sCaOihFamWWAwFZ/+k94zoWeN4oL3395ldhBG6Lm7YnBcSte EzukKP4QXTJP9YKNylhF7hxxBkASIhQe6dq+cSHgva+90216r8EJf1EajHzUB8Efu+79 7+TQ== X-Gm-Message-State: AIkVDXL/6X+DQ2YjTA/5cYrO6IFPvS0rn3f8WaXrWbMOuW0xzzOey5UjTXfPkZ0sWRLlhDNH X-Received: by 10.28.152.79 with SMTP id a76mr13294204wme.16.1485180337640; Mon, 23 Jan 2017 06:05:37 -0800 (PST) Received: from localhost.localdomain ([160.160.111.139]) by smtp.gmail.com with ESMTPSA id y65sm21319790wmb.5.2017.01.23.06.05.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 23 Jan 2017 06:05:37 -0800 (PST) From: Ard Biesheuvel To: linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au Cc: Ard Biesheuvel Subject: [PATCH v2 03/10] crypto: arm/chacha20 - remove cra_alignmask Date: Mon, 23 Jan 2017 14:05:19 +0000 Message-Id: <1485180326-25612-4-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1485180326-25612-1-git-send-email-ard.biesheuvel@linaro.org> References: <1485180326-25612-1-git-send-email-ard.biesheuvel@linaro.org> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Remove the unnecessary alignmask: it is much more efficient to deal with the misalignment in the core algorithm than relying on the crypto API to copy the data to a suitably aligned buffer. Signed-off-by: Ard Biesheuvel --- arch/arm/crypto/chacha20-neon-glue.c | 1 - 1 file changed, 1 deletion(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/crypto/chacha20-neon-glue.c b/arch/arm/crypto/chacha20-neon-glue.c index 592f75ae4fa1..59a7be08e80c 100644 --- a/arch/arm/crypto/chacha20-neon-glue.c +++ b/arch/arm/crypto/chacha20-neon-glue.c @@ -94,7 +94,6 @@ static struct skcipher_alg alg = { .base.cra_priority = 300, .base.cra_blocksize = 1, .base.cra_ctxsize = sizeof(struct chacha20_ctx), - .base.cra_alignmask = 1, .base.cra_module = THIS_MODULE, .min_keysize = CHACHA20_KEY_SIZE,