From patchwork Mon Mar 23 20:33:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 46217 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f198.google.com (mail-wi0-f198.google.com [209.85.212.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id DDB7020D10 for ; Mon, 23 Mar 2015 20:33:33 +0000 (UTC) Received: by widex7 with SMTP id ex7sf9585994wid.2 for ; Mon, 23 Mar 2015 13:33:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=7iXlTUKyi8HDTWznDwKRMVSeU2CWY/4kGI7IaXG0tNo=; b=TkAohiRlyUhCJtCXsUVaZXNiUMSbm7uBjEHX+o57Wk60NnyfPNgltfWF4YQYlV6euh F20JvR0THS9Wsvz+uS/0mBVmBMR6s/itcjp4I9MRRgd/rpWy8c/oN2mP9n1XLVxBSbgt IyI+X9R9fGDQLJ06NvVRUnMrRJal3apyN8Gs+cx3zXwf5kUS7xLPsiwzfjeAA71Bu98U wYqWtiJkKZPBDDrEs3+TKJmBWenzFFkpAdZBf2pF50udwZeSvla0YWSuI9fnXOYOID90 sKxUtGH7SmPLyGud0+haaG3Cqzuk7hheoUNk0Hb3rhNom3+Fpax7GKCng/F/hWxypvtL sYRQ== X-Gm-Message-State: ALoCoQnKdqepWA5XiLpArwlICFuwacqcQcGckBJttOblCk6gsE8OYPAgPE+6mwM9PR1JeF12Ok0k X-Received: by 10.180.81.134 with SMTP id a6mr2404403wiy.1.1427142813156; Mon, 23 Mar 2015 13:33:33 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.37.194 with SMTP id a2ls677849lak.88.gmail; Mon, 23 Mar 2015 13:33:32 -0700 (PDT) X-Received: by 10.112.140.38 with SMTP id rd6mr787748lbb.116.1427142812866; Mon, 23 Mar 2015 13:33:32 -0700 (PDT) Received: from mail-la0-f53.google.com (mail-la0-f53.google.com. [209.85.215.53]) by mx.google.com with ESMTPS id qk1si1421915lbb.60.2015.03.23.13.33.32 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Mar 2015 13:33:32 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.53 as permitted sender) client-ip=209.85.215.53; Received: by labto5 with SMTP id to5so36173269lab.0 for ; Mon, 23 Mar 2015 13:33:32 -0700 (PDT) X-Received: by 10.152.197.34 with SMTP id ir2mr864085lac.36.1427142812723; Mon, 23 Mar 2015 13:33:32 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.57.201 with SMTP id k9csp1060643lbq; Mon, 23 Mar 2015 13:33:31 -0700 (PDT) X-Received: by 10.67.7.102 with SMTP id db6mr1823527pad.14.1427142810828; Mon, 23 Mar 2015 13:33:30 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id pq10si2533606pbb.99.2015.03.23.13.33.30 for ; Mon, 23 Mar 2015 13:33:30 -0700 (PDT) Received-SPF: none (google.com: linux-crypto-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752512AbbCWUd2 (ORCPT ); Mon, 23 Mar 2015 16:33:28 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:35392 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752603AbbCWUdQ (ORCPT ); Mon, 23 Mar 2015 16:33:16 -0400 Received: by wibdy8 with SMTP id dy8so57814741wib.0 for ; Mon, 23 Mar 2015 13:33:14 -0700 (PDT) X-Received: by 10.194.20.67 with SMTP id l3mr1704095wje.94.1427142794153; Mon, 23 Mar 2015 13:33:14 -0700 (PDT) Received: from ards-macbook-pro.local (62.82.106.185.static.user.ono.com. [62.82.106.185]) by mx.google.com with ESMTPSA id ch6sm3010517wjc.3.2015.03.23.13.33.12 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 23 Mar 2015 13:33:13 -0700 (PDT) From: Ard Biesheuvel To: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Ard Biesheuvel Subject: [PATCH] crypto/arm: fix big-endian bug in ghash Date: Mon, 23 Mar 2015 21:33:09 +0100 Message-Id: <1427142789-13960-1-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 1.8.3.2 Sender: linux-crypto-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ard.biesheuvel@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.53 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This fixes a bug in the new v8 Crypto Extensions GHASH code that only manifests itself in big-endian mode. Signed-off-by: Ard Biesheuvel --- arch/arm/crypto/ghash-ce-core.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/crypto/ghash-ce-core.S b/arch/arm/crypto/ghash-ce-core.S index e643a15eadf2..f6ab8bcc9efe 100644 --- a/arch/arm/crypto/ghash-ce-core.S +++ b/arch/arm/crypto/ghash-ce-core.S @@ -40,7 +40,7 @@ * struct ghash_key const *k, const char *head) */ ENTRY(pmull_ghash_update) - vld1.8 {SHASH}, [r3] + vld1.64 {SHASH}, [r3] vld1.64 {XL}, [r1] vmov.i8 MASK, #0xe1 vext.8 SHASH2, SHASH, SHASH, #8