From patchwork Tue Jan 31 08:00:25 2023
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Herbert Xu <herbert@gondor.apana.org.au>
X-Patchwork-Id: 649342
Return-Path: <linux-crypto-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 65832C38142
 for <linux-crypto@archiver.kernel.org>; Tue, 31 Jan 2023 08:00:42 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S229559AbjAaIAk (ORCPT <rfc822;linux-crypto@archiver.kernel.org>);
 Tue, 31 Jan 2023 03:00:40 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58620 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
 with ESMTP id S231331AbjAaIAe (ORCPT
 <rfc822;linux-crypto@vger.kernel.org>);
 Tue, 31 Jan 2023 03:00:34 -0500
Received: from formenos.hmeau.com (helcar.hmeau.com [216.24.177.18])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 875C640BF5
 for <linux-crypto@vger.kernel.org>;
 Tue, 31 Jan 2023 00:00:32 -0800 (PST)
Received: from loth.rohan.me.apana.org.au ([192.168.167.2])
 by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian))
 id 1pMlZ3-005vct-CF; Tue, 31 Jan 2023 16:00:26 +0800
Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation);
 Tue, 31 Jan 2023 16:00:25 +0800
Date: Tue, 31 Jan 2023 16:00:25 +0800
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
 Tudor Ambarus <tudor.ambarus@microchip.com>,
 Jesper Nilsson <jesper.nilsson@axis.com>,
 Lars Persson <lars.persson@axis.com>, linux-arm-kernel@axis.com,
 Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>,
 George Cherian <gcherian@marvell.com>,
 Tom Lendacky <thomas.lendacky@amd.com>, John Allen <john.allen@amd.com>,
 Ayush Sawal <ayush.sawal@chelsio.com>, Kai Ye <yekai13@huawei.com>,
 Longfang Liu <liulongfang@huawei.com>, Antoine Tenart <atenart@kernel.org>,
 Corentin Labbe <clabbe@baylibre.com>,
 Boris Brezillon <bbrezillon@kernel.org>,
 Arnaud Ebalard <arno@natisbad.org>, Srujana Challa <schalla@marvell.com>,
 Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
 qat-linux@intel.com, Thara Gopinath <thara.gopinath@gmail.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Vladimir Zapolskiy <vz@mleia.com>
Subject: [PATCH 0/32] crypto: api - Prepare to change callback argument to
 void star
Message-ID: <Y9jKmRsdHsIwfFLo@gondor.apana.org.au>
MIME-Version: 1.0
Content-Disposition: inline
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Hi:

The crypto completion function currently takes a pointer to a
struct crypto_async_request object.  However, in reality the API
does not allow the use of any part of the object apart from the
data field.  For example, ahash/shash will create a fake object
on the stack to pass along a different data field.

This leads to potential bugs where the user may try to dereference
or otherwise use the crypto_async_request object.

This series lays the groundwork for converting the completion
function to take a void * argument instead of crypto_async_request.

Cheers,
Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>