mbox series

[0/3] crypto: jitter - Offer compile-time options

Message ID 2700818.mvXUDI8C0e@positron.chronox.de
Headers show
Series crypto: jitter - Offer compile-time options | expand

Message

Stephan Mueller Sept. 21, 2023, 11:47 a.m. UTC 
Hi,

the following patchset offers a set of compile-time options to
accommodate different hardware with different entropy rates implied
in their timers. This allows configuring the Jitter RNG in systems
which exhibits insufficient entropy with the default parameters. The
default parameters defined by the patches, however, are identical to
the existing code and thus do not alter the Jitter RNG behavior.

The first patch sets the state by allowing the configuration of
different oversampling rates. The second patch allows the configuration
of different memory sizes and the third allows the configuration
of differnet oversampling rates.

The update of the power up test with the first patch also addresses
reports that the Jitter RNG did not initialize due to it detected
insufficient entropy.

Stephan Mueller (3):
  crypto: jitter - add RCT/APT support for different OSRs
  crypto: jitter - Allow configuration of memory size
  crypto: jitter - Allow configuration of oversampling rate

 crypto/Kconfig               |  60 +++++++++
 crypto/jitterentropy-kcapi.c |  17 ++-
 crypto/jitterentropy.c       | 249 ++++++++++++++++++-----------------
 crypto/jitterentropy.h       |   5 +-
 4 files changed, 207 insertions(+), 124 deletions(-)

Comments

Ospan, Abylay Sept. 25, 2023, 3:11 p.m. UTC | #1 
Hi Stephan,

We ran tests with your patches on our bare metal platform (AMD Epyc CPU) and saw an improvement in boot time entropy after analyzing the collected jitter deltas.
Patches looks good to me.
Thanks for your work!

Acked-by: Abylay Ospan <aospan@amazon.com>

-----Original Message-----
From: Stephan Müller <smueller@chronox.de> 
Sent: Thursday, September 21, 2023 7:48 AM
To: herbert@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org; Ospan, Abylay <aospan@amazon.com>
Subject: [EXTERNAL] [PATCH 0/3] crypto: jitter - Offer compile-time options

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.



Hi,

the following patchset offers a set of compile-time options to accommodate different hardware with different entropy rates implied in their timers. This allows configuring the Jitter RNG in systems which exhibits insufficient entropy with the default parameters. The default parameters defined by the patches, however, are identical to the existing code and thus do not alter the Jitter RNG behavior.

The first patch sets the state by allowing the configuration of different oversampling rates. The second patch allows the configuration of different memory sizes and the third allows the configuration of differnet oversampling rates.

The update of the power up test with the first patch also addresses reports that the Jitter RNG did not initialize due to it detected insufficient entropy.

Stephan Mueller (3):
  crypto: jitter - add RCT/APT support for different OSRs
  crypto: jitter - Allow configuration of memory size
  crypto: jitter - Allow configuration of oversampling rate

 crypto/Kconfig               |  60 +++++++++
 crypto/jitterentropy-kcapi.c |  17 ++-
 crypto/jitterentropy.c       | 249 ++++++++++++++++++-----------------
 crypto/jitterentropy.h       |   5 +-
 4 files changed, 207 insertions(+), 124 deletions(-)

--
2.42.0