From patchwork Thu May 4 07:33:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia Jie Ho X-Patchwork-Id: 679181 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4A00C7EE24 for ; Thu, 4 May 2023 07:34:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230059AbjEDHeW convert rfc822-to-8bit (ORCPT ); Thu, 4 May 2023 03:34:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229816AbjEDHeU (ORCPT ); Thu, 4 May 2023 03:34:20 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 945BB1990; Thu, 4 May 2023 00:34:14 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 16A2624E1FE; Thu, 4 May 2023 15:34:08 +0800 (CST) Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 4 May 2023 15:34:07 +0800 Received: from ubuntu.localdomain (161.142.156.10) by EXMBX168.cuchost.com (172.16.6.78) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 4 May 2023 15:34:02 +0800 From: Jia Jie Ho To: Herbert Xu , "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Conor Dooley , Palmer Dabbelt CC: , , , Subject: [PATCH v7 0/4] crypto: starfive - Add drivers for crypto engine Date: Thu, 4 May 2023 15:33:56 +0800 Message-ID: <20230504073400.1170979-1-jiajie.ho@starfivetech.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [161.142.156.10] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX168.cuchost.com (172.16.6.78) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org This patch series adds kernel driver support for StarFive JH7110 crypto engine. The first patch adds Documentations for the device and Patch 2 adds device probe and DMA init for the module. Patch 3 adds crypto and DMA dts node for VisionFive 2 board. Patch 4 adds hash/hmac support to the module. Patch 3 needs to be applied on top of: https://lore.kernel.org/lkml/20230424135409.6648-3-xingyu.wu@starfivetech.com/ Patch 4 needs to be applied on top of: https://lore.kernel.org/linux-crypto/ZEEOXIHwqKblKfBJ@gondor.apana.org.au/T/#u Changes v6->v7 - Remove NULL assignment as struct is kzalloc()-ed (Christophe) - Do clk_disable_unprepare and assert reset if probe failed (Christophe) - Remove unnecessary null pointer check (Christophe) - Update module name in Kconfig description (Christophe) Changes v5->v6 - Remove set_crypt in export as request will have been created by init/updated calls (Herbert) - Use new helper to set statesize of crypto_ahash (Herbert) - Use crypto_ahash_blocksize instead of crypto_ahash_tfm (Herbert) - Switch to init_tfm/exit_tfm instead of cra_init/cra_exit (Herbert) Changes v4->v5 - Schedule tasklet from IRQ handler instead of using completion to sync events (Herbert) Changes v3->v4: - Use fallback for non-aligned cases as hardware doesn't support hashing piece-meal (Herbert) - Use ahash_request_set_* helpers to update members of ahash_request (Herbert) - Set callbacks for async fallback (Herbert) - Remove completion variable and use dma_callback to do the rest of processing instead. (Herbert) Changes v2->v3: - Only implement digest and use fallback for other ops (Herbert) - Use interrupt instead of polling for hash complete (Herbert) - Remove manual data copy from out-of-bound memory location as it will be handled by DMA API. (Christoph & Herbert) Changes v1->v2: - Fixed yaml filename and format (Krzysztof) - Removed unnecessary property names in yaml (Krzysztof) - Moved of_device_id table close to usage (Krzysztof) - Use dev_err_probe for error returns (Krzysztof) - Dropped redundant readl and writel wrappers (Krzysztof) - Updated commit signed offs (Conor) - Dropped redundant node in dts, module set to on in dtsi (Conor) Jia Jie Ho (4): dt-bindings: crypto: Add StarFive crypto module crypto: starfive - Add crypto engine support riscv: dts: starfive: Add crypto and DMA node for VisionFive 2 crypto: starfive - Add hash and HMAC support .../crypto/starfive,jh7110-crypto.yaml | 70 ++ MAINTAINERS | 7 + arch/riscv/boot/dts/starfive/jh7110.dtsi | 28 + drivers/crypto/Kconfig | 1 + drivers/crypto/Makefile | 1 + drivers/crypto/starfive/Kconfig | 21 + drivers/crypto/starfive/Makefile | 4 + drivers/crypto/starfive/jh7110-cryp.c | 240 +++++ drivers/crypto/starfive/jh7110-cryp.h | 127 +++ drivers/crypto/starfive/jh7110-hash.c | 892 ++++++++++++++++++ 10 files changed, 1391 insertions(+) create mode 100644 Documentation/devicetree/bindings/crypto/starfive,jh7110-crypto.yaml create mode 100644 drivers/crypto/starfive/Kconfig create mode 100644 drivers/crypto/starfive/Makefile create mode 100644 drivers/crypto/starfive/jh7110-cryp.c create mode 100644 drivers/crypto/starfive/jh7110-cryp.h create mode 100644 drivers/crypto/starfive/jh7110-hash.c